Received-SPF: pass (google.com: domain of linux-wireless+bounces-3127-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
From: Kalle Valo <kvalo@kernel.org>
To: Jeff Johnson <quic_jjohnson@quicinc.com>
Cc: Kang Yang <quic_kangyang@quicinc.com>,  <ath12k@lists.infradead.org>,
  <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH v6 02/11] wifi: ath12k: fix incorrect logic of
 calculating vdev_stats_id
References: <20240130040303.370590-1-quic_kangyang@quicinc.com>
	<20240130040303.370590-3-quic_kangyang@quicinc.com>
	<ebd1b476-7de7-4cd2-96b0-ae4965348ccb@quicinc.com>
Date: Mon, 05 Feb 2024 17:33:24 +0200
In-Reply-To: <ebd1b476-7de7-4cd2-96b0-ae4965348ccb@quicinc.com> (Jeff
	Johnson's message of "Tue, 30 Jan 2024 08:51:06 -0800")
Message-ID: <87sf27rkmz.fsf@kernel.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux)
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain

Jeff Johnson <quic_jjohnson@quicinc.com> writes:

> On 1/29/2024 8:02 PM, Kang Yang wrote:
>> During calculate vdev_stats_id, will compare vdev_stats_id with
>> ATH12K_INVAL_VDEV_STATS_ID by '<='. If vdev_stats_id is relatively
>> small, then assign ATH12K_INVAL_VDEV_STATS_ID to vdev_stats_id.
>> 
>> This logic is incorrect. Firstly, should use '>=' instead of '<=' to
>> check if this u8 variable exceeds the max valid range.
>> 
>> Secondly, should use the maximum value as comparison value.
>> 
>> Correct comparison symbols and use the maximum value
>> ATH12K_MAX_VDEV_STATS_ID for comparison.
>> 
>> Tested-on: WCN7850 hw2.0 PCI WLAN.HMT.1.0.c5-00481-QCAHMTSWPL_V1.0_V2.0_SILICONZ-3
>
> should be blank line between unofficial Tested-on tag and official Fixes tag
>
>> Fixes: d889913205cf ("wifi: ath12k: driver for Qualcomm Wi-Fi 7 devices")
>> 
> And no blank line here since all the official tags should be together
>
>> Signed-off-by: Kang Yang <quic_kangyang@quicinc.com>
>
> Kalle can fix the above when he moves into the pending branch

Yes, fixed those now.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches