Received-SPF: pass (google.com: domain of linux-wireless+bounces-3195-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Tue, 6 Feb 2024 09:12:57 +0100
From: Pavel Machek <pavel@ucw.cz>
To: Ping-Ke Shih <pkshih@realtek.com>
Cc: Fiona Klute <fiona.klute@gmx.de>,
	"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
	Kalle Valo <kvalo@kernel.org>, Ulf Hansson <ulf.hansson@linaro.org>,
	"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
	=?utf-8?Q?Ond=C5=99ej?= Jirman <megi@xff.cz>
Subject: Re: [PATCH 5/9] wifi: rtw88: Add rtw8703b.c
Message-ID: <ZcHqCRRcgaLdyQSq@duo.ucw.cz>
References: <20240202121050.977223-1-fiona.klute@gmx.de>
 <20240202121050.977223-6-fiona.klute@gmx.de>
 <8b20f91585694702bac414680ba937c9@realtek.com>
 <09d93cef-5338-4463-b656-dab934029c63@gmx.de>
 <28c1571cc90b49ce928ddb929e2bc93f@realtek.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="On/uG6861zw75SjG"
Content-Disposition: inline
In-Reply-To: <28c1571cc90b49ce928ddb929e2bc93f@realtek.com>


--On/uG6861zw75SjG
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

hi!

> > I'm afraid I'm not familiar with the details either, but this is how the
> > SDIO wifi device for the Pinephone is defined (in
> > arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi, as of v6.8-rc2=
):
> >=20
> > &mmc1 {
> >         pinctrl-names =3D "default";
> >         pinctrl-0 =3D <&mmc1_pins>;
> >         vmmc-supply =3D <&reg_vbat_wifi>;
> >         vqmmc-supply =3D <&reg_dldo4>;
> >         bus-width =3D <4>;
> >         non-removable;
> >         status =3D "okay";
> >=20
> >         rtl8723cs: wifi@1 {
>=20
> I think rtl8723cs is module name of vendor driver, so will you add rtw88_=
8723ds?

dts is supposed to describe hardware, not driver structure. So a) this
label should not really matter b) it really should not really be
changed to match the driver name.

Best regards,
								Pavel
--=20
People of Russia, stop Putin before his war on Ukraine escalates.

--On/uG6861zw75SjG
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iF0EABECAB0WIQRPfPO7r0eAhk010v0w5/Bqldv68gUCZcHqCQAKCRAw5/Bqldv6
8uKrAJ96n3Yaxi6qm68GPsUH0ZrYNDZs+ACfWn97GL3BsZSoXgz4k3+G6sOfeKg=
=ryRX
-----END PGP SIGNATURE-----

--On/uG6861zw75SjG--