Received: by 2002:a05:7412:bbc7:b0:fc:a2b0:25d7 with SMTP id kh7csp3086748rdb; Tue, 6 Feb 2024 06:56:34 -0800 (PST) X-Google-Smtp-Source: AGHT+IGUzNl8veUL7xF7fwgpDiY+kZMSZAVfhPTma3jsEuqs8unpFLY6iFc4tVmluMB17lIsyQun X-Received: by 2002:a05:6358:89b:b0:178:6211:871 with SMTP id m27-20020a056358089b00b0017862110871mr4384857rwj.0.1707231393645; Tue, 06 Feb 2024 06:56:33 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707231393; cv=pass; d=google.com; s=arc-20160816; b=Wnn9VXC/d/yuCbN/61UTVoTNjdEKceNCi6/RBrZhZ2TvRS+LJyNu3lhDlsJc/3IgCy xyr55HNX8Qmt8tdOzuxKdl0DutmdfM26BCIszDbQ1VuJTlHdMDhYJm7+Jf21cfYoOOPJ 8nZ4pgxXd9WUBYi6AVvtUTLBox4GxIqqGibOmYHv9JO2XqX9+gqyxePj3sijD0zIxhaZ ws2FJ/cB2+a+oYGgoO9sQegdBHwH+yL3a4g4m9jZQpy6f+1uzokU8eXMCj3ygTHTiz/N f/+n+i8qNU76vFdEypasdcinnaaq1JxMmovjMrfQVBzVFLerzNcEtIkYo93h7dLi6trs XFow== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:organization:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:references :in-reply-to:message-id:date:subject:cc:to:from:dkim-signature; bh=0HABPjzaUI30YvO9YhN0YDZbguzPXre/bj51mVz935s=; fh=UEiBO2CAnI+gyxEAWi8+aZh/T6OoDRaJ2zsCisk/SfE=; b=BA0yqNZYXwMdn6rFxtlDqkSCMf7tXIw3lXNpuTFdlYR3NUIProHYfJhI9OXOldU6D2 as3uhlinFTNX3vB6LJP2Jh8AOjA0t2enIcjvQKcengrmtUu+AUxGjmRF0QhHB38W2zUJ k95Eql9rVdL3xTSVjjo6NJblCCTrcNNykzQUX2ReUEWxHn/hLJH3gjvrb9aljMegIZNq mytpc9ABqsx8PKOmM1ERgxeC1KgRP96adLBa/sb7cp4uu5R+ENi4WRSP1+nojcukG5Sp eeqru7ECMQ0IQR04gr8pk+CBwOv2wW6GlNJX68NTzhwtjP0kSCWKig51Nl44/FrqEcm5 oXpg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=Uzltr2QI; arc=pass (i=1 spf=pass spfdomain=intel.com dkim=pass dkdomain=intel.com dmarc=pass fromdomain=intel.com); spf=pass (google.com: domain of linux-wireless+bounces-3224-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-wireless+bounces-3224-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com X-Forwarded-Encrypted: i=1; AJvYcCWM8HSDf1R/bBChCxLPmopknnzGgMPuvG9saE7S1pcAZtsLaQcoGlief8tKKv9axQm5kphSdlxtJkN7otWiHLds+TZeMoDTlHX3THVPtA== Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id i14-20020a63130e000000b005dbd0facb51si1751302pgl.267.2024.02.06.06.56.33 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Feb 2024 06:56:33 -0800 (PST) Received-SPF: pass (google.com: domain of linux-wireless+bounces-3224-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=Uzltr2QI; arc=pass (i=1 spf=pass spfdomain=intel.com dkim=pass dkdomain=intel.com dmarc=pass fromdomain=intel.com); spf=pass (google.com: domain of linux-wireless+bounces-3224-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-wireless+bounces-3224-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 15FBE285894 for ; Tue, 6 Feb 2024 14:56:05 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 7C4AA133985; Tue, 6 Feb 2024 14:54:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="Uzltr2QI" X-Original-To: linux-wireless@vger.kernel.org Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.14]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 89FD812FF7C for ; Tue, 6 Feb 2024 14:54:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.14 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707231271; cv=none; b=PlpON+EYovonjb7YGzDA1TDc0yJtI0usg1T+4fo7LD3B5228yDNq5yL40QBEeqlZ7EeTeOcVeib/w6LmsCXe5xPOddWaxHJJ6QU7kyMLx3XFFWQ+F5iDun0T1u41JKd48ubcRLKig+E2TWYtxyB3EoprvCzFHSJvqoShGwZYH/I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707231271; c=relaxed/simple; bh=nBl41JxENQJfGp9n30Fw1Axl5NlHvCX5DRAMj+8gtD8=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=DhVzDhILKGhM+rrXblPIWBP7E6ARcXBiNq61X7jzGJNFxmAtgCvJFHch3B5G+ZoBCLekLOYbcQD6N64Cs52NmGbOlCewHRjsv0rtJABqKIlxys+XobCMJ2913kSWoPupsU8P4bypiUgb3M4F6SnzUR1vdW5nK8cU9KOAJd7PYGg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=Uzltr2QI; arc=none smtp.client-ip=192.198.163.14 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1707231270; x=1738767270; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=nBl41JxENQJfGp9n30Fw1Axl5NlHvCX5DRAMj+8gtD8=; b=Uzltr2QIX8Q0vpSNOvEOpvRckhBo+QbBYtCHbheMlxdf5s5Jagpl1VLq uRxPmtkqQG3E5EwHCZE9Ol9lIqIr/S3PBzGUQiRlCSpDhFU7PK8QzTakc hiiCo4dbJsOSmWN0z9UB7DQ5NZOOJ5cQtkFk4mI/4mT55ZZYJsziqnVXV /MB3o4Nztj1pIq6AItAES4sPa1FtSkEWJxrI/hntUVtFBcuQ1XJe8F7YR HYRKkU1E3cwbHHtqzUkGyAggx4mWJ+25i/y7YpoF2s2HDqT/8S2jBXQFM SSNHDCOhfJhFc+iC+VgDwqys5AoYkmRSYIV1Iqo6teeN5W818X2EzLlfU g==; X-IronPort-AV: E=McAfee;i="6600,9927,10975"; a="917791" X-IronPort-AV: E=Sophos;i="6.05,247,1701158400"; d="scan'208";a="917791" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmvoesa108.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Feb 2024 06:54:29 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10975"; a="824197914" X-IronPort-AV: E=Sophos;i="6.05,247,1701158400"; d="scan'208";a="824197914" Received: from unknown (HELO WEIS0040.iil.intel.com) ([10.12.217.108]) by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Feb 2024 06:54:27 -0800 From: Miri Korenblit To: johannes@sipsolutions.net Cc: linux-wireless@vger.kernel.org, Daniel Amosi Subject: [PATCH 2/8] wifi: mac80211: remove unnecessary chanreq compat check Date: Tue, 6 Feb 2024 16:54:05 +0200 Message-Id: <20240206164849.388898af2e66.I5b0c802f5164e94bff661900177956d6954f9a2d@changeid> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240206145411.3217588-1-miriam.rachel.korenblit@intel.com> References: <20240206145411.3217588-1-miriam.rachel.korenblit@intel.com> Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Organization: Intel Israel (74) Limited Content-Transfer-Encoding: 8bit From: Daniel Amosi This conditions can never be true, because if it was true (either before or inside the loop) the code is already checking this. Signed-off-by: Daniel Amosi Signed-off-by: Miri Korenblit --- net/mac80211/chan.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/net/mac80211/chan.c b/net/mac80211/chan.c index ef4c2cebc080..f7ddfa329258 100644 --- a/net/mac80211/chan.c +++ b/net/mac80211/chan.c @@ -829,9 +829,6 @@ void ieee80211_recalc_chanctx_chantype(struct ieee80211_local *local, } rcu_read_unlock(); - if (!compat) - return; - ieee80211_change_chanctx(local, ctx, ctx, compat); } -- 2.34.1