Received: by 2002:a05:7412:bbc7:b0:fc:a2b0:25d7 with SMTP id kh7csp3208972rdb; Tue, 6 Feb 2024 10:08:11 -0800 (PST) X-Google-Smtp-Source: AGHT+IGO93PYUG3BDW9cCeUS+LGlnoioGn8a8nACSSdN4/D/lm/atlwbMg7NMxTKbPSrqUJtwg1r X-Received: by 2002:a17:902:b288:b0:1d8:d1f5:e7a with SMTP id u8-20020a170902b28800b001d8d1f50e7amr2340252plr.52.1707242891558; Tue, 06 Feb 2024 10:08:11 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707242891; cv=pass; d=google.com; s=arc-20160816; b=PjBqXv2R705KafsBEqiCb1jLfVHmRxXoCgQF/wSnvoC8bo+2R6g8lH4CNoFuWLlwaB cWUvSmdhrLDSnlzpgHX+xKe2r5hWOqkycnLnl7X1m2XwgvMwRUSGP420Lq/zy6GANtbv Tf7cWO3dhu/B+qCwcFl9ArgbNwLODCsdlV0Sl3psZ/kUfElHlgTiaKyOug89Xs/iqdDZ MaeRoJTS1wrTDdUEgiX1Kb21oMEPKrSlwHYTOJNhhv0S9bdIu+vq6aMJvIbIqhvdTJR7 TJc6zI+KEt6R9pSxxpwqCIERMxhFc2eoSgzKe2060oi2qLRZUyvw8u3o3YKsQ4CEYzim OW1w== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=date:message-id:user-agent:cc:to:references:in-reply-to:from :subject:content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:dkim-signature; bh=Fm06Ao/i0OTQeZ38CkFlfIAxel07LZ/AZ3iBvmxjJaQ=; fh=D5sodPzk1JgsD9CxUpWmMtOu21Lezwu3iiWLGceRl8s=; b=MWVU2exFcsBk/YNs6izmnGN9K4E/hmka6qQ5laLw3+fKyrK4R12Vfigf6kTNw5J1Mt vsYeO9IewelZ1PYDTgJcuJBscwZI2FsykdJf/fgrRn+J8i/b4PEf1Z0Q5rozIa3j4KdD URLhzLNPkh4gIalrf5xuDn3LRXU1xf3kTya8NKb8dS9ko2X2weSNRFe/h1TF0GxHzPJm e9zD17DDwz36H9FVqV41YnxD/n+lvi3lYLh1uH2BCZjxtPUY0kQsmRMZDNg3m7qIekZ7 5NHfvw4s7cNYrIfVN32xCUftxVy+qHYhJw+yIKn0YQ0fxddZg4LebPwhFvnx6+y1R2n5 uxpw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="b/ynmLG+"; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-wireless+bounces-3251-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-wireless+bounces-3251-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org X-Forwarded-Encrypted: i=1; AJvYcCUS8g24hq/Z+PyU4ArQZu9o++CyAYQwdddA/yxG6/NNvz3xUgEcRwk3WN9IT/DTOlLJSi3iVUHfdd3GgT4hqUMx6bUd7yz8/MRFHxAMvw== Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id d21-20020a170903209500b001d70b8d77b9si1965695plc.307.2024.02.06.10.08.11 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Feb 2024 10:08:11 -0800 (PST) Received-SPF: pass (google.com: domain of linux-wireless+bounces-3251-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="b/ynmLG+"; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-wireless+bounces-3251-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-wireless+bounces-3251-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 3900E28A86B for ; Tue, 6 Feb 2024 18:08:11 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id CE31C13FE5; Tue, 6 Feb 2024 18:08:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="b/ynmLG+" X-Original-To: linux-wireless@vger.kernel.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AB13413FE2 for ; Tue, 6 Feb 2024 18:08:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707242889; cv=none; b=OHoe1QtEisOP1/b0xlriVCXoybw6nt3y8PHwEcfiHHiNsd/nZaMa5YFOGanpcqLriIx7ZAzFvA0hQRBLhaMYAP1IEvhCeZ+m162Z+fPz6K+4cXt4f9UwaTfqk1xv5MWiePloE17flPAags4t8nUff09q28z1AYxFPbkg9fRcYck= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707242889; c=relaxed/simple; bh=vhcVBMZ4ckx0a36MeZ4piTJM24iC7PFwjhZJh0U0wlU=; h=Content-Type:MIME-Version:Subject:From:In-Reply-To:References:To: Cc:Message-ID:Date; b=fobtZDBXB7hC7oqAQLrpcz+Oi3fuVsDn5lXgCRsC4lHdV7LXHNpSOqwqdYLqGDdvIdppmxX/f7HvSRzHzlyjvqhz9+lubBOTQY0M29om/mBhSntjwKwjO3pDYXbcvdeYFyd+a/HA4YS7eLlQ0V3fpa5ENa52C7qxe+4hdrP2oNU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=b/ynmLG+; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id E5E57C433F1; Tue, 6 Feb 2024 18:08:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1707242889; bh=vhcVBMZ4ckx0a36MeZ4piTJM24iC7PFwjhZJh0U0wlU=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=b/ynmLG+nys+rQGGN3A6p/Xu07rywIEtgERbRPdXa9wry4iv8ZXb5MmdBROT1vUlN KcGGN61m7yRxK0KgwCg3fxCwd5HUxzYK449Fg1x+Okl4GWGQHqFplug493XH3rxJUb MH5c6bbJl1tLYHFH60kJTFbCIBjenlzf9Z81GYGCNo6uPgNG/umL/Rgd9CUaEq7onP kZXeqY6EmF7ikUVYZpe34LI2CrHqmVIVhArc4bQn++jyaICF7xarWpPv2xRKJLt5VS TxIuDm85Oiig90pUmRGiLokgYX0guZY790gT43q1CkA2BZX0wLav4cro6CYoi2/avI 4w2V4visO+Jsw== Content-Type: text/plain; charset="utf-8" Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH v3] wifi: rtl8xxxu: update rate mask per sta From: Kalle Valo In-Reply-To: <20240205093040.1941140-1-martin.kaistra@linutronix.de> References: <20240205093040.1941140-1-martin.kaistra@linutronix.de> To: Martin Kaistra Cc: linux-wireless@vger.kernel.org, Jes Sorensen , Ping-Ke Shih , Bitterblue Smith , Sebastian Andrzej Siewior User-Agent: pwcli/0.1.1-git (https://github.com/kvalo/pwcli/) Python/3.11.2 Message-ID: <170724288621.1979906.8357092372743137291.kvalo@kernel.org> Date: Tue, 6 Feb 2024 18:08:07 +0000 (UTC) Martin Kaistra wrote: > Until now, rtl8xxxu_watchdog_callback() only fetches RSSI and updates > the rate mask in station mode. This means, in AP mode only the default > rate mask is used. > > In order to have the rate mask reflect the actual connection quality, > extend rtl8xxxu_watchdog_callback() to iterate over every sta. Like in > the rtw88 driver, add a function to collect all currently present stas > and then iterate over a list of copies to ensure no RCU lock problems > for register access via USB. Remove the existing RCU lock in > rtl8xxxu_refresh_rate_mask(). > > Since the currently used ieee80211_ave_rssi() is only for 'vif', add > driver-level tracking of RSSI per sta. > > Signed-off-by: Martin Kaistra > Reviewed-by: Ping-Ke Shih Patch applied to wireless-next.git, thanks. 94dd7ce1885e wifi: rtl8xxxu: update rate mask per sta -- https://patchwork.kernel.org/project/linux-wireless/patch/20240205093040.1941140-1-martin.kaistra@linutronix.de/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches