Received-SPF: pass (google.com: domain of linux-wireless+bounces-3266-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <706d5fde96f90078f80c7fb4fc88503d1791426f.camel@egauge.net>
Subject: Re: [PATCH] [v4] wifi: wilc1000: validate chip id during bus probe
From: David Mosberger-Tang <davidm@egauge.net>
To: Alexis =?ISO-8859-1?Q?Lothor=E9?= <alexis.lothore@bootlin.com>, 
	linux-wireless@vger.kernel.org
Cc: Ajay.Kathat@microchip.com, kvalo@kernel.org
Date: Tue, 06 Feb 2024 21:52:42 -0700
In-Reply-To: <415a0e6e-5824-44a2-af2a-a75115d5a62e@bootlin.com>
References: <20240127004331.1334804-1-davidm@egauge.net>
	 <415a0e6e-5824-44a2-af2a-a75115d5a62e@bootlin.com>
Organization: eGauge Systems LLC
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.44.4-0ubuntu2 
Precedence: bulk
MIME-Version: 1.0

On Tue, 2024-01-30 at 10:06 +0100, Alexis Lothor=C3=A9 wrote:
> On 1/27/24 01:43, David Mosberger-Tang wrote:
>=20
>=20
> > @@ -1142,7 +1170,7 @@ static int wilc_spi_init(struct wilc *wilc, bool =
resume)
> >  	}
> >  	if (ret) {
> >  		dev_err(&spi->dev, "Failed with CRC7 on and off.\n");
> > -		return ret;
> > +		return -ENODEV;
>=20
> You are still rewriting error codes here. At a lower level, sure, but sti=
ll...
> When I suggested setting -ENODEV at lower level, I was thinking about pla=
ces
> where no explicit error code was already in use, but
> spi_internal_read/spi_internal_write already generate proper error codes.=
 Or am
> I missing a constraint, like the probe chain really needing -ENODEV ?

Lower-level errors are often not meaningful at the higher level.  For
example, attempting to read a register over SPI may cause a CRC error
if the device doesn't exist.  That would result in -EINVAL, even though
there was nothing invalid about the read, it's just that the device
wasn't there.

But I don't feel strongly about it.  v5 of the patch does what you
want.

  --david