Received-SPF: pass (google.com: domain of linux-wireless+bounces-3267-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <3a11bcc8deabbf06cf344cd8709f11b114cb801d.camel@egauge.net>
Subject: Re: [PATCH] [v4] wifi: wilc1000: validate chip id during bus probe
From: David Mosberger-Tang <davidm@egauge.net>
To: Ajay.Kathat@microchip.com, alexis.lothore@bootlin.com, 
	linux-wireless@vger.kernel.org
Cc: kvalo@kernel.org
Date: Tue, 06 Feb 2024 21:53:52 -0700
In-Reply-To: <e33b2e57-729e-45ac-b14b-bde58313bfb0@microchip.com>
References: <20240127004331.1334804-1-davidm@egauge.net>
	 <415a0e6e-5824-44a2-af2a-a75115d5a62e@bootlin.com>
	 <e33b2e57-729e-45ac-b14b-bde58313bfb0@microchip.com>
Organization: eGauge Systems LLC
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.44.4-0ubuntu2 
Precedence: bulk
MIME-Version: 1.0

On Thu, 2024-02-01 at 02:55 +0000, Ajay.Kathat@microchip.com wrote:
>=20
> However, in the patch, please take care of disabling 'wilc->rtc_clk' in
> wilc_bus_probe() for the failure condition.
>=20
> static int wilc_bus_probe(struct spi_device *spi) {
> ...
> +power_down:
> +       clk_disable_unprepare(wilc->rtc_clk);
> +       wilc_wlan_power(wilc, false);
>  netdev_cleanup:
>         wilc_netdev_cleanup(wilc);

Good catch - I fixed that in v5.

> I hope this patch is tested for failure scenario(when WILC1000 SPI
> device is not connected) as well.

Yep.

  --david