Received-SPF: pass (google.com: domain of linux-wireless+bounces-3274-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
From: Bert Karwatzki <spasswolf@web.de>
To: Lorenzo Bianconi <lorenzo@kernel.org>,
	Felix Fietkau <nbd@nbd.name>,
	Ryder Lee <ryder.lee@mediatek.com>
Cc: Bert Karwatzki <spasswolf@web.de>,
	linux-kernel@vger.kernel.org,
	linux-wireless@vger.kernel.org,
	Johannes Berg <johannes.berg@intel.com>
Subject: [PATCH] wifi: mt76: inititalize sband.band to correct value
Date: Wed,  7 Feb 2024 08:22:53 +0100
Message-Id: <20240207072253.4189-1-spasswolf@web.de>
In-Reply-To: 87zfwchlmt.fsf@kernel.org
References: 
Precedence: bulk
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
UI-OutboundReport: notjunk:1;M01:P0:ip9NZo/uNy8=;Rr8/t2RtVQbDMiM9lplEP+nfbcK
 hHNqbivl6jERX3ZYkFswDw2fp5Xo16fb9hOf6X87ETsFG//p7Dq8fQ2VLNBAx9H7gTdp0ICjN
 hDH2O3nxSzCUE1DMXiyDvPBrC4lsmBx7/XiYaLJ8/EBPQPvp9TIUzP0TYPDDu1UglRFDONRtD
 3qPG6iQhSG7g9MLd6cEVPHfh7635h0/guBDh/P01Afdjn/V+qSqIGJvrz163ZWQ2UhGIZNDLd
 RA7k16ulyPYlwnYpxemnr+MaqxtFj25SRtcsVRpZFykVM8y+WLfJDwc5EcoiZwK/udFXX8gcS
 CdA8H+Rp5jTSO+sg3zGu10AKDUzGiL04aT/964hK8GeWlJluAqG4N1uUDT9CjseUyJk75Ewt1
 L2xn2wB2wmGOzAtsi1F3g/CtWA+OshVlrr0b7pzYDjk50HNF48Yc8t1ptxh9unKEO8T89NG9G
 gixlC36Zv06eJXbMSLbX0xuoD/ZwLT1wpvJBzwAp/igCu3LEIWmDjY7ZJu20XljzMi0GIRJtB
 GXTnZn5P6QEntlB0fGZTc6H5FW5zQRQ+YKfRWIY3Eh96Ex9Ou3FCgGiaJXbEfZDhHkzqtuuB+
 MA3sVWpNVQQNZNqNW24WzQJSUZ0Xa+ctU7/y7KQgDiQArwuzMRnMiNG0vViSfnuKEByMRTFJO
 7GAM7on9487jZ36UVhdQnq/s8moGUkvph+1tsmiwonPPC6TMOu5skTirHynQcAGKDitnyXRmE
 JA85oMSAlDe6vPXwWx7JYkamQoiQcV0I/Wo3eaiEDiDDZyn1fGhVHtO9Obv+B6Ick8sx+/+9I
 NTX++/782cZuMhAktKOisXXzXw0+JLEeVezW6rXcZCBv4=

Set phy->sband_{2,5,6}g.sband.band to the correct enum value, otherwise
the ieee80211_register_hw() will fail to register the device.

Closes: https://bugzilla.kernel.org/show_bug.cgi?id=3D218466

Signed-off-by: Bert Karwatzki <spasswolf@web.de>
=2D--
 drivers/net/wireless/mediatek/mt76/mac80211.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/net/wireless/mediatek/mt76/mac80211.c b/drivers/net/w=
ireless/mediatek/mt76/mac80211.c
index 8a3a90d1bfac..6cf08446f445 100644
=2D-- a/drivers/net/wireless/mediatek/mt76/mac80211.c
+++ b/drivers/net/wireless/mediatek/mt76/mac80211.c
@@ -363,6 +363,7 @@ mt76_init_sband_2g(struct mt76_phy *phy, struct ieee80=
211_rate *rates,
 		   int n_rates)
 {
 	phy->hw->wiphy->bands[NL80211_BAND_2GHZ] =3D &phy->sband_2g.sband;
+	phy->sband_2g.sband.band =3D NL80211_BAND_2GHZ;

 	return mt76_init_sband(phy, &phy->sband_2g, mt76_channels_2ghz,
 			       ARRAY_SIZE(mt76_channels_2ghz), rates,
@@ -374,6 +375,7 @@ mt76_init_sband_5g(struct mt76_phy *phy, struct ieee80=
211_rate *rates,
 		   int n_rates, bool vht)
 {
 	phy->hw->wiphy->bands[NL80211_BAND_5GHZ] =3D &phy->sband_5g.sband;
+	phy->sband_5g.sband.band =3D NL80211_BAND_5GHZ;

 	return mt76_init_sband(phy, &phy->sband_5g, mt76_channels_5ghz,
 			       ARRAY_SIZE(mt76_channels_5ghz), rates,
@@ -385,6 +387,7 @@ mt76_init_sband_6g(struct mt76_phy *phy, struct ieee80=
211_rate *rates,
 		   int n_rates)
 {
 	phy->hw->wiphy->bands[NL80211_BAND_6GHZ] =3D &phy->sband_6g.sband;
+	phy->sband_6g.sband.band =3D NL80211_BAND_6GHZ;

 	return mt76_init_sband(phy, &phy->sband_6g, mt76_channels_6ghz,
 			       ARRAY_SIZE(mt76_channels_6ghz), rates,
=2D-
2.39.2

It's "Fixes" for commits and "Closes" for bugs, ain't it?

Bert Karwatzki