Received-SPF: pass (google.com: domain of linux-wireless+bounces-3339-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <4e3b72023f30d8765154805816e6eb1f4e73593c.camel@sipsolutions.net>
Subject: Re: [PATCH] wifi: brcmfmac: do not cast hidden SSID attribute value
 to boolean
From: Johannes Berg <johannes@sipsolutions.net>
To: Arend van Spriel <arend.vanspriel@broadcom.com>, Alexey Berezhok
	 <a@bayrepo.ru>, Arend van Spriel <aspriel@gmail.com>
Cc: Kalle Valo <kvalo@kernel.org>, linux-wireless@vger.kernel.org, 
	lvc-project@linuxtesting.org
Date: Thu, 08 Feb 2024 15:15:22 +0100
In-Reply-To: <1bc49c2a-1f62-4801-90c3-048b27f6475c@broadcom.com>
References: <20240208085121.2430-1-a@bayrepo.ru>
	 <1bc49c2a-1f62-4801-90c3-048b27f6475c@broadcom.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.50.3 (3.50.3-1.fc39) 
Precedence: bulk
MIME-Version: 1.0

On Thu, 2024-02-08 at 15:06 +0100, Arend van Spriel wrote:
>=20
> settings->hidden_ssid has already been used above in following call:
>=20
> 		err =3D brcmf_fil_iovar_int_set(ifp, "closednet",
> 					      settings->hidden_ssid);
>=20
> So we pass the value as is to firmware using the same assumption, ie.=20
> NL80211_HIDDEN_SSID_NOT_IN_USE. Is this not ABI thus very unlikely to=20
> change?

The ABI won't change, that'd break all the users of nl80211 that use
this :-)

> @Johannes:
> Actually not quite understanding the reason for having this setting in=
=20
> nl80211. hidden_ssid means SSID element length is zero, right?
>=20

Well, there at least _were_ APs doing the correct SSID length but
setting all octets to zero ... Not sure that's still a thing though.

johannes