Received-SPF: pass (google.com: domain of linux-wireless+bounces-3408-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <c79e3164-4b43-49f4-bf02-98fda35a6716@quicinc.com>
Date: Fri, 9 Feb 2024 11:01:45 -0800
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2 2/2] wifi: ath11k: Remove scan_flags union from struct
 scan_req_params
Content-Language: en-US
To: Nicolas Escande <nico.escande@gmail.com>, <ath11k@lists.infradead.org>
CC: <linux-wireless@vger.kernel.org>
References: <20240209113536.266822-1-nico.escande@gmail.com>
 <20240209113536.266822-3-nico.escande@gmail.com>
From: Jeff Johnson <quic_jjohnson@quicinc.com>
In-Reply-To: <20240209113536.266822-3-nico.escande@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit

On 2/9/2024 3:35 AM, Nicolas Escande wrote:
> Now that we do not use scan_flags directly with WMI_SCAN_XXX macros anymore but
> only the bitfield scan_f_xxx, lets remove the scan_flags & the underlying union.
> 
> This will prevent further problems as some entries in the scan_f_xxx bitfield
> don't match their corresponding WMI_SCAN_XXX flags as seen in [1]
> 
> [1] https://lore.kernel.org/all/20231127180559.1696041-1-nico.escande@gmail.com/
> 
> Signed-off-by: Nicolas Escande <nico.escande@gmail.com>
Acked-by: Jeff Johnson <quic_jjohnson@quicinc.com>