Received: by 2002:a05:7412:3b8b:b0:fc:a2b0:25d7 with SMTP id nd11csp2098122rdb; Sun, 11 Feb 2024 11:08:33 -0800 (PST) X-Google-Smtp-Source: AGHT+IG2xoLfGLZ8Lg1ZIo/PTcTVPmIW+pkTKEL+n0DstpJqD/N5+UeDnf8pOstQ0e+a0lsD4cPs X-Received: by 2002:aa7:d7d4:0:b0:55f:e574:4ea6 with SMTP id e20-20020aa7d7d4000000b0055fe5744ea6mr3744507eds.2.1707678513624; Sun, 11 Feb 2024 11:08:33 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707678513; cv=pass; d=google.com; s=arc-20160816; b=yb3cZ9h9RQLu8zg7Tfa/vtd9nxAWYW2qyXSkrEqZRsUv++i1xdMzhESOvdSPeiHZ+m tXg7+pN+6/8CNRA44cRHChqpAQ3TMzHFNCxXvFTYcCsuyaOGQ6wwKkMUBTDxusxzkony 0IbQeJ8EKzrMtOqZ8ycC52MbF9MmddCkrkqxf7fw3VjJ6g9F3J8Caxwj5KLdrFH6756P Mmg4/75ivmNn0I2l+iN8w7EITnAl0dIk0TyadwEEAOPndEpeGMaKNPKsjXUnMWuE3/bm edjcB4s95i3/NKVmRJa3h8vZvZTMfO/Tifwh48jg4oDFb6Run4YvDCpORmMerLSsiZsT NFww== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:list-unsubscribe:list-subscribe:list-id:precedence :user-agent:content-transfer-encoding:references:in-reply-to:date:cc :to:from:subject:message-id:dkim-signature; bh=wz64LrnBBtsua+pXR5kwULmT8pSz2Bfo13R/BBLSuGQ=; fh=17Ek2M6bfNL50RmVXd1aBXa+B/XeTUHocPz8J6/DeQ0=; b=K1ua8sKc0zVscf5cgADf3BfNiISxsQyTg106DLhiUcQwsem6koKwdcmoSIvwjWEhA0 wuBj17IyCipj8V5wsEcsxCjKwH1/cWpENXLa7Itv/R0Pl8K9XnYMbfvz2n2ItzPrv53l Z/lL6T0BhgDHw0blt8DAE8EwKoK/JVM6Zc5q7antPFKj/rWVL0fFCtERncAL8JKYwg4S a6ZkUtOaZ4v2rEOeabNwJ3LuS3oCXtlfjIc9LCkMt+QESdjI5+hGJ1GX7OscvJQUlYxe naBT8Pus8VfUQ+QLS0GqmGFM27OKmTR67Igvj6sSARukhRllfHD4KeHTrxbpyXL5aa/B hd9A==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@sipsolutions.net header.s=mail header.b=RfZzNTLL; arc=pass (i=1 spf=pass spfdomain=sipsolutions.net dkim=pass dkdomain=sipsolutions.net dmarc=pass fromdomain=sipsolutions.net); spf=pass (google.com: domain of linux-wireless+bounces-3423-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-wireless+bounces-3423-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=REJECT dis=NONE) header.from=sipsolutions.net X-Forwarded-Encrypted: i=2; AJvYcCXk7icliKXJEZoQqTUV3rpAwLM7/lsN51Tq5v96zuz1CNlwOzjJCisunVrmnAcTUY+pgxsTpGq1gMZKVCy+o+RCf5GkcVb0VaXzlbtcyQ== Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id cy7-20020a0564021c8700b005610b042be6si2007791edb.61.2024.02.11.11.08.33 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Feb 2024 11:08:33 -0800 (PST) Received-SPF: pass (google.com: domain of linux-wireless+bounces-3423-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@sipsolutions.net header.s=mail header.b=RfZzNTLL; arc=pass (i=1 spf=pass spfdomain=sipsolutions.net dkim=pass dkdomain=sipsolutions.net dmarc=pass fromdomain=sipsolutions.net); spf=pass (google.com: domain of linux-wireless+bounces-3423-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-wireless+bounces-3423-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=REJECT dis=NONE) header.from=sipsolutions.net Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 5F4E11F219A4 for ; Sun, 11 Feb 2024 19:08:33 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 853155D462; Sun, 11 Feb 2024 19:08:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=sipsolutions.net header.i=@sipsolutions.net header.b="RfZzNTLL" X-Original-To: linux-wireless@vger.kernel.org Received: from sipsolutions.net (s3.sipsolutions.net [168.119.38.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 07C9736113 for ; Sun, 11 Feb 2024 19:08:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=168.119.38.16 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707678509; cv=none; b=Hj+OLZg985DozzAwES31H8qyJe0ZcU2nSc8Tckm6UiKhU9H38+bcyxYevqLkRjdGP80TZ6iqOoAgjJ4vX7FicocDjkk58HkepnssvO+XgTAtjgBDl3NCKqcr7OWwJ4zcGCBHzhcOh4FY9uK0xjZcj+aMHcMoEpN9/6qbr28ZmDA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707678509; c=relaxed/simple; bh=c7u3/VlzKb6A2NKID47+3/eqQIv0/WYBG2nbxKYEesM=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=llS3qc4nj2QmnceoMQ372ihW8cS36XagfGbw+x9RErJIfRlgixULdOtf5RKLETzhgXpetmmhPGM748WzVmo15oVuOR2eli0UD9KtsohkyImvIS7RZYcU/jHln7K1jcF8bw3NQFKA/E/kTd3NgVQuIQY6wiIX7MbRI8TUMsXN8sk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=sipsolutions.net; spf=pass smtp.mailfrom=sipsolutions.net; dkim=pass (2048-bit key) header.d=sipsolutions.net header.i=@sipsolutions.net header.b=RfZzNTLL; arc=none smtp.client-ip=168.119.38.16 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=sipsolutions.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sipsolutions.net DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sipsolutions.net; s=mail; h=MIME-Version:Content-Transfer-Encoding: Content-Type:References:In-Reply-To:Date:Cc:To:From:Subject:Message-ID:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-To: Resent-Cc:Resent-Message-ID; bh=wz64LrnBBtsua+pXR5kwULmT8pSz2Bfo13R/BBLSuGQ=; t=1707678506; x=1708888106; b=RfZzNTLLi/fMHlfNZxFdCBx1LliuYrnkD6IUO+x1eLRYTQ6 M6yFJgQS7PQxsOva0M4+2WV6B9TnIUNUvt5kkLlYwRoWtBjkI2Sq9QdaH5rWxe0ZlQf16gL2cNoDP hOUbiTIsYPdKZ0DHdORxLS3bW3w5TUPl31fZ4cCDbzYshmsYVNErIU9F/otUwbv2JhcSOcBxWqGe5 j67FETddRYOzv5Knd8KS/hQBuXbg6SiWuQ/J1OuXG+nqI5Se3KkAC2hCjuYAqwophLs43udBdlbHM K68IHSIJ4CojSy1eRYoWiYyAqwvxD7yEHWwt47OMYN1k54+QrnueDw2H+kSS06OA==; Received: by sipsolutions.net with esmtpsa (TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.97) (envelope-from ) id 1rZFBY-00000004d4s-2LV2; Sun, 11 Feb 2024 20:08:16 +0100 Message-ID: <37d3b28692d113453dd91eb1fd10722921522e71.camel@sipsolutions.net> Subject: Re: [PATCH 1/1] wifi: nl80211: Add support for plumbing SAE groups to driver From: Johannes Berg To: Jeff Johnson , Vinayak Yadawad Cc: linux-wireless@vger.kernel.org, jithu.jance@broadcom.com Date: Sun, 11 Feb 2024 20:08:15 +0100 In-Reply-To: References: <309965e8ef4d220053ca7e6bd34393f892ea1bb8.1707486287.git.vinayak.yadawad@broadcom.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.50.3 (3.50.3-1.fc39) Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-malware-bazaar: not-scanned On Fri, 2024-02-09 at 17:01 -0800, Jeff Johnson wrote: >=20 > > + [NL80211_ATTR_SAE_DH_GROUPS] =3D { .type =3D NLA_NESTED }, >=20 > can/should this have a policy? not sure it can have a policy, so see > below... Yeah not really. Should it even be nested though? There's not a huge difference to just making it a binary with a bunch of u32 values, and then the max length can even encode (and make visible to userspace) the now hidden value of CFG80211_MAX_NUM_SAE_DH_GROUPS. johannes