Received: by 2002:a05:7412:3b8b:b0:fc:a2b0:25d7 with SMTP id nd11csp2308327rdb; Sun, 11 Feb 2024 23:27:53 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCUnVXX8qZlXsl5DFHyqCu1xXVJG3zRqQ6CeYiTAIvt60C+pvJbzjUFnbdQ/ZN6bOKVwJG07eNWqieAVzXhvd+r4EboDAxs/3sult0Lonw== X-Google-Smtp-Source: AGHT+IG65VAOTg5oQTlaRr6acZl8iAlxoT146nxUdARHZPbmxbe4Db/9ituZVm1XUQRLjk9K8io4 X-Received: by 2002:ac2:5465:0:b0:511:5f08:f147 with SMTP id e5-20020ac25465000000b005115f08f147mr3962561lfn.25.1707722873785; Sun, 11 Feb 2024 23:27:53 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707722873; cv=pass; d=google.com; s=arc-20160816; b=1KJs0s54Pc/HE0zzS8TxZsB+XqukEg5xta3byiR1SeeibEZbLn9M6it8feDUTVUAe1 RgNBssWgEJweSpKVmhTgM+JQ0WEQ7ZgKLFZ8ojeOHcxEYgvliHGlasIZwPUOWdfk52bq 84RRVNZzmgZH3YrDKaAnnAlAGILgONn2ep+tyT+dUH10/F1HHl74ZcmoL3S28UrS7ooC 2H+TNXFGw9dLq4SFPvlVpg9opx91h+3tychILBKGMRlUQJ+h/h2yi8s+LRYrm8U1fg86 xYD3zeNb6QCenFqC9YcdbDPapQccKsYWshJXqtFliXI0443jM9wgyaRKguWarB5pr6Ab r3zA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:list-unsubscribe:list-subscribe:list-id:precedence :user-agent:message-id:in-reply-to:date:references:subject:cc:to :from:dkim-signature; bh=vzOuMlBnvdfQeuK9WggrCIMQtVp82zQdFtI13QLBToM=; fh=cWndF1UxOLjIS5Zy95gXGJGnj5HGR6uLhFPauhQc/Rs=; b=nJGnO4Yfj5T23bp0lWEDkN6PTrsHAhWsK2E0BaDcCavm+c26jkIyvRT+HJh1TsxpOC 0ArxD82vzoOioAWGv4yc67CLFGVIe6M8SPJskX/q/tLnDjzaTRQJ1+vU83kGRmnRAk1M iUkzlTr3kUNRVWLGSA5UDT2puhp4KMAwrzVHUUw4KXphcuudLetlwVU+mHyyBExFxlnm 4Xth1mMpCxVHAds6H6UuaDBxw35x78cWP/X/b8YQdUZyQVrSOjA5bDyG1nvKSwizQTqe IDbhDFdj8GJwbxiXwAnlHunbpTpcMrblGiB1oNVrlj+hn9F+Jy0U7WGII55INR0V5Txl IBBA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=KopBSSTH; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-wireless+bounces-3432-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-wireless+bounces-3432-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org X-Forwarded-Encrypted: i=2; AJvYcCVA7gjpFNTAysqAV53MUtb0npR/gJ1//EViZ3bJYKNhq+2oPEqW2WlMtvL+UDv/8y0Zake6W8Wk4nkW/UtGuCk3COpwooo5m2D4pb2krQ== Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id qw27-20020a1709066a1b00b00a38180e4ad5si3814174ejc.1042.2024.02.11.23.27.53 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Feb 2024 23:27:53 -0800 (PST) Received-SPF: pass (google.com: domain of linux-wireless+bounces-3432-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=KopBSSTH; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-wireless+bounces-3432-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-wireless+bounces-3432-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 53B6E1F27F3E for ; Mon, 12 Feb 2024 07:27:53 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 6A1657468; Mon, 12 Feb 2024 07:27:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="KopBSSTH" X-Original-To: linux-wireless@vger.kernel.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3D2A17462; Mon, 12 Feb 2024 07:27:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707722866; cv=none; b=nnZeLS2EvUcE6tNgV1ul2rZKa+yi+VDPDhcp6gpI13PX5FXDLo6+ARKOMTNQZM7zXzJwSSAGBWW4OR92wA4wcz9FVTvStt3xPcfKov7+7cMckZE0VPvjNGlk9hk4834bUzqoDebaWcNWyur2MBoN8TOeUJXGySCd5ENUsaxfL+Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707722866; c=relaxed/simple; bh=3aMNHjlxc62FQVzZmnlMVcwgj0/VFMqeJ+TcZxLjSvg=; h=From:To:Cc:Subject:References:Date:In-Reply-To:Message-ID: MIME-Version:Content-Type; b=KCE92KVxTdOGTaaQXpDg7OavAZP+kKXH2v/MX+AzjwLM5no3rSjXFE/8BG2niawExchlYhqJDWi5/eFkRQEskxI1A/kv7FjXsy635uLvHHbeerIoj/r31c6wlZAyk3DqolxCkhbTICp50ykM+Cs4L3AzsfQ3ndzqZ0nzbetDRac= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=KopBSSTH; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7DA29C433C7; Mon, 12 Feb 2024 07:27:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1707722866; bh=3aMNHjlxc62FQVzZmnlMVcwgj0/VFMqeJ+TcZxLjSvg=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=KopBSSTHwl+GzzLjkSwYTO4SSaQrRYAiQlFhe89mRxjKAtD/795s06xVdAlyL1pP1 0w4j/4VWKKOFvUyBXFd5J2V2Yc1Yj0sVe8sHz/1hzS7SXTQakmxitPZvoNdjaC22fP LXMf+GV0xzPDCHElMqYeYdvzU7Y6Ts73zCG5POs1mNkeW9bYy80dOBkrmKlIIE6fqQ gVLZxzexqxljf3FpYT11IE4v13n3zF4uqFvFg8ot4fC7YlZ+5XAk9CIqOwLelc+VVB Xf7T/vaakDcexuUHR6QoxwgNRe5vqch3rlkMR49kiqI/TtWkFi3eog+ZHAH4zOu67Y 4I2dUEbqhnz5g== From: Kalle Valo To: Arend van Spriel Cc: Daniil Dulov , "David S. Miller" , Jakub Kicinski , Pieter-Paul Giesberts , "Franky (Zhenhui) Lin" , "John W. Linville" , Kan Yan , linux-wireless@vger.kernel.org, brcm80211-dev-list.pdl@broadcom.com, SHA-cyfmac-dev-list@infineon.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, lvc-project@linuxtesting.org Subject: Re: [PATCH] brcmfmac: Remove unnecessary NULL-check. References: <20240211150516.3475-1-d.dulov@aladdin.ru> <60a0a753-47ba-4f80-b93e-2878f214bc3c@broadcom.com> Date: Mon, 12 Feb 2024 09:27:41 +0200 In-Reply-To: <60a0a753-47ba-4f80-b93e-2878f214bc3c@broadcom.com> (Arend van Spriel's message of "Sun, 11 Feb 2024 20:25:21 +0100") Message-ID: <87il2uf8gi.fsf@kernel.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain Arend van Spriel writes: > On 2/11/2024 4:05 PM, Daniil Dulov wrote: >> In this case req will never be NULL, so remove unnecessary check. >> Found by Linux Verification Center (linuxtesting.org) with SVACE. > > Looks good to me, but when do we call things a "fix" and when is > "improvement" more appropriate. > >> Fixes: 71bb244ba2fd ("brcm80211: fmac: add USB support for bcm43235/6/8 chipsets") > Reviewed-by: Arend van Spriel Yeah, this is not a fix and the Fixes tag should be removed. -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches