Received-SPF: pass (google.com: domain of linux-wireless+bounces-3438-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <66bddf2f6362c9f39f06e06c0c35b6900917b9bf.camel@sipsolutions.net>
Subject: Re: [RFC] mac80211: add AQL support for broadcast packets
From: Johannes Berg <johannes@sipsolutions.net>
To: Felix Fietkau <nbd@nbd.name>, Toke
 =?ISO-8859-1?Q?H=F8iland-J=F8rgensen?= <toke@kernel.org>,
 linux-wireless@vger.kernel.org
Date: Mon, 12 Feb 2024 11:26:25 +0100
In-Reply-To: <960efcac-0995-4a42-b90c-3e66c0f56762@nbd.name>
References: <20240209184730.69589-1-nbd@nbd.name> <87plx4s71y.fsf@toke.dk>
	 <960efcac-0995-4a42-b90c-3e66c0f56762@nbd.name>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.50.3 (3.50.3-1.fc39) 
Precedence: bulk
MIME-Version: 1.0

On Sat, 2024-02-10 at 17:18 +0100, Felix Fietkau wrote:
>=20
> > > +++ b/include/net/cfg80211.h
> > > @@ -3385,6 +3385,7 @@ enum wiphy_params_flags {
> > >  /* The per TXQ device queue limit in airtime */
> > >  #define IEEE80211_DEFAULT_AQL_TXQ_LIMIT_L	5000
> > >  #define IEEE80211_DEFAULT_AQL_TXQ_LIMIT_H	12000
> > > +#define IEEE80211_DEFAULT_AQL_TXQ_LIMIT_BC	50000
> >=20
> > How did you arrive at the 50 ms figure for the limit on broadcast
> > traffic? Seems like quite a lot? Did you experiment with different
> > values?
>=20
> Whenever a client is connected and in powersave mode, all multicast=20
> packets are buffered and sent after the beacon. Because of that I=20
> decided to use half of a default beacon interval.

That makes some sense, I guess.

It does have me wondering though if we should also consider multicast
for airtime fairness in some way?

johannes