Received-SPF: pass (google.com: domain of linux-wireless+bounces-3439-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <35d4ae8f4c5157e3d0da39295a5b15eced367ab6.camel@sipsolutions.net>
Subject: Re: [PATCH v1 6/9] iwlwifi: mvm: Set THERMAL_TRIP_WRITABLE_TEMP
 directly
From: Johannes Berg <johannes@sipsolutions.net>
To: "Rafael J. Wysocki" <rafael@kernel.org>, Stanislaw Gruszka
	 <stanislaw.gruszka@linux.intel.com>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>, Linux PM
 <linux-pm@vger.kernel.org>,  Miri Korenblit
 <miriam.rachel.korenblit@intel.com>, Lukasz Luba <lukasz.luba@arm.com>,
 LKML <linux-kernel@vger.kernel.org>, Daniel Lezcano
 <daniel.lezcano@linaro.org>,  Srinivas Pandruvada
 <srinivas.pandruvada@linux.intel.com>, Zhang Rui <rui.zhang@intel.com>,
 netdev@vger.kernel.org, Ido Schimmel <idosch@nvidia.com>, Petr Machata
 <petrm@nvidia.com>, linux-wireless@vger.kernel.org,  Shawn Guo
 <shawnguo@kernel.org>, Sascha Hauer <s.hauer@pengutronix.de>, Pengutronix
 Kernel Team <kernel@pengutronix.de>, Manaf Meethalavalappu Pallikunhi
 <quic_manafm@quicinc.com>
Date: Mon, 12 Feb 2024 11:31:27 +0100
In-Reply-To: <CAJZ5v0gZ1tpNmdkvRLA6-ydnhKPKgsM_FCwrW+q1=5ZiD=vbWA@mail.gmail.com>
References: <3232442.5fSG56mABF@kreacher> <3757041.MHq7AAxBmi@kreacher>
	 <ZcY7jyyFJq1yfOCj@linux.intel.com>
	 <CAJZ5v0gZ1tpNmdkvRLA6-ydnhKPKgsM_FCwrW+q1=5ZiD=vbWA@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.50.3 (3.50.3-1.fc39) 
Precedence: bulk
MIME-Version: 1.0

On Fri, 2024-02-09 at 17:15 +0100, Rafael J. Wysocki wrote:
> > >       for (i =3D 0 ; i < IWL_MAX_DTS_TRIPS; i++) {
> > >               mvm->tz_device.trips[i].temperature =3D THERMAL_TEMP_IN=
VALID;
> > >               mvm->tz_device.trips[i].type =3D THERMAL_TRIP_PASSIVE;
> > > +             mvm->tz_device.trips[i].type =3D THERMAL_TRIP_WRITABLE_=
TEMP;
> >=20
> >                 mvm->tz_device.trips[i].flags =3D THERMAL_TRIP_WRITABLE=
_TEMP;
> >=20
> > Consider using diffrent prefix for constants to diffrenciate flags and =
types.
>=20
> Well, I can use THERMAL_TRIP_FLAG_RW_TEMP or similar, but is it really
> so confusing?
>=20
> I'm wondering what others think.
>=20

I'd tend to agree with Stanislaw. I did (eventually) notice the double
assignment to .type above, but had that not been visible in the context,
or you'd have removed the first one by accident, I'd really not have
thought about it twice.

The bug also makes it look like you even confused yourself ;-)

So having a clearer indication that it's a flag would make sense, I'd
say.

johannes