Received-SPF: pass (google.com: domain of linux-wireless+bounces-3457-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <25c51905aac00bde0591d169d00b301c608234c5.camel@sipsolutions.net>
Subject: Re: [PATCH 3/8] wifi: mac80211:  make associated BSS pointer
 visible to the driver
From: Johannes Berg <johannes@sipsolutions.net>
To: Miri Korenblit <miriam.rachel.korenblit@intel.com>
Cc: linux-wireless@vger.kernel.org
Date: Mon, 12 Feb 2024 14:45:24 +0100
In-Reply-To: <20240206164849.6fe9782b87b4.Ifbffef638f07ca7f5c2b27f40d2cf2942d21de0b@changeid>
References: <20240206145411.3217588-1-miriam.rachel.korenblit@intel.com>
	 <20240206164849.6fe9782b87b4.Ifbffef638f07ca7f5c2b27f40d2cf2942d21de0b@changeid>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.50.3 (3.50.3-1.fc39) 
Precedence: bulk
MIME-Version: 1.0

On Tue, 2024-02-06 at 16:54 +0200, Miri Korenblit wrote:
> Some drivers need the data in it, so move it to the link conf,
> which is exposed to the driver.

> + * @bss: the cfg80211 bss descriptor. Valid only for a station, and only
> + *	when associated.
>=20

For the record, I'm dropping this patch.

Yes, the data is there in the stack, but the cfg80211 BSS contains data
that is not authenticated (from probe responses etc.) whereas mac80211
is (hopefully always) operating on data that is authenticated with
beacon protection.

So exposing this to the driver feels fragile - if it actually gets used
for pretty much anything, it won't necessarily be authenticated data.

We were planning to use it for just the RSSI, which is probably fine,
but we can do that differently.

johannes