Received: by 2002:a05:7412:3b8b:b0:fc:a2b0:25d7 with SMTP id nd11csp2525324rdb; Mon, 12 Feb 2024 07:39:04 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCU8BiH7oRovsBrGEhNE3LYrRhltbiT+I+Fff7cRTiSASQGG91O3kku7hMAJFKyOHODL4VGnXaV0YhQo+d0UlKJhfZU9tqAwoy0E+bFa/Q== X-Google-Smtp-Source: AGHT+IG3qs0NyPohXxSxpIXP36yT1ZILY8G5sj8xzezR6hVot528y9zSJm/ucFU7PPHs4Euk6ynA X-Received: by 2002:a05:620a:84c:b0:783:f7ab:a6ac with SMTP id u12-20020a05620a084c00b00783f7aba6acmr7661859qku.40.1707752343872; Mon, 12 Feb 2024 07:39:03 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707752343; cv=pass; d=google.com; s=arc-20160816; b=ARXmkOmRhEYWFHR48ccZGMd4wyn0XiOwBSxyAD1w+95KItSK7ubFPEVkkB8e3S8IH0 XxnTAM2RYVbJM69hdcGXC//qQxc3d7L/BHc8cPsxC8c/RhnkMQlRVUxK9+Hes+keUXUt vnB0MYhQ+8f7G3kKCSGETVcx+cVGdl5X+TzdypB0cP9ECoiMYFrrsoGarjRma6gi9X8z ad6xT2G98yglUKfepeQVj1Vfc3dIZBjc+r9QMKIIW8DZnTx8+fY1rpF3WGv5oyTvWMAX 4ir3h5IEK6Pm/iSqk8FNSYH+jSz2XmWBo2ADlqOCz3KCJXhsSe2dKyUhD5Heo8Ehuiwo pcqg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=date:message-id:user-agent:cc:to:references:in-reply-to:from :subject:content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:dkim-signature; bh=7P1Qf2+ZjDtQNSnZDZPdnm0Pwz1gH/1bPK791vjBxK8=; fh=/yhAW8gVb5OYsEf1fIEzgZ7yIQ0IFvdP2sN4LCbp3Zc=; b=0c+MGFtYMA+cu9kijyXd1CNsmPiNgxAY7HNiHbT2QDK657yfAtMYTgWkgef7pWjPlY IgJPyzkZjioMZLtMmlz4PVFSFA0ZuLe1uNqIJhwkWi6hLkCnBrZzYryNVSaONeQHPRDk QWYv8bKHk4zXYV6qDkvIOmBkMqORGhRmXcATjQ+438kNjj6AxcT/yEZeV+i328u+RQGf +yYhGFkTiLhOpHX/7d6C0tKyDpeoWo2vIl0c8NcxKvWXKAo4dzgU+/1YR7j8R4sL+eTq PZTyht+61tk+JtiYLOj8RDcR4opCJZnJ2KqU1PL8ja2KokBJzNjSUYscbu/8gENJnfDw 3E4g==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Ioy+Xv8B; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-wireless+bounces-3466-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-wireless+bounces-3466-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org X-Forwarded-Encrypted: i=2; AJvYcCWzIQwIsdY+GKrOPyrvC/vmp3HbFGFfdmxjpybDY9XBJG2g8treJfWq/hf25+diRC0l2IlNCKEUJLHPoNaK0s82oN021WpQ6Fv3C7Zspw== Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id s16-20020a05620a081000b00783e6ffb9f0si6257641qks.653.2024.02.12.07.39.03 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Feb 2024 07:39:03 -0800 (PST) Received-SPF: pass (google.com: domain of linux-wireless+bounces-3466-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Ioy+Xv8B; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-wireless+bounces-3466-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-wireless+bounces-3466-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 9E4BF1C21707 for ; Mon, 12 Feb 2024 15:39:03 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 856D33C689; Mon, 12 Feb 2024 15:38:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Ioy+Xv8B" X-Original-To: linux-wireless@vger.kernel.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 61A0A3C684 for ; Mon, 12 Feb 2024 15:38:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707752339; cv=none; b=a0GWJrPJFY4BeN8Aj5ZdEAmivZItcjyOfiZHvXYaBJf1nLGolM0UnK0W8COsbxLpXr5ufRjQNATyJQglmL05ZeNu1RZl3KnSy+uL6rV/hyUju+rQ6CfUFPCo/M0AB6PhUrrH9KI1vQ/tP5nZySR2EDN0C/2F2qWFfRq2T5xYPRc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707752339; c=relaxed/simple; bh=ndLKKOOMqtN5vOXd9QLPhGAEsP4jQeOIdJyB8QETJtU=; h=Content-Type:MIME-Version:Subject:From:In-Reply-To:References:To: Cc:Message-ID:Date; b=nG7k8sewtlK80p8yWm+fYLOStyhpX1cfNfr66iWAs8geXugrOw+DP32+Sej7HLT4emcMilQL2QEdVMeauKTOoLF8+7eYW7DCUoO0KhgDSi9E0+HUrniAtjmOb0V1U8cbA5vkGz06gIPm5C3QfpavPgKqP0pbzpMbnnlGGAjtGkk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Ioy+Xv8B; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 12DAFC433C7; Mon, 12 Feb 2024 15:38:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1707752339; bh=ndLKKOOMqtN5vOXd9QLPhGAEsP4jQeOIdJyB8QETJtU=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=Ioy+Xv8BBVNCobErFTm9hZHCpqp8XFQDG5JNqUFkORwqxaH769F1h5f0NjEdzshcE WYaAx8mhH5/KsfsdP5+DWMGbjpq99czgoO5qZJE5iMDQtVtIEx/CH0UhfbbWLgH8o2 sm0wCUQvFn7XLREjWt9ZsS0F5cx3FENkylzV41IStcQ1Uh3U3KIuDtt9WzJB16Zplk xSaLgPPPHhY9wm2qShAwopFUs/DsAy+1r+OfJE7OCkfMhY3mabAT5m08yt+oPDzkFn /jXLb29tvT8J581cGKuYRjmKHICujWjdlQyEi2P2K1CH8PURuY2hT4pXNCMpRR2JvZ hXlfTzEI+U5kg== Content-Type: text/plain; charset="utf-8" Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH] wifi: brcmfmac: do not cast hidden SSID attribute value to boolean From: Kalle Valo In-Reply-To: <20240208085121.2430-1-a@bayrepo.ru> References: <20240208085121.2430-1-a@bayrepo.ru> To: Alexey Berezhok Cc: Arend van Spriel , linux-wireless@vger.kernel.org, lvc-project@linuxtesting.org, Alexey Berezhok User-Agent: pwcli/0.1.1-git (https://github.com/kvalo/pwcli/) Python/3.11.2 Message-ID: <170775233602.2851594.8173116143852900695.kvalo@kernel.org> Date: Mon, 12 Feb 2024 15:38:57 +0000 (UTC) Alexey Berezhok wrote: > In 'brcmf_cfg80211_start_ap()', not assume that > NL80211_HIDDEN_SSID_NOT_IN_USE is zero but prefer > an explicit check instead. Compile tested only. > > Found by Linux Verification Center (linuxtesting.org) with SVACE. > > Signed-off-by: Alexey Berezhok Patch applied to wireless-next.git, thanks. f20073f50dfd wifi: brcmfmac: do not cast hidden SSID attribute value to boolean -- https://patchwork.kernel.org/project/linux-wireless/patch/20240208085121.2430-1-a@bayrepo.ru/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches