Received: by 2002:a05:7412:3b8b:b0:fc:a2b0:25d7 with SMTP id nd11csp2529272rdb; Mon, 12 Feb 2024 07:46:36 -0800 (PST) X-Google-Smtp-Source: AGHT+IGY2dzgfSLqvCANjESxD1J7h1ND+Ly3Catsn47s2tdBTPwGw3mO1lX7zY97aagP/KUUMzrY X-Received: by 2002:a05:6a00:1b52:b0:6dd:e398:2a84 with SMTP id o18-20020a056a001b5200b006dde3982a84mr5775924pfv.7.1707752796372; Mon, 12 Feb 2024 07:46:36 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707752796; cv=pass; d=google.com; s=arc-20160816; b=LAGatIL9Nphaxmj+u1F4qOwtMooNif83tQN3mC/G7E0sL6crSzqVYYv9PV+tulAPa3 VbIM/AjilZcDdIctbViZGaKZ2g6sRC45no3Xm6GPPY/wcSCRaDVXIgIiBrWKVTcLyrqS JWLPJll8P+iSBE2c2QlcWg6uvc76Mj7xeEElCmaq/Upmv0cTiuNQBMjCH4a2GHJBjYPu 6kHrawQv9jIHPQAww4LPIBCY/MnXK18Vbea6veNM3Q/CQ8bDXklUeVRzxpNL2irI5Azj g9gSv0ARnXnbVtpIem8AILDcOOsGXR2F6jtpte40hV+9ioY1U+UTlwBXnkeuMO8+Ilay yxwg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=date:message-id:user-agent:cc:to:references:in-reply-to:from :subject:content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:dkim-signature; bh=QNdgYFiObdbLFBDuPpBrNQoeWo3epsA8pST9/cR3VBo=; fh=gD9ERr2Xar/58kASUeCcS0pfIhbQi0GKdNg6unEejY4=; b=T67YIMpgHeU+hyl8CmZiXMWCbB5p2ZUwCV7smXLuLKtQPet5xjK/u4L+w382nB6FZP 7zPulvT2vk0dZNwPYtytNkgvu8Z09DxD7wHMSuQJXIiadtxR3ZI8fCpPoEl2Qz+dXujs nGbsfOQKk0ETSKYsAkfXoB1g0GH/HBn8y97vsAugltQnss1/J8hJr+vGxtCPZfFP1OB4 SxtPd19peZlOZ5M8GPhXtgBBhFRWXWzx8O0LHG/cdCGtRDLAREhtJYgQHrpIednDKCdU XmE/dfMzZQaobBjwb/GIJUqtYsLmL1JUV0KeT3Ckb/n1yYTaAFrRpN/kydVEijQyOz1K 7tIw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=U++PPMw1; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-wireless+bounces-3464-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-wireless+bounces-3464-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org X-Forwarded-Encrypted: i=2; AJvYcCUknElrfhtxTOgaB6RasBAYcEkDUkr5bKeqes7idTprZo61gdBbFmqqtg1FAo9yvHLcu7jpAFg3ekFkAVmX6QNQuDkMxTZczP2SV6avBA== Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id ey7-20020a056a0038c700b006db1202a5acsi5031256pfb.233.2024.02.12.07.46.36 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Feb 2024 07:46:36 -0800 (PST) Received-SPF: pass (google.com: domain of linux-wireless+bounces-3464-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=U++PPMw1; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-wireless+bounces-3464-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-wireless+bounces-3464-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 1A73728643E for ; Mon, 12 Feb 2024 15:37:51 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 060D63C68E; Mon, 12 Feb 2024 15:37:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="U++PPMw1" X-Original-To: linux-wireless@vger.kernel.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D61573C68A for ; Mon, 12 Feb 2024 15:37:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707752268; cv=none; b=i7vnUysJIQBn2L9yCnJHKyxca+qOvBrAYn0OL6SV/a+ThVHgUTdRxCmnaml2N91Mgr5HN3EHi2VzIU0MH0eL44pkHXs3E7J1Y3Dh32QcQgu7h8UjYx7qzteCO+UIJYfABzmFGIyA1c8TVZB1KEglhnjppb0ejQLJP8i/PaxQxCg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707752268; c=relaxed/simple; bh=igfkJTvjRNdI54+qIvnhJ0gZeN0TQlPRGirAI5EtB9A=; h=Content-Type:MIME-Version:Subject:From:In-Reply-To:References:To: Cc:Message-ID:Date; b=Fs3QrfvPfllNs86lqczzyL/C8eKqTUsa3wm4nFwT6wP65GvuXumebakwAeEyNer5qDTXRPTEB+BA2I4N2oPTWQ2ERyr/rmUTn/KbdMT6nRh9Pf7NVJVbdeen9nHFR9PF4SZRzICrxUG7fRmeMP/8aha7XWCc+h7ijXROiHTR7SM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=U++PPMw1; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8B797C43390; Mon, 12 Feb 2024 15:37:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1707752268; bh=igfkJTvjRNdI54+qIvnhJ0gZeN0TQlPRGirAI5EtB9A=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=U++PPMw1AeNEBIdAJWoxMtXjhr5z7GLyN2ZRG6a1Rl1TtJKrJ2qRq8ZRLIpEOfgs6 HPYDvSd3DI5/xpKp/GkzStUT8rD9mqHXGa0s3Y10XFi5jeQv/fgkujv/9xE/A5zu3T GDw7zzAy+IPoEETn+WEoxt92xuOVA/CdqH4OG+jDP/wOekrD0kvBXD49hAoXekjeRH EyzE1OawLWd3J4rbCfY27xEj/k33+iIsQp2gbd03X7ZIv4W3HF+CJnns4+FevVC1Li GhrdYp9sS/VKF8O4HW/aAFRfRFiYVKc0xPVQSQQscd/KNWY5J0tyWcMnxurT1QsLn+ EIAayGN/bwP6w== Content-Type: text/plain; charset="utf-8" Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH] wifi: wilc1000: correct CRC7 calculation From: Kalle Valo In-Reply-To: <20240207050736.2717641-1-davidm@egauge.net> References: <20240207050736.2717641-1-davidm@egauge.net> To: David Mosberger-Tang Cc: linux-wireless@vger.kernel.org, Ajay.Kathat@microchip.com, alexis.lothore@bootlin.com, David Mosberger-Tang User-Agent: pwcli/0.1.1-git (https://github.com/kvalo/pwcli/) Python/3.11.2 Message-ID: <170775226580.2851594.14123930588067888872.kvalo@kernel.org> Date: Mon, 12 Feb 2024 15:37:47 +0000 (UTC) David Mosberger-Tang wrote: > Document > > ATWILC1000/ATWILC3000 > Baremetal Wi-Fi/BLE Link Controller Software Design Guide > > https://tinyurl.com/yer2xhyc > > says that bit 0 of the CRC7 code must always be a 1. > > I confirmed that today with a logic analyzer: setting bit 0 causes > wilc1000 to accept a command with CRC7 enabled, whereas clearing bit 0 > causes wilc1000 to reject the command with a CRC error. > > Signed-off-by: David Mosberger-Tang Patch applied to wireless-next.git, thanks. c08a986344a5 wifi: wilc1000: correct CRC7 calculation -- https://patchwork.kernel.org/project/linux-wireless/patch/20240207050736.2717641-1-davidm@egauge.net/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches