Received: by 2002:a05:7412:3b8b:b0:fc:a2b0:25d7 with SMTP id nd11csp2538970rdb; Mon, 12 Feb 2024 08:03:22 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCVbZUCDEmbQo+n3T54qxWNEJbJFvB4RRYRiNYvTZvmS5RMLmKNmnll/5PaFXPFDO6GxzhQs5pBecLTUD9eRG36NKZgpqhbUdBfVnGfD1Q== X-Google-Smtp-Source: AGHT+IE0TJ+BJeFdl8cRbpKzeR4uXpShuB5e6RDqIUey8m6iK14NizZ5mz75VKaSnCVY9M3n6sk3 X-Received: by 2002:a17:90a:a010:b0:296:2057:28c with SMTP id q16-20020a17090aa01000b002962057028cmr3720770pjp.31.1707753801796; Mon, 12 Feb 2024 08:03:21 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707753801; cv=pass; d=google.com; s=arc-20160816; b=tYHfd0f0opJgj6fhMlcVfEo6laHYL2dnb+01AFxswpwvVgncsk44T8VK3X5kbrhnr4 CrzDxEMjchCAV/SODSrNE4M1rBHxJW/BMydQIDjVBgwZqLgwj4qjumWgLCos6QViXQQy DWij3zTYKAHbVt4TmM6/zcXO8OHH0gHYB6lqrlB92o7xcivyndnYkIBxixItnRzU2You mbyL0ZS+EfePdAVG4Hir/Ph9DJUCcaau4D0VZ4CUsQqDMso8e5gauAMHdAAwgS24wP9e IU+jbvPHAIq6BTXfs7Gv2BeKTmcBJc9srm9vsdNbRbSCO+Wm7HXJcwovS6+kwowp+n+l k3nQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:list-unsubscribe:list-subscribe:list-id:precedence :user-agent:message-id:in-reply-to:date:references:subject:cc:to :from:dkim-signature; bh=btSTwIfG7ZNEk0L0VwSVAOMouC8QKdf6zaBHIvIZ+AQ=; fh=yNrUIxEQhYMXNrByQv40lSHhkmi/DzKVZvl6dx/0hx8=; b=FN9I0F6/62++NoXQAC+QWYQUt7a0QFCTtoZPtGuYjHgOJHuD4rkCGT7TEgXXVaU2vt 3q/Y/bR1ffSmDhCcAs+BGo+3Z1RsMdYn8iFirVJVpSiJCgRqaKs9FjFY2jO4TbKqal8r q0Fz9ZYAMUvhcLMH1M9Re2WoIuUN+MXcM5wRRXfMUZJdXAnD9uO514ALanW6v7ve5IvZ 7Ff76p0JnJphMfaSZ30Hvq3CnSobtpK6j6lO9gxjZg309KlhCcdjX9vF6fxHWEA3BUUE 4jjvqoTg/JXsmAd3kKb6TTlIJjAV3xQIVpuJVFH59q02aeScO95Rur4CSDZjnC/kjuf/ xKTA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=tq42PtKj; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-wireless+bounces-3469-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-wireless+bounces-3469-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org X-Forwarded-Encrypted: i=2; AJvYcCViKZGTHNlC21F38qXaP82yHhDlKc+185xKbeOmkIY1oV75Codd8ZHWX+1XsXCRNitrEG0frENMYk2g+cxb5eQI7YnTEmxOO6ASDqPuzw== Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [2604:1380:40f1:3f00::1]) by mx.google.com with ESMTPS id se15-20020a17090b518f00b00297156cc2ffsi452311pjb.177.2024.02.12.08.03.21 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Feb 2024 08:03:21 -0800 (PST) Received-SPF: pass (google.com: domain of linux-wireless+bounces-3469-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=tq42PtKj; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-wireless+bounces-3469-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-wireless+bounces-3469-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id A4673B2166B for ; Mon, 12 Feb 2024 16:03:19 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 47BF93CF7C; Mon, 12 Feb 2024 16:03:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="tq42PtKj" X-Original-To: linux-wireless@vger.kernel.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 227FD3CF79 for ; Mon, 12 Feb 2024 16:03:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707753794; cv=none; b=rX40Y5V9OQaJvkA2N9Hk2teLQg9eNaIUvxkXmihD+98Z3teE1iZClCo8C3LMSZlnlvyo0Uvh97IwGhDObeaeiJ2l4zsIVvTVz+HUqbLgO9YX5SdcDjmFLnBdTqMpW0S6yVRLE1TnhRGOXH6YSAb/W3/2ChOn2DwtsauNVurKsrc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707753794; c=relaxed/simple; bh=SMiqT3HZQCIrizVx7l8/yUdi09rf3NvXoSFSFjz6/rI=; h=From:To:Cc:Subject:References:Date:In-Reply-To:Message-ID: MIME-Version:Content-Type; b=OEVmHa6AtA8GN+nRLtB6zU6zJJWinNhzCh0f/BqPSVNFNGohab+Me8ucaof7h/Fp4dAnNCeHol+fQ7e4LLtv1hQPGevCcuiyIjmGl752W8mccy8cplefAPHg5Oyjw6ojs0MeQLeV/mtkcSqb8s+TjBWndf89xzUJtn60wQGfcEY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=tq42PtKj; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 695C2C433F1; Mon, 12 Feb 2024 16:03:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1707753793; bh=SMiqT3HZQCIrizVx7l8/yUdi09rf3NvXoSFSFjz6/rI=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=tq42PtKj1CWK2b13e+O22hLu6HV16YuyZvoOXleWI9KsssTadtc50L3tB5rbAz1aA rCttOE9wj080vwIPEjGVnH1fiOsEw3fva88ht+8e2owZYFexOf0BRmFp3gjiSTl4S7 rQcj/zQjPTPdXymXRQ+m7hVst37XqSdpHxjsHqPHdi9unk3qN+rqjhwBt+XykYUak2 eOEvnVDyKDYBZFcXxqwbBAsRRFiTWgL5gi/NCN1kEo0YjVTXfY59Hrbz+V2cCQFSRj 1uQj7zLgUGdZhZAo9XFE4+hvW5/SxbyEFpESbv1AKiLyO97St9QfyLtACiIoRAyk2Y yUEaK9gkfR80w== From: Kalle Valo To: Arend van Spriel Cc: Alexey Berezhok , Arend van Spriel , linux-wireless@vger.kernel.org, lvc-project@linuxtesting.org Subject: Re: [PATCH] wifi: brcmfmac: do not cast hidden SSID attribute value to boolean References: <20240208085121.2430-1-a@bayrepo.ru> <170775233602.2851594.8173116143852900695.kvalo@kernel.org> <9667b492-d3d3-4b04-bef4-f507387a9261@broadcom.com> Date: Mon, 12 Feb 2024 18:03:10 +0200 In-Reply-To: <9667b492-d3d3-4b04-bef4-f507387a9261@broadcom.com> (Arend van Spriel's message of "Mon, 12 Feb 2024 17:00:59 +0100") Message-ID: <87cyt1pt4x.fsf@kernel.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain Arend van Spriel writes: > On 2/12/2024 4:38 PM, Kalle Valo wrote: >> Alexey Berezhok wrote: >> >>> In 'brcmf_cfg80211_start_ap()', not assume that >>> NL80211_HIDDEN_SSID_NOT_IN_USE is zero but prefer >>> an explicit check instead. Compile tested only. >>> >>> Found by Linux Verification Center (linuxtesting.org) with SVACE. >>> >>> Signed-off-by: Alexey Berezhok >> Patch applied to wireless-next.git, thanks. >> f20073f50dfd wifi: brcmfmac: do not cast hidden SSID attribute value >> to boolean > > Alexey, > > Can you do a follow-up patch addressing my comment? If not I will do > it myself. Sorry, was I not supposed to apply the patch? What did I miss? -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches