Received-SPF: pass (google.com: domain of linux-wireless+bounces-3486-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <7a401e5ba069f58d2319ade6a7216f234440fe4b.camel@egauge.net>
Subject: Re: [PATCH v5] wifi: wilc1000: validate chip id during bus probe
From: David Mosberger-Tang <davidm@egauge.net>
Date: Mon, 12 Feb 2024 20:24:05 +0000 (UTC)
In-Reply-To: <87h6idpvd5.fsf@kernel.org>
References: <20240207044559.2717200-1-davidm@egauge.net>
	 <87h6idpvd5.fsf@kernel.org>
Organization: eGauge Systems LLC
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.44.4-0ubuntu2 
Precedence: bulk
MIME-Version: 1.0
To: Kalle Valo <kvalo@kernel.org>
Cc: linux-wireless@vger.kernel.org, Ajay.Kathat@microchip.com,
	alexis.lothore@bootlin.com

On Mon, 2024-02-12 at 17:15 +0200, Kalle Valo wrote:
> David Mosberger-Tang <davidm@egauge.net> writes:
>=20
> > Previously, the driver created a net device (typically wlan0) as soon
> > as the module was loaded.  This commit changes the driver to follow
> > normal Linux convention of creating the net device only when bus
> > probing detects a supported chip.
> >=20
> > Signed-off-by: David Mosberger-Tang <davidm@egauge.net>
> > ---
> >  drivers/net/wireless/microchip/wilc1000/spi.c | 69 +++++++++++++++----
> >  .../net/wireless/microchip/wilc1000/wlan.c    |  3 +-
> >  .../net/wireless/microchip/wilc1000/wlan.h    |  1 +
> >  3 files changed, 57 insertions(+), 16 deletions(-)
>=20
> [...]
>=20
> > --- a/drivers/net/wireless/microchip/wilc1000/wlan.c
> > +++ b/drivers/net/wireless/microchip/wilc1000/wlan.c
> > @@ -12,10 +12,11 @@
> > =20
> >  #define WAKE_UP_TRIAL_RETRY		10000
> > =20
> > -static inline bool is_wilc1000(u32 id)
> > +bool is_wilc1000(u32 id)
> >  {
> >  	return (id & (~WILC_CHIP_REV_FIELD)) =3D=3D WILC_1000_BASE_ID;
> >  }
> > +EXPORT_SYMBOL_GPL(is_wilc1000);
> > =20
> >  static inline void acquire_bus(struct wilc *wilc, enum bus_acquire acq=
uire)
> >  {
> > diff --git a/drivers/net/wireless/microchip/wilc1000/wlan.h b/drivers/n=
et/wireless/microchip/wilc1000/wlan.h
> > index f02775f7e41f..ebdfb0afaf71 100644
> > --- a/drivers/net/wireless/microchip/wilc1000/wlan.h
> > +++ b/drivers/net/wireless/microchip/wilc1000/wlan.h
> > @@ -409,6 +409,7 @@ struct wilc_cfg_rsp {
> > =20
> >  struct wilc_vif;
> > =20
> > +bool is_wilc1000(u32 id);
>=20
> I was about to apply this but then noticed the new EXPORT_SYMBOL_GPL().
> The overhead for such tiny function sounds too much, much better to move
> the static inline function to wlan.h.

Good point.  I just sent V6 which has the inline function moved to wlan.h.

Thanks,

  --david