Received: by 2002:a05:7412:3b8b:b0:fc:a2b0:25d7 with SMTP id nd11csp3023913rdb; Tue, 13 Feb 2024 04:54:25 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCVAUsmvHPbVLK8ZF/pDJk+4ZkSV0lebQar560qha4TfUEHeTEgflRqX2JmElEqjxdIaSkv7cnBzoqBF8lUjAOGXSiNrnK1KfIkwLthtqg== X-Google-Smtp-Source: AGHT+IGjTzYokMnTMYfiUXokJbrwZnGcwCnXAx/F/kfvs8OGL6Dkn4GpATST//tHA3eOGLPgyjs6 X-Received: by 2002:a05:6808:448c:b0:3c0:3088:70ec with SMTP id eq12-20020a056808448c00b003c0308870ecmr14785057oib.39.1707828865263; Tue, 13 Feb 2024 04:54:25 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707828865; cv=pass; d=google.com; s=arc-20160816; b=WQzGq95kLZC48FZwXchVmHuEwPIykBOy+C8XeQswpR4+G6XexvuVIu10B1fGm4ZJfi 60FM5wWvXnfC+2RDs/yrSRFNoBbsw9iHetSTl+nLUaOa/9cl/pc5J63Y2IpoIFrQEnMY gatWP/MayQR4GJJ5TmYDzt212txMVr+yVpgrFLKKxD4/R9+ibcrUZ8BXqVOJfJL6N3nV gOu1lHC2z1gTIDC+WjxjQDodkGROPFd7p1WYFwRiwrFudVs8Cncp7WDW2KvEIJAkqo5L hG9APA/GeToH+k81PGUocFoXqI16K0x5Ktig7/sMCvkZFk0poQiqJLFF8tfQH6har10F oaQQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:list-unsubscribe:list-subscribe:list-id:precedence :user-agent:message-id:in-reply-to:date:references:subject:cc:to :from:dkim-signature; bh=sb7Ebd0KXTrfbDbTJgvldq44vmz4c8YAK0whhjP8GtE=; fh=B5BEVbu8mwCe7lNXnbNM+Co4pmgq8xwxR984cvHXjo0=; b=amx52V47fKb/b0mkThdTdj0VeyTHMhjC+75a3TeGrbsiHNBkKJRRPmMbRI45C+mJIb KeNzXqYUSLrQgpcgzrIwmwRQV10e5lLyb2uaHX0oA2LLu0nTFdk1dNeqydoR4hJ26dGP p9GLVm/UrttrlSapfxmJist80PQRydeUmwsWh/t2GDT55t5tPkdWcIlR6UxPcydB+Dwx 4g17ogWbX1vMzIwImwtu7/WCaybIoxA+KRvE81qOme0ElMG03dahdz96Krptx5KS2oeB +UeySIqFjxLklFrNi0tl/3xu1hH9GENQaFTJ5BOcR0qM/Gs08lbPEFbJTx9L9YccZE3i C+ZQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="Q/inDF3/"; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-wireless+bounces-3537-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-wireless+bounces-3537-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org X-Forwarded-Encrypted: i=2; AJvYcCWExMwdedFxJxsTj38Hs5Os4WTHl4EKs2VJl9Ok9qMrupJgsKs9418LCA65JE3PaEPtWo1VbMSrO2xD/Gp6IOt3YJOSHs3b0KJrg/8xFQ== Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id y25-20020ac87099000000b0042c1ca83f25si2574325qto.89.2024.02.13.04.54.25 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Feb 2024 04:54:25 -0800 (PST) Received-SPF: pass (google.com: domain of linux-wireless+bounces-3537-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="Q/inDF3/"; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-wireless+bounces-3537-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-wireless+bounces-3537-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id CA5D31C24610 for ; Tue, 13 Feb 2024 12:54:24 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 05CB942075; Tue, 13 Feb 2024 12:54:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Q/inDF3/" X-Original-To: linux-wireless@vger.kernel.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D44DA42074 for ; Tue, 13 Feb 2024 12:54:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707828861; cv=none; b=U3eV29v23WUEr+A02tW4RxWBd80n5YVgkzjBMUYta8U2aEr2nNoo+ebt7EAsv+bp/9TfSguonP2HMIl1zGaMNzFKRuatgTk9Qqa1Sryge5gqd/YLFIZVpaXJeAWuMs5K5kmlfOvhmCqYcugDBLfIgWr87z3KF4iJh0wY2erD8To= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707828861; c=relaxed/simple; bh=T4ZQ+AMx5YSea1DBWbVxIvUE2u72e2fGhWCsFqDTlXI=; h=From:To:Cc:Subject:References:Date:In-Reply-To:Message-ID: MIME-Version:Content-Type; b=MZARf/bmP4jfDzOcs7ozDdxYjkEHzXBZT99Z5LKBW7+taGHeVO5aV3RelPKB+EPw1bIw6my4X7wF3pKFlHURSu/x5aACCC7QkwPJuH5RoSm69FSloWpf/cFX7b3YoiQkwVtBKCmyBk6n8Zu8QxWp8WI0lrQLsB/U8HAyBZF3Pjs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Q/inDF3/; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 787B9C433F1; Tue, 13 Feb 2024 12:54:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1707828861; bh=T4ZQ+AMx5YSea1DBWbVxIvUE2u72e2fGhWCsFqDTlXI=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=Q/inDF3/P7IGAF4lg9RHqT4x8t0c6+zrIbuh/fo/I35ih5Zl0Tr89LMqkR5TngMVn khKkPSKyrOi72CCJRQFg/kLlqp22S7oBdjEeY+Lbo5K56I5DRpe6TsJt/E1gdiVKZp KDNCaFtWvG8TWoEjGG/vCqSeS9Z/pNCyKIhfLZOxVpKgk3C1xUH81N/T3Zt8mr5pvW z6s6tkyGmKOy13vXP4QIyPcU9OdKf2gW2nTj1gS9nOsrdGPh3Ef1OF05Kxjult7zqG slaE9XDDYG20hLRy3qU06PBLmAxks7N7wc1NZMaZhKK/A7YGR/D6VnA2Z/22+go66+ iHEmW8o96qO8Q== From: Kalle Valo To: Ping-Ke Shih Cc: , Subject: Re: [PATCH] wifi: rtw89: fw: remove unnecessary rcu_read_unlock() for punctured References: <20240213122556.9593-1-pkshih@realtek.com> Date: Tue, 13 Feb 2024 14:54:18 +0200 In-Reply-To: <20240213122556.9593-1-pkshih@realtek.com> (Ping-Ke Shih's message of "Tue, 13 Feb 2024 20:25:56 +0800") Message-ID: <87ttmced8l.fsf@kernel.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain Ping-Ke Shih writes: > The rcu_read_unlock() is accidentally added, and sparse warn: > > drivers/net/wireless/realtek/rtw89/fw.c:2807:17: > warning: context imbalance in 'rtw89_fw_h2c_assoc_cmac_tbl_g7' - unexpected unlock > > Fixes: b82730bf57b5 ("wifi: cfg80211/mac80211: move puncturing into chandef") > Cc: Johannes Berg > Signed-off-by: Ping-Ke Shih Commit b82730bf57b5 is in wireless-next so I'll queue this patch to wireless-next as well, right? This again shows how important it is to fix all the remainging sparse warnings in wireless code so that we don't miss important warnings like this. If there just would be a way to get the cleanup patch submitters to fix the sparse warnings, sigh. -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches