Received: by 2002:a05:7412:3b8b:b0:fc:a2b0:25d7 with SMTP id nd11csp3085761rdb; Tue, 13 Feb 2024 06:34:44 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCULjN8OYgQQQHKE0Q9dwttN4I5bO8HaQ5tSUvJgWORQNWB0A3p33pIu6oHdhYcLgsxH3WIjO2mLMxkpmid2X8Y9DF38RN18F5hSlocQ+g== X-Google-Smtp-Source: AGHT+IEIxylpI4JOL7Eks2VsgF+zuvYek1rw/U65FlL4Ua+l25ncNxwSsDNwcSwHRdQ7ytmxIo3p X-Received: by 2002:a62:c144:0:b0:6e0:3789:1d22 with SMTP id i65-20020a62c144000000b006e037891d22mr11411805pfg.0.1707834884586; Tue, 13 Feb 2024 06:34:44 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707834884; cv=pass; d=google.com; s=arc-20160816; b=WWt+p5gsB+pfl1a8H5O2nTtruFauOejmdv+85XyxswJK+jswo9tJ0GEbWPj/hXq99v eKzd4P38COwFB+jyMSpYjesCuPjuP7JOVGpngZIqR4WaqovAeWJzt3a3UWotRS0g/FXu n1bKTJh5IKApBsx0Jsna8/lLt+uyaNChW6XutJSp9Exs07BDp3DA83Bm7xlQaf1u10xD rdPqDQrEO5QAjNU/eZxuObgq4seyZxWFSh5nG+4lgvzE0ADmRRdo7DLIdlOrvwL4hndz K4C/f8mj/s26RyTLqQqPW5P26wiOWiCfs3mwZGmSS8/3cwcF/X1RkEvPBbqDcsxGSnjl OPLQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:user-agent:date :message-id:organization:from:references:to:subject:dkim-signature :dkim-filter; bh=cvHPiK/4Zs1pcaky3c9HxTIM5v6wfSD4A2KBoBXW4kw=; fh=Q5mn0ixiDA64yyDQGGPdlnNN3iLfbTw3G30SewZlWu0=; b=MHMf/tTZ33V9iwZnApCDIEM9H67cdRETyxsSH3bXMAOttGwc7g1ewnXSDDRfkJzMNN LKxILgkbAl6BKiPdBgqMRl772+WU2b19qlhpvTgIynQ8ORWnUJo6aVvjiGE5c0anQCBC 9i1Fglhs0r574kq5co94r7anjvk96my/kgUhB2beQKLOapWdsaqAy9aQdN9zXoPc5Nzk uS8Bjlzc0RHM9Q59oL1jo3kjQnSQ8v36zeDXIWGB6o2Idw7ZzDEhXy7Irx8qPWJL0LSb W99/EYbHNPr7xQrbH1gDfRSsUL4EpTp1TD0U03T6ntwU+Ot/lie5lN7JCfpCr6VBTXzZ Dm7g==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@candelatech.com header.s=default header.b=D2hp0Qjm; arc=pass (i=1 spf=pass spfdomain=candelatech.com dkim=pass dkdomain=candelatech.com dmarc=pass fromdomain=candelatech.com); spf=pass (google.com: domain of linux-wireless+bounces-3546-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-wireless+bounces-3546-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=candelatech.com X-Forwarded-Encrypted: i=2; AJvYcCWFqnYZpX8KKCOftbu7mgpYRhtMU52HXrObQUOCl5l0Q9ksi9zIQS+cfnPhb2PfAj/FmVM0aKp5+HdlR08gaBAqHbZy4mVBxAb9w8cwqg== Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id m10-20020aa78a0a000000b006e0d76bc291si3794381pfa.111.2024.02.13.06.34.44 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Feb 2024 06:34:44 -0800 (PST) Received-SPF: pass (google.com: domain of linux-wireless+bounces-3546-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; dkim=pass header.i=@candelatech.com header.s=default header.b=D2hp0Qjm; arc=pass (i=1 spf=pass spfdomain=candelatech.com dkim=pass dkdomain=candelatech.com dmarc=pass fromdomain=candelatech.com); spf=pass (google.com: domain of linux-wireless+bounces-3546-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-wireless+bounces-3546-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=candelatech.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 64942B24F86 for ; Tue, 13 Feb 2024 14:30:55 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 5A88D5A7B3; Tue, 13 Feb 2024 14:30:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=candelatech.com header.i=@candelatech.com header.b="D2hp0Qjm" X-Original-To: linux-wireless@vger.kernel.org Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [148.163.129.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9395C5A79D for ; Tue, 13 Feb 2024 14:30:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.129.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707834621; cv=none; b=GzK9qgLIqALOcVsAvk7uYmMXpHey16irzh8SRHEfVWj7HKX/I7RzP6lhlC4ooktmauLYlnuBPR581/0XQjk0HuckjQ6CuOigq6Hl3I3bN+hjBntv2xW73fURkJMcLbafEjSEpOAwUMDamGiYeWSDfMdzJFebDpzLw/dKFkPWiGQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707834621; c=relaxed/simple; bh=nnpPaDsSHI7of09/gQAxbqex21roSP2YQ8Y3pHQcRp0=; h=Subject:To:References:From:Message-ID:Date:MIME-Version: In-Reply-To:Content-Type; b=DexJxLY+G71EvyESBKUDJVZuGmuPuDIAs9KUeXrhBq7Nu2E3lDokGh5D3m4tyDRUtIneYF9XNb7YmIQKfi/mg8SscM/t5DK2bUv+gfRIAiI7A2ZsyR97hUoE4beZqNiHYsJ9JP849/PR6aX3DGhW99Ca2mmmjB0v3tAzo8ofbXk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=candelatech.com; spf=pass smtp.mailfrom=candelatech.com; dkim=pass (1024-bit key) header.d=candelatech.com header.i=@candelatech.com header.b=D2hp0Qjm; arc=none smtp.client-ip=148.163.129.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=candelatech.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=candelatech.com Received: from dispatch1-us1.ppe-hosted.com (ip6-localhost [127.0.0.1]) by dispatch1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTP id 6F8FA2A1FBF for ; Tue, 13 Feb 2024 14:21:25 +0000 (UTC) X-Virus-Scanned: Proofpoint Essentials engine Received: from mail3.candelatech.com (mail2.candelatech.com [208.74.158.173]) by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTP id DA0FB10006D; Tue, 13 Feb 2024 14:21:17 +0000 (UTC) Received: from [192.168.1.115] (unknown [98.97.116.226]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail3.candelatech.com (Postfix) with ESMTPSA id 4A64413C2B0; Tue, 13 Feb 2024 06:21:17 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 mail3.candelatech.com 4A64413C2B0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=candelatech.com; s=default; t=1707834077; bh=nnpPaDsSHI7of09/gQAxbqex21roSP2YQ8Y3pHQcRp0=; h=Subject:To:References:From:Date:In-Reply-To:From; b=D2hp0Qjmiyd6Sgb2Xc/ADVaZ04HqppRIXR0Ed4vdotY3Enefkjwm8aGO79K5PtVdB J/qZcvjKnkNtTFRv7sAphoq8sxU8nqH1Lbwe0gXXx4Yf8Fr7QO/t4/fJnhZHVwjmY0 sDij+vh/Jfot/OsWNzBj0loZBSeNtDtuelZpKuh8= Subject: Re: iwlwifi RFC related to iwl_mvm_tx_reclaim To: Johannes Berg , linux-wireless References: <9779efb62cec04926e3bb2575a8aecc8bbf0e7ff.camel@sipsolutions.net> <2839f687-88af-ecd8-c6cb-7bdaf1808496@candelatech.com> <25395d1cee68fcd6d19a6c7843afd48ad8448a82.camel@sipsolutions.net> From: Ben Greear Organization: Candela Technologies Message-ID: Date: Tue, 13 Feb 2024 06:21:16 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 In-Reply-To: <25395d1cee68fcd6d19a6c7843afd48ad8448a82.camel@sipsolutions.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-MW Content-Transfer-Encoding: 7bit X-MDID: 1707834078-xBwwTqt1PXlb X-MDID-O: us5;ut7;1707834078;xBwwTqt1PXlb;;b42792dba290a1257c3f0aaf1c60b0ff On 2/13/24 6:14 AM, Johannes Berg wrote: > On Tue, 2024-02-13 at 06:13 -0800, Ben Greear wrote: >> >> If sta is NULL, we should still reclaim the frames? If so the check earlier in the code where >> it returns early if sta is NULL could be deleted, and add a null check down near the IS_ERR >> check? > > If the sta is NULL something went pretty much horribly wrong, not sure > what we should be trying to do in that case. I guess you could argue for > reclaiming anyway, but question is how far you go and what that risks, I > don't really know. Ok, I haven't seen it actually be null, so will just fix my particular bug and leave the rest as is. Thanks, Ben -- Ben Greear Candela Technologies Inc http://www.candelatech.com