Received: by 2002:a05:7412:3b8b:b0:fc:a2b0:25d7 with SMTP id nd11csp3117723rdb; Tue, 13 Feb 2024 07:23:04 -0800 (PST) X-Google-Smtp-Source: AGHT+IEBrWAdsDWZ/npXWS0kX+HxmSHYN5C8qBPnrL8fRUIS/v9WhJE6sNNswvsQ8DeF5pqK0JaT X-Received: by 2002:a17:90b:2884:b0:296:454f:1e72 with SMTP id qc4-20020a17090b288400b00296454f1e72mr4045951pjb.4.1707837784456; Tue, 13 Feb 2024 07:23:04 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707837784; cv=pass; d=google.com; s=arc-20160816; b=eAeh1u4FS+OX11FYWp0+3Lcn+Ypdt09YLDgCrI9JfZkjVSo5xp/chvOWmgU+86v1Az R0go0QyXIzjanPLRGFq4u6ReQRf8owGvA/zFpmHrluNWt6Wp1O+elRMhhQ4MTkIkBlyW BbMWlDtP5RGQj3IqgiS7n7I1fSsS6bY9jLQsj2Yt4z9QzFC0kxOp7S3YkecpqQY0BewT duKN+GFSgl0r6PlzKppM9OGV2jNi/vzOLc5BAE9jKkaLLrWHuog0dbI+ugM0WWsbEL/h /FE9cVx5yOSfqvHQ/LWo6S792vNK37J/s2tErfWx15KwCAnDNkO8+T52xeJ00I5azqgI /HVQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:list-unsubscribe:list-subscribe:list-id:precedence :user-agent:message-id:in-reply-to:date:references:subject:cc:to :from:dkim-signature; bh=P0qWb1MvleBP7RyU0FZAeiPhExQxfHwiHOUc0DuTrx8=; fh=JWhDsGfwIF+XVOtdlgOMRu+TLaxPZcZUCL56uZFZjIg=; b=LZNYVS7WL+2Yvq5/wSL07+9CwXhK1GmQPLxpLIenAlqlejjPuWFQH6r77X3nBOQ8xR gXH9wMwgkGuoRK8NUfsn7btRXTVJgWie2/SmX/La1u7Dfg90xgJuQ7Xr4AymUtVH+7WN 5gN4q9JuT/jF+rh4+nquhEwmUIBgnDjvEQuJ+qPHL0xvxOP9xN2e0beSsS/5Jtn9bocs 9AtPUZhC9ZZL4j5cSVcX0f/TPoOg9ivluWCxieyxMdiBDG39CJYSnJvlpq5uL7Vhabyq edFdC+TG/OvcMWMTfKPrMmgwTXa7iysprhrk9RFJNcN3OZpg4oXdwdKazVPR91YM8CWx y8lA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=npXGlbWA; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-wireless+bounces-3551-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-wireless+bounces-3551-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org X-Forwarded-Encrypted: i=2; AJvYcCWwvbg8l/7WLo4GMPpVc8QXZbXUz9V0SS/qG1zkL7l1ufi4lilbqjeu4fJzGRmJDpW4QS8C7vDW1pN9oxGpqlkuwWs2MpzVcXaM2f1OLg== Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id h189-20020a6383c6000000b005d8e1ec7226si2094606pge.552.2024.02.13.07.23.04 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Feb 2024 07:23:04 -0800 (PST) Received-SPF: pass (google.com: domain of linux-wireless+bounces-3551-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=npXGlbWA; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-wireless+bounces-3551-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-wireless+bounces-3551-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 10100283011 for ; Tue, 13 Feb 2024 15:23:04 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 324305A7B7; Tue, 13 Feb 2024 15:23:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="npXGlbWA" X-Original-To: linux-wireless@vger.kernel.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0DF5855C39 for ; Tue, 13 Feb 2024 15:22:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707837780; cv=none; b=snTY/QM2TmxiUJyIGyIbzIIEyFu6Y6ZEhlGXQRVFro4yG3PauQjT39JFtfblmDGtikCEnD07CvehiE/fyHXhhpS+SZqr+mJFUdKu3ERN9NNWKEWPutFuRPRHfnrv+4CHY9Wz1P9jSKJRDXy45F1GUGzSStQ7BuSDHFZZpcRsjlE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707837780; c=relaxed/simple; bh=T3zWkYJB6TH8eWBtz/OZluFWQRVFkS3TMCW/3gKsuEk=; h=From:To:Cc:Subject:References:Date:In-Reply-To:Message-ID: MIME-Version:Content-Type; b=tyJlPphcVqwTTXiVwW9RCUG1IMRx3MF1MAbp017v6LVB/KiNF0ABrigJKFWJ8jDa1ZpqTK/5SGQktS5ObNuV0hRB9hLpdUHeBSY/MEbZuf9X8tdEVyLAiKyTFpCcvvYZ7i2Gh7FtQCuVzg83vM4VB1XlqhRjiGqla2uNEGVhW5w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=npXGlbWA; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id C0838C433F1; Tue, 13 Feb 2024 15:22:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1707837779; bh=T3zWkYJB6TH8eWBtz/OZluFWQRVFkS3TMCW/3gKsuEk=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=npXGlbWA04duFep92GjgC8Eke/LaEHok4NuKuOwuVoAZth7+j0WRuW3zsDEEkBz61 i1uI61CM57YVcRngVLZS3BMoq3HhFeQqK0CMeH/YAoaJ/9VEsdHqq51uKDPfsQa87o gczrjs5LrYP0FWKjivXcRaq+mGWSvwERfjm88FTpGDwyqJmsoGaElmaQ5ScSz4rKZZ LxnLa3YApHN5mwzOAdTIpgmU4VG8Wv9Gt2QR3qJpl7WVqja6SHI7LBbTCB7NjQZr7I eIZvAEYHfDmo86K/mQKqWT1h+ISWAymoF8FCJ4MEHvpcEnZXfqSgwQ50okFrFjoi3C dZcgS/7f60MpA== From: Kalle Valo To: Ping-Ke Shih Cc: "linux-wireless@vger.kernel.org" , "johannes.berg@intel.com" Subject: Re: [PATCH] wifi: rtw89: fw: remove unnecessary rcu_read_unlock() for punctured References: <20240213122556.9593-1-pkshih@realtek.com> <87ttmced8l.fsf@kernel.org> Date: Tue, 13 Feb 2024 17:22:56 +0200 In-Reply-To: (Ping-Ke Shih's message of "Tue, 13 Feb 2024 13:43:46 +0000") Message-ID: <874jecpewf.fsf@kernel.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain Ping-Ke Shih writes: >> This again shows how important it is to fix all the remainging sparse >> warnings in wireless code so that we don't miss important warnings like >> this. If there just would be a way to get the cleanup patch submitters >> to fix the sparse warnings, sigh. > > In short term, can we record the count of warnings and ensure it > doesn't increase while new commits are getting merged? Netdev has that kind of checks in checkpatch: netdev/build_allmodconfig_warn success Errors and warnings before: 993 this patch: 992 https://patchwork.kernel.org/project/netdevbpf/patch/20240213112122.404045-2-leitao@debian.org/ But in wireless project we have not set up that. That reminds me that I need to reply to Jakub's email related to this. -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches