Received-SPF: pass (google.com: domain of linux-wireless+bounces-3554-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
From: Kalle Valo <kvalo@kernel.org>
To: Arend van Spriel <arend.vanspriel@broadcom.com>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH] wifi: brcmfmac: do not cast hidden SSID attribute value
 to boolean
References: <20240208085121.2430-1-a@bayrepo.ru>
	<170775233602.2851594.8173116143852900695.kvalo@kernel.org>
	<9667b492-d3d3-4b04-bef4-f507387a9261@broadcom.com>
	<87cyt1pt4x.fsf@kernel.org>
	<18d9e33a040.279b.9b12b7fc0a3841636cfb5e919b41b954@broadcom.com>
	<878r3opjx9.fsf@kernel.org>
	<bd282847-0408-45cc-a203-11e808ec5f39@broadcom.com>
Date: Tue, 13 Feb 2024 17:46:33 +0200
In-Reply-To: <bd282847-0408-45cc-a203-11e808ec5f39@broadcom.com> (Arend van
	Spriel's message of "Tue, 13 Feb 2024 15:01:08 +0100")
Message-ID: <87v86snz8m.fsf@kernel.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux)
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain

Arend van Spriel <arend.vanspriel@broadcom.com> writes:

>> My bad, I misunderstood your intentions. Luckily this time it wasn't
>> serious.
>> BTW to make super clear to me I would prefer that you (Arend) use
>> Acked-by. It shows up in my script like the number '1' here:
>> *[  4] [next] wifi: carl9170: Remove redundant assignment t... 1 - -
>> 2   5d Colin Ian Ki Under Review
>> So if I don't see your Acked-by then I will not even look at the
>> patch :)
>
> Sure. I tend to use Acked-by if things look sane a quick glance. If I
> need to dig further I prefer to use Reviewed-by. If I have comments to
> revise the patch I will refrain using them. Is that ok or you really
> want it to be Acked-by?

Ah, now I understand better. My understanding is that the maintainer of
the driver uses Acked-by and others use Reviewed-by. This says the same:

https://docs.kernel.org/process/submitting-patches.html#when-to-use-acked-by-cc-and-co-developed-by

And yes, I would prefer if you could use Acked-by always. It's up to
your judgement if you do just a peek or in-depth review :)

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches