Received-SPF: pass (google.com: domain of linux-wireless+bounces-3577-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <9032fcc0-e2c4-1e97-1eec-02c3727d3b2e@bayrepo.ru>
Date: Wed, 14 Feb 2024 13:28:24 +0300
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.15.1
Subject: Re: [PATCH] wifi: brcmfmac: do not cast hidden SSID attribute value
 to boolean
Content-Language: ru, en-US
To: Arend van Spriel <arend.vanspriel@broadcom.com>,
 Kalle Valo <kvalo@kernel.org>
Cc: Arend van Spriel <aspriel@gmail.com>, linux-wireless@vger.kernel.org,
 lvc-project@linuxtesting.org
References: <20240208085121.2430-1-a@bayrepo.ru>
 <170775233602.2851594.8173116143852900695.kvalo@kernel.org>
 <9667b492-d3d3-4b04-bef4-f507387a9261@broadcom.com>
From: Alexey Berezhok <a@bayrepo.ru>
In-Reply-To: <9667b492-d3d3-4b04-bef4-f507387a9261@broadcom.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

12.02.2024 19:00, Arend van Spriel wrote:
> On 2/12/2024 4:38 PM, Kalle Valo wrote:
>> Alexey Berezhok <a@bayrepo.ru> wrote:
>>
>>> In 'brcmf_cfg80211_start_ap()', not assume that
>>> NL80211_HIDDEN_SSID_NOT_IN_USE is zero but prefer
>>> an explicit check instead. Compile tested only.
>>>
>>> Found by Linux Verification Center (linuxtesting.org) with SVACE.
>>>
>>> Signed-off-by: Alexey Berezhok <a@bayrepo.ru>
>>
>> Patch applied to wireless-next.git, thanks.
>>
>> f20073f50dfd wifi: brcmfmac: do not cast hidden SSID attribute value 
>> to boolean
> 
> Alexey,
> 
> Can you do a follow-up patch addressing my comment? If not I will do it 
> myself.
> 
> Regards,
> Arend
> -- 
> https://patchwork.kernel.org/project/linux-wireless/patch/20240208085121.2430-1-a@bayrepo.ru/

Hello, do you mean this kind of modification:
diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c 
b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c
index 63f6e9436..d8f7bd5ce 100644
--- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c
+++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c
@@ -5269,7 +5269,7 @@ brcmf_cfg80211_start_ap(struct wiphy *wiphy, 
struct net_device *ndev,
                 }

                 err = brcmf_fil_iovar_int_set(ifp, "closednet",
-                                             settings->hidden_ssid);
+                                             (settings->hidden_ssid == 
NL80211_HIDDEN_SSID_NOT_IN_USE? 0 : 1));
                 if (err) {
                         bphy_err(drvr, "%s closednet error (%d)\n",
                                  (settings->hidden_ssid != 
NL80211_HIDDEN_SSID_NOT_IN_USE) ?

If so, I will make additional patch.

Regards,
Alexey