Received: by 2002:a05:7412:2a91:b0:fc:a2b0:25d7 with SMTP id u17csp477258rdh; Wed, 14 Feb 2024 02:38:21 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCXeN2ntlsfQG2ggVpxSHpr7BoUp8ztgRg+VfsHnGYCUm15VgjnLRUlWmkRwB2ULu0ZIm0pDLH7zM3YRYqebDbz9CDdKM3zpInnrXuA0qw== X-Google-Smtp-Source: AGHT+IGzWkDhI4wO8vJ+oNy6orDmoApgkBhGmC/I5th+1qtOwNdei56hzV/DvmU5vZ8xoeoD6l89 X-Received: by 2002:a05:6a21:2d87:b0:19c:678d:c1c with SMTP id ty7-20020a056a212d8700b0019c678d0c1cmr2616156pzb.37.1707907101332; Wed, 14 Feb 2024 02:38:21 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707907101; cv=pass; d=google.com; s=arc-20160816; b=yrbm07pwaOZtAHc+lUMLs4NqdziMHb2A4q/4ef2zH+wdCTxcFIXNMQ6joBBtnBFl0A 7Eq9NC+eI83aoPm7uhMU4OpttR8BTKJykVQVH5OvTfQ8ecD4TrJ3xdAU5TO1y/h9uBJm 7uAFIcxOOgB8Uqw09TcCxuLuJqr06traiyM5zGXkJNoVmncZ+84lPYBLF1OkVq+UCs2t iL8oLLQothlYFgOWhWqpD6Ppz5ItX7OKD0HJCp2E/kLXDjwpq7iLdjeGOm9MjdlJ1RSr VIqQI7uvcIjG407BxqKU2w15G5OSVDtQ0TFY42+pRqB3PFq/3fHacUVcWXzXl4YaVI1s Fpng== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=subject:cc:to:from:date:references:in-reply-to:message-id :mime-version:list-unsubscribe:list-subscribe:list-id:precedence :user-agent:feedback-id:dkim-signature:dkim-signature; bh=hsAwWJXbZPPI/cnP33KCPKaERFMiR+GhoK31+f3s78A=; fh=JQZ6oqk5aAvkCCH9S6Xnlc1neaZbvvM3Vxpm4GNwJg8=; b=Nt7nU9HnCoWsETqxgPW/UcVzdoEOMMqgS4OLcBaOeYOjWsuwvb+I7Uva72VhcIntqM W92qo84ab4tM/j4a4e3ohfI0DDxrbOTkAoYmj7Zdg5naoEig50hpsEXMy2iOg2GmaVeo fk6OACfIqA59jFmvO4x5iV3q2sga3L0koSLmNjON9oT+tfql454S7LudJlraVWbzqFou mrY8E2XudceUHCHWu6Y+QVCvlG+geIra0IVBHoBCF94KB4djpjXyt8BIyf6j5j6Jnmjx Ta92GM6CI+9Wmw1uKz3y/rm1CCfrnNGzakq/7Qfzm4GN6OKe1ZLlqXslj5thvV//QYIG /D6A==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@arndb.de header.s=fm3 header.b=bLjuLiUe; dkim=pass header.i=@messagingengine.com header.s=fm3 header.b=ndd8+Bfc; arc=pass (i=1 spf=pass spfdomain=arndb.de dkim=pass dkdomain=arndb.de dkim=pass dkdomain=messagingengine.com dmarc=pass fromdomain=arndb.de); spf=pass (google.com: domain of linux-wireless+bounces-3578-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-wireless+bounces-3578-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=arndb.de X-Forwarded-Encrypted: i=2; AJvYcCV+YNb0R7jl0Ad0Z1xr7/0zLZf7bbxAnu+T4xv62xK1aLt12ji3o/K5X1Y2YmGHB2hzqoAeMyGr600uuZNHOs3UhjJKD0P/MiN/LVyXSg== Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id y126-20020a62ce84000000b006e08bc19c82si8115064pfg.82.2024.02.14.02.38.21 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Feb 2024 02:38:21 -0800 (PST) Received-SPF: pass (google.com: domain of linux-wireless+bounces-3578-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@arndb.de header.s=fm3 header.b=bLjuLiUe; dkim=pass header.i=@messagingengine.com header.s=fm3 header.b=ndd8+Bfc; arc=pass (i=1 spf=pass spfdomain=arndb.de dkim=pass dkdomain=arndb.de dkim=pass dkdomain=messagingengine.com dmarc=pass fromdomain=arndb.de); spf=pass (google.com: domain of linux-wireless+bounces-3578-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-wireless+bounces-3578-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=arndb.de Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id C5197282000 for ; Wed, 14 Feb 2024 10:38:20 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 8F00A14297; Wed, 14 Feb 2024 10:38:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=arndb.de header.i=@arndb.de header.b="bLjuLiUe"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="ndd8+Bfc" X-Original-To: linux-wireless@vger.kernel.org Received: from wfout5-smtp.messagingengine.com (wfout5-smtp.messagingengine.com [64.147.123.148]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F38CC611A; Wed, 14 Feb 2024 10:38:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=64.147.123.148 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707907098; cv=none; b=TVM6tCN3DcY1ND5klY7nmF4p+gSPCFdEx+Zwft7hn2BnZbzwSUlIoB//bpk0MjC0hrsL7HiwttdEvgrxxu4l6Fp+LkvLKYcOF2lGvW9NnZVTKutEw+Xjfo2V+h1DmKuu6+XL3zmj0NM1BvFedwbzjFLz2PduvT+UwBewqCy7Sgg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707907098; c=relaxed/simple; bh=v5CFtEaWyN8p5OJ7qhiRN25Xg0hRyL/byYYg7V2/FY0=; h=MIME-Version:Message-Id:In-Reply-To:References:Date:From:To:Cc: Subject:Content-Type; b=aICJKx7MHcFwfYijsbzU4NXcJyH+jaJFtfcz12w4KcxWmyPHIXBp7XnVJPJh/M0GxLoMGqu9wWDychMPMyGFKx9kwcuIHWF5FQsjTWsHl9CkuvDfgoQTz49b7PZkvtgVVa0azpRS7OS6rAsB5Tu9ozMRrUm9nm4yqSD7xAIfv4U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arndb.de; spf=pass smtp.mailfrom=arndb.de; dkim=pass (2048-bit key) header.d=arndb.de header.i=@arndb.de header.b=bLjuLiUe; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b=ndd8+Bfc; arc=none smtp.client-ip=64.147.123.148 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arndb.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arndb.de Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailfout.west.internal (Postfix) with ESMTP id 31B471C00070; Wed, 14 Feb 2024 05:38:15 -0500 (EST) Received: from imap51 ([10.202.2.101]) by compute5.internal (MEProxy); Wed, 14 Feb 2024 05:38:16 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arndb.de; h=cc :cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm3; t=1707907094; x=1707993494; bh=hsAwWJXbZP PI/cnP33KCPKaERFMiR+GhoK31+f3s78A=; b=bLjuLiUeHArSfkef+Wd6hi4JSZ uzR/mr6mPiImtzU92m7boaR/S3qb8gazw5An9VYAP8GSPqTUisgIzs40In7MwtDR ioQPgLuAx8ExbNosqTg1/qCSxPh3k+ZZ2HOiPLsPQPqLdBIRkq3V7B5JR82Q5F+Z VO8KHyZyXT8B07WvHD0ID6lErwdSko+r8Gb85RuZbKf1/+n6yJdoGs7oBVO6pyY/ PB+OD/NHMqBfEUOKuj3bbsRnJS9peCWzy90Sf770RA0VCFRS+2BWEux1puit2dyX rxyD2k8UNtLSc730s3y2D67FrBqehIwshr7THNZ2sp3sY/hRj7n+UKnELqYA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; t=1707907094; x=1707993494; bh=hsAwWJXbZPPI/cnP33KCPKaERFMi R+GhoK31+f3s78A=; b=ndd8+BfctchXQ/AjAbk8pLKgxqHR4DZNOjdlkQTKhqxy xUq8wdRBBYh8L08eAw2NCp2gXdsHG/jpDtgOCCLu2luOzZue3eM4dJ2S2hVrtkdE B2hy1MNG7qNtwazBReU02j9HR9CIgy9Y173IWOvDzwUCt4Zb/xAY8Q09oSV1yuTE SHRD3lw4Gm2tkrz1rOYgbRK7UD9ViYsc9+naIlphsqa1n3ENpY2/oMw5KSuAAgu7 lV8efUY+PDxRYZJjt2EzQzqsTy0EugOdMHnGiRmV+xkMyPkqIP1qCURb0nraFFNI JJimtZtmAz0yEx0FjaRumCvAQepFyInmuyNSshIAQw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrudejgddujecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefofgggkfgjfhffhffvvefutgesthdtredtreertdenucfhrhhomhepfdetrhhn ugcuuegvrhhgmhgrnhhnfdcuoegrrhhnugesrghrnhgusgdruggvqeenucggtffrrghtth gvrhhnpeevhfffledtgeehfeffhfdtgedvheejtdfgkeeuvefgudffteettdekkeeufeeh udenucffohhmrghinhepkhgvrhhnvghlrdhorhhgnecuvehluhhsthgvrhfuihiivgeptd enucfrrghrrghmpehmrghilhhfrhhomheprghrnhgusegrrhhnuggsrdguvg X-ME-Proxy: Feedback-ID: i56a14606:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id 64771B6008D; Wed, 14 Feb 2024 05:38:14 -0500 (EST) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.11.0-alpha0-144-ge5821d614e-fm-20240125.002-ge5821d61 Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <08ac32ef-610d-479d-a3fd-a3c3b8c4c697@app.fastmail.com> In-Reply-To: <170790025305.3179441.138152315558305278.kvalo@kernel.org> References: <20240213100912.459018-1-arnd@kernel.org> <170790025305.3179441.138152315558305278.kvalo@kernel.org> Date: Wed, 14 Feb 2024 11:37:52 +0100 From: "Arnd Bergmann" To: "Kalle Valo" , "Arnd Bergmann" Cc: "Jeff Johnson" , "Karthikeyan Periyasamy" , "Aloka Dixit" , "Wen Gong" , "Muna Sinada" , "Aditya Kumar Singh" , ath12k@lists.infradead.org, linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] wifi: ath12k: sanitize ath12k_mac_allocate() return code Content-Type: text/plain On Wed, Feb 14, 2024, at 09:44, Kalle Valo wrote: > Arnd Bergmann wrote: > >> The return code has no initializer: >> >> drivers/net/wireless/ath/ath12k/mac.c:8006:9: error: variable 'ret' is uninitialized when used here [-Werror,-Wuninitialized] >> >> Make it return -ENOMEM for allocation failures and remove the unused >> variable instead. >> >> Fixes: 6db6e70a17f6 ("wifi: ath12k: Introduce the container for mac80211 hw") >> Signed-off-by: Arnd Bergmann >> Signed-off-by: Kalle Valo > > Nathan already fixed this: > > https://git.kernel.org/kvalo/ath/c/04edb5dc68f4 > > Patch set to Rejected. Ok, sounds good. Nathan's patch looks fine to me, but I see it's not in linux-next yet as of today. Arnd