Received: by 2002:a05:7412:2a91:b0:fc:a2b0:25d7 with SMTP id u17csp479840rdh; Wed, 14 Feb 2024 02:45:12 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCULDXR4/LqYFA+iKxjqFXnLe1jJ1MXbeOhc9uINlEqvBQS0lKufoRkYEREnukSpICu/Qui/iGvR2VzaWLRxNOIsrmejmXLoW0RjqgMs9w== X-Google-Smtp-Source: AGHT+IGxtd/JCrU94ENLkWOW1pN+d38amSonu+lBKMzBm8jptoKgvBCwovmv+SRkXju7uU0kfWiU X-Received: by 2002:a05:6402:26c9:b0:563:7db2:4fe1 with SMTP id x9-20020a05640226c900b005637db24fe1mr1092037edd.38.1707907512182; Wed, 14 Feb 2024 02:45:12 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707907512; cv=pass; d=google.com; s=arc-20160816; b=jy6fCtUmtGHWvH0cOYzh2NdlQmnEd2myy5V8Ab32vaJduHLEpbyozgJD+GlIs2lqZX NhtE5A9D99OzudK/40eIaOwcoIa3z6V72kKtDLtatoJEN9ZeqGnUGa0HGtqkd7u7fQc+ jkQzKb+6MaRfHcIullfalGGamBSUBM/sGC5PP5kGpwmdqOiOWGfImdS5Fd8utLQHn/Zu FsCYDMSrM3/c7IkefV6j7Miq+QJLXEtIJa09c3/6jvwThjqM/XmgGG8VUJo3FdA8Z7XY 191UE/Zhjinyz/09oUe5fN7hgn24AdZ0TTlfLh67Gk3rKPcTb600AZisv0ihABjmQJ7N yk6A== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:list-unsubscribe:list-subscribe:list-id:precedence :user-agent:message-id:in-reply-to:date:references:subject:cc:to :from:dkim-signature; bh=yi3Xs7CvpqCNzxxb6XTsRLlCiBOaXTGuNmWTsgxzBXA=; fh=j6Hybyhct27nlB2IxemDM43f+xJi/S6ZSmZvlJDLGvc=; b=VIB5MF04puiesrII8Y1v3aB7RSBI+xbVFuVJuxdZ0Y++FuVPfk45MO61N/VHC7yhHs 1e7avUiURgr0WDkZ8JV6L7VdC3n17dCQcDnraR3X0AZNbxjtmOgizn6DIeRGE+0D022z 6X0Z1L22RnBYMobbf3LG535jDtYWMgV0+dwtHNahtrjcc3+1rByg6GtXFwoamSusFOK3 5FN5M3y/dG+ZZXfPIIADxCti+nR5kpVSJW4JMC6rvkynoBFKe24TJXTe2TLlTK4CRGGn kDYtjwqw1zi/4vVJMta0TslBEN8vCiFl7ZQwG//4n7XMMwJZotdFY9uHgJOZPNOanDZR qAKQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=MHd1grYr; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-wireless+bounces-3579-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-wireless+bounces-3579-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org X-Forwarded-Encrypted: i=2; AJvYcCUesQxMhcC4I6LlGFYuKttVQUZMxLulvMHbweCuJ8rEqAuYP/J4HXqB9Jo8dAeYcUltzfpplREvYRdBTUJtSen5pslJWCCwU3yWZOJ80g== Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id s3-20020a50d483000000b005600f538252si4712843edi.227.2024.02.14.02.45.12 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Feb 2024 02:45:12 -0800 (PST) Received-SPF: pass (google.com: domain of linux-wireless+bounces-3579-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=MHd1grYr; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-wireless+bounces-3579-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-wireless+bounces-3579-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id D6EE21F218F6 for ; Wed, 14 Feb 2024 10:45:11 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 89DB418C36; Wed, 14 Feb 2024 10:45:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="MHd1grYr" X-Original-To: linux-wireless@vger.kernel.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 59F8518C28; Wed, 14 Feb 2024 10:45:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707907503; cv=none; b=qr3t1djgeddXY2Vwqq03R/j9Mk207jAyNmOVM898iqQZVpYBTDQza3/ZCyzZLWYnjwmpShTehIXu3kPUwrwV5kJ68Q5/OyxaBZK0mhRS1tYU8bs4zDL0m59h+Mt2l63JDpvDnIhEnXpxsJII9Tub0pzQnJesyTWa+E3k/sbk9MY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707907503; c=relaxed/simple; bh=c5a5QD1qybAX8sIO7SlkwMh3DXcoPgzluORoGmCH18o=; h=From:To:Cc:Subject:References:Date:In-Reply-To:Message-ID: MIME-Version:Content-Type; b=Xl8ISgZ4BfeAS+ULThSr1AosnjWt/CPhAHpl/1PYVXN0ehQ4LVNykEqwZxZQ5fZHI7ZIReynWJSqmlDNIa7Y3gAc0QzxdkF1TUDG89OQzsOzA/40l1iiyv1YFm/BukxZqOsaQYBRkB8pqsb83jq54k8tACQVRS31ef+/kVpFi8c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=MHd1grYr; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id C5F91C433F1; Wed, 14 Feb 2024 10:45:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1707907502; bh=c5a5QD1qybAX8sIO7SlkwMh3DXcoPgzluORoGmCH18o=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=MHd1grYrjnKc6N9SBwHUg+n7lvaoMgaqHzbsWY/uOvBtvyA/Sdh5GG2It2CXBgr+O f6cdD473ETW5ujH6eag47aT9vAFUtzuCDz2Qo3hbR/iKNTJ/nzTfi1eDzuyMui+ma4 SMSV86kIPVszpaikgwZmMolujKS0mFjwrO1ZBlfpR2uNg46S5LBdN/EY/clf9ny6t/ w1UtIqsz3y+mk73XgXWesN6JXldOrboaDEk/OC0MDo9uacqx3ZHkVSzh9ww4X84cMk KNU4hDcT6ApwBbp0wc6VQdixjI1QQ5UdladLXqrjxpiYZHjQ5XLKeZg98BIMBPUvZc TEhhP98yNTKZw== From: Kalle Valo To: "Arnd Bergmann" Cc: "Arnd Bergmann" , "Jeff Johnson" , "Karthikeyan Periyasamy" , "Aloka Dixit" , "Wen Gong" , "Muna Sinada" , "Aditya Kumar Singh" , ath12k@lists.infradead.org, linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] wifi: ath12k: sanitize ath12k_mac_allocate() return code References: <20240213100912.459018-1-arnd@kernel.org> <170790025305.3179441.138152315558305278.kvalo@kernel.org> <08ac32ef-610d-479d-a3fd-a3c3b8c4c697@app.fastmail.com> Date: Wed, 14 Feb 2024 12:44:58 +0200 In-Reply-To: <08ac32ef-610d-479d-a3fd-a3c3b8c4c697@app.fastmail.com> (Arnd Bergmann's message of "Wed, 14 Feb 2024 11:37:52 +0100") Message-ID: <87plwze34l.fsf@kernel.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain "Arnd Bergmann" writes: > On Wed, Feb 14, 2024, at 09:44, Kalle Valo wrote: >> Arnd Bergmann wrote: >> >>> The return code has no initializer: >>> >>> drivers/net/wireless/ath/ath12k/mac.c:8006:9: error: variable 'ret' is uninitialized when used here [-Werror,-Wuninitialized] >>> >>> Make it return -ENOMEM for allocation failures and remove the unused >>> variable instead. >>> >>> Fixes: 6db6e70a17f6 ("wifi: ath12k: Introduce the container for mac80211 hw") >>> Signed-off-by: Arnd Bergmann >>> Signed-off-by: Kalle Valo >> >> Nathan already fixed this: >> >> https://git.kernel.org/kvalo/ath/c/04edb5dc68f4 >> >> Patch set to Rejected. > > Ok, sounds good. Nathan's patch looks fine to me Great, thanks for checking. > but I see it's not in linux-next yet as of today. Yeah, it's a problem that ath.git is not included linux-next builds. The commits will be in linux-next only after ath-next is pulled to wireless-next :/ -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches