Received-SPF: pass (google.com: domain of linux-wireless+bounces-3590-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
From: Alexey Berezhok <a@bayrepo.ru>
To: Arend van Spriel <aspriel@gmail.com>
Cc: Kalle Valo <kvalo@kernel.org>,
	linux-wireless@vger.kernel.org,
	lvc-project@linuxtesting.org,
	Alexey Berezhok <a@bayrepo.ru>
Subject: [PATCH] wifi: brcmfmac: do not pass hidden SSID attribute as value directly
Date: Wed, 14 Feb 2024 18:21:17 +0300
Message-Id: <20240214152117.14467-1-a@bayrepo.ru>
Precedence: bulk
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

In 'brcmf_cfg80211_start_ap()', not assume that
NL80211_HIDDEN_SSID_NOT_IN_USE is zero but prefer
an explicit check instead.  Use local
variable 'closednet' to pass in function call and
use for error message. Compile tested only.

Addition for the following patch

    commit f20073f50dfd1 ("wifi: brcmfmac: do not cast hidden SSID
                           attribute value to boolean")

Signed-off-by: Alexey Berezhok <a@bayrepo.ru>
---
 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c
index 63f6e9436..cd6e01f23 100644
--- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c
+++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c
@@ -5269,7 +5269,8 @@ brcmf_cfg80211_start_ap(struct wiphy *wiphy, struct net_device *ndev,
 		}
 
 		err = brcmf_fil_iovar_int_set(ifp, "closednet",
-					      settings->hidden_ssid);
+				(settings->hidden_ssid == NL80211_HIDDEN_SSID_NOT_IN_USE) ?
+				0 : 1);
 		if (err) {
 			bphy_err(drvr, "%s closednet error (%d)\n",
 				 (settings->hidden_ssid != NL80211_HIDDEN_SSID_NOT_IN_USE) ?
-- 
2.39.3