Received-SPF: pass (google.com: domain of linux-wireless+bounces-3594-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
From: Kalle Valo <kvalo@kernel.org>
To: "Arnd Bergmann" <arnd@arndb.de>
Cc: "Arend van Spriel" <arend.vanspriel@broadcom.com>,  "Arnd Bergmann"
 <arnd@kernel.org>,  "Nathan Chancellor" <nathan@kernel.org>,  "Greg
 Kroah-Hartman" <gregkh@suse.de>,  "Pieter-Paul Giesberts"
 <pieterpg@broadcom.com>,  "Nick Desaulniers" <ndesaulniers@google.com>,
  "Bill Wendling" <morbo@google.com>,  "Justin Stitt"
 <justinstitt@google.com>,  "Artem Chernyshev"
 <artem.chernyshev@red-soft.ru>,  "Jonas Gorski" <jonas.gorski@gmail.com>,
  linux-wireless@vger.kernel.org,  brcm80211@lists.linux.dev,
  brcm80211-dev-list.pdl@broadcom.com,  linux-kernel@vger.kernel.org,
  llvm@lists.linux.dev
Subject: Re: [PATCH] brcmsmac: avoid function pointer casts
References: <20240213100548.457854-1-arnd@kernel.org>
	<170790035300.3179441.9169506478575963188.kvalo@kernel.org>
	<fd36f032-3bf6-4cae-a0d0-213604cef024@broadcom.com>
	<3f1c2d5a-ba98-4ae5-a7a0-0328b7552113@app.fastmail.com>
Date: Wed, 14 Feb 2024 19:55:48 +0200
In-Reply-To: <3f1c2d5a-ba98-4ae5-a7a0-0328b7552113@app.fastmail.com> (Arnd
	Bergmann's message of "Wed, 14 Feb 2024 16:07:00 +0100")
Message-ID: <87frxvnd5n.fsf@kernel.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux)
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain

"Arnd Bergmann" <arnd@arndb.de> writes:

> On Wed, Feb 14, 2024, at 10:23, Arend van Spriel wrote:
>
>> On 2/14/2024 9:45 AM, Kalle Valo wrote:
>>> Arnd Bergmann <arnd@kernel.org> wrote:
>>> 
>>>> From: Arnd Bergmann <arnd@arndb.de>
>>>>
>>>> An old cleanup went a little too far and causes a warning with clang-16
>>>> and higher as it breaks control flow integrity (KCFI) rules:
>>>>
>>>> drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy_shim.c:64:34: error: cast from 'void (*)(struct brcms_phy *)' to 'void (*)(void *)' converts to incompatible function type [-Werror,-Wcast-function-type-strict]
>>>>     64 |                         brcms_init_timer(physhim->wl, (void (*)(void *))fn,
>>>>        |                                                       ^~~~~~~~~~~~~~~~~~~~
>>>>
>>>> Change this one instance back to passing a void pointer so it can be
>>>> used with the timer callback interface.
>>>>
>>>> Fixes: d89a4c80601d ("staging: brcm80211: removed void * from softmac phy")
>>>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>>> 
>>> I guess this should go to wireless tree?
>>
>> This has been like this forever looking at the "staging" part in the 
>> Fixes tag. Is it really so urgent now? On the other hand I have no real 
>> problem with moving this to the wireless tree. Just wondering out loud.
>
> It's probably fine either way. Some maintainers like to backport
> the warning fixes to stable kernels, others don't. Since the
> warning is currently only enabled at W=1 level, it's probably fine
> to fix it for linux-next only, but if we want the fix backported,
> it should also go into 6.8.

Thanks, let's take it wireless-next then.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches