Received: by 2002:a05:7412:1e0b:b0:fc:a2b0:25d7 with SMTP id kr11csp382015rdb; Thu, 15 Feb 2024 03:12:15 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCVyvX6/VRP7/5zoR6CYiCeLsmZhMa97eVxPjBursRoHjN19wye90m+hoTWrUsKJJO0/g+JDafAvvMOTfwPm8rO+voU+d6pMizjPCH2Umg== X-Google-Smtp-Source: AGHT+IGfiOxpYUHLMzKwCSJ+rcyzG3+VRb7JVCerYyUtjBBaGDtWo8LcubhRyfMLYXROwcttq9mi X-Received: by 2002:a05:6214:21c6:b0:68f:1ada:894c with SMTP id d6-20020a05621421c600b0068f1ada894cmr1097387qvh.27.1707995534942; Thu, 15 Feb 2024 03:12:14 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707995534; cv=pass; d=google.com; s=arc-20160816; b=SEqm8Mp04xydwdOS7knNpGwdIKjPJiGg86OEP5V85hTUWFNHIL12sZZb+I+6GomL06 iOZCQk8i1g92RT5t+wfiBSlqJyyCGHy74QdO4AoWxDcv5HxScXa59WutY0TU8HVxtDtv zX5/R/YdfVR2kPGwB3AZ7YXEO91Yp9PnUOC7l3tVktRezM+SLHF/9zjnU+kH3FE7Qrb4 B48hcM+vRa8ukWvVrGMnV8F3fNC/Z9deIeD1z9vTNFgr3NUsXu+BovciJil2fnH+Duiq pDfOcqN0aVcSDp5w1KUR9rFZBPjzUymYQQWTURoQfefC731tqPfc6mlxXNxV/Afk1BmV q7sg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=date:message-id:user-agent:cc:to:references:in-reply-to:from :subject:content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:dkim-signature; bh=A9qfGntLmvGJRW5hwh805MLXCM6idx2gmErp177UtVQ=; fh=KLYZroe+hx7PXWHWhHVHm3kyvVqb0KvAA/sfTDNY4Ss=; b=0Vq0tUBb9iKlvdRWQM1fUzIDqemib4bTK4a05A77p1NtRtEuJNouaQ92aO5pzXxbY6 UCUtX7RbCzzS8qvgtqXyRB9vkShGY+ACZPsazJgkX44OcsjaHzsmOCQT/XEd2XG6MeBt OCMkGeRGfj1CIQJGJxrbpQgkH0u0cSNDh8BUZevkRdnlzY5qFDrWY22cKAOYUZzUUPzs SoPTdX4GpIbC3tLI+XD3lDMYM8dcbItP5QrGvMm43hH067Ifc2tROuDtiiz113QGT/D/ 0eSOFc4fdodbfYaxeYfJY9q7ZjyH1y3uxDppIKF6AF9jiZYcszU0zrh5V7u6JNAJ/fLb nSMw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=FSG0itI+; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-wireless+bounces-3619-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-wireless+bounces-3619-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id 11-20020a05621420eb00b0068d1859b1cbsi1149668qvk.512.2024.02.15.03.12.14 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 15 Feb 2024 03:12:14 -0800 (PST) Received-SPF: pass (google.com: domain of linux-wireless+bounces-3619-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=FSG0itI+; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-wireless+bounces-3619-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-wireless+bounces-3619-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id AD3441C213D0 for ; Thu, 15 Feb 2024 11:12:14 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 307BD12BE9A; Thu, 15 Feb 2024 11:10:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="FSG0itI+" X-Original-To: linux-wireless@vger.kernel.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0B57A12BE94 for ; Thu, 15 Feb 2024 11:10:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707995457; cv=none; b=NhFbVIZ5VNApdUmIwZFvh5utYnfoUT/RckNvJ2Y+OWGGt7vMk4EPlXJCuW2A49itX2VRh5qHACGODjAU7qfnAF+oSzHXD0egq7wCRZo/XF0mExwzf+D/hN0L2FX1xmNj+fGZ9ETkFo6OMaE5Dd5Efv0rYu+AMZUIpney0Cydo6o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707995457; c=relaxed/simple; bh=vVvUI0Zd5BkquX4DfUyJx8xggQrW0+sr8+FuAXyTVtc=; h=Content-Type:MIME-Version:Subject:From:In-Reply-To:References:To: Cc:Message-ID:Date; b=AO2vqzG6tscb+yMgr+3nrnGcGpE2XPBT0oy7uUMk5wcTGpUyGjrtTf5VhSENYpViPN7P1IYb7a6gxt2wMOy8AXP2puMcvhfcB6Q4XMcfOjNXb/DLW+dWKOsjpBbpAtj7E+CDGP7InPqZtNY02LZRZ/Ux7vI9azQ9/GzYwqcep7w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=FSG0itI+; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8B0FFC433F1; Thu, 15 Feb 2024 11:10:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1707995456; bh=vVvUI0Zd5BkquX4DfUyJx8xggQrW0+sr8+FuAXyTVtc=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=FSG0itI+g0zVM4tk8e1HYcxt9z6DrtEOoCIW+Lx5Pbh66W28Q83r6fKZkkuOHNdQr DlB342nbGdf/OfOlmGwGuZqK38LD5Zk457UaqIve6phQlNTv1QKxFzf9LdP3adbDre eh004HNR5hdK5JEtEqRuvXazd17VLsogA+JU//7fg55cwpV9gQxjGQKd7OsCkBnfE5 +Fb4blFoAtk2glDoFdMo2btTVHS6xyQ8tx1riXvdQWsuGU0c56z68Cbojzq10JG3MC fBeS2xAg+qFe11aXko7fVd6SiM5nidnBxz06R5EPEcNZ++a5RcKKdOUTwWMuKKyBR4 ieqPzpWqClrmw== Content-Type: text/plain; charset="utf-8" Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH] wifi: rtlwifi: rtl8192cu: Fix 2T2R chip type detection From: Kalle Valo In-Reply-To: References: To: Bitterblue Smith Cc: "linux-wireless@vger.kernel.org" , Ping-Ke Shih , Larry Finger User-Agent: pwcli/0.1.1-git (https://github.com/kvalo/pwcli/) Python/3.11.2 Message-ID: <170799545341.3764215.16526652466064365914.kvalo@kernel.org> Date: Thu, 15 Feb 2024 11:10:55 +0000 (UTC) Bitterblue Smith wrote: > rtl8192cu handles 1T1R devices (RTL8188CUS), 1T2R devices (RTL8191CU), > and 2T2R devices (RTL8192CU). The 2T2R devices were incorrectly detected > as 1T2R because of a mistake in the IS_92C_1T2R macro. > > The visible effect of this is that the firmware was allowed to use > TX rates only up to MCS7. > > Fix the IS_92C_1T2R macro. > > Now my 2T2R device has much better upload speed. > Before: 46 Mbps. > After: 82 Mbps. > > Also fix a debug message which was printing "RF_1T1R" even for 1T2R > chips. > > Signed-off-by: Bitterblue Smith > Acked-by: Ping-Ke Shih Patch applied to wireless-next.git, thanks. bcfcbf23a98c wifi: rtlwifi: rtl8192cu: Fix 2T2R chip type detection -- https://patchwork.kernel.org/project/linux-wireless/patch/ed960059-5c77-422d-ac4e-fe9fc9d0d296@gmail.com/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches