Received: by 2002:a05:7412:1e0b:b0:fc:a2b0:25d7 with SMTP id kr11csp382262rdb; Thu, 15 Feb 2024 03:12:44 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCX1JkUVf/2/gQBdv1krWxlXJDY5dRlOEjdIAW5W4DeXJdhUUzrUsT1aAhB9SOEhlrlvN1l/a6c4fKljsYc3WbxORf05jYhzMxI8ek7CIw== X-Google-Smtp-Source: AGHT+IGAP0NDhHnpKowo+mXdH4+8m+VwBZ9aMeAkoIic3xYiV3dmmYXS5dfo5JGOwLpTrYwW6Cfy X-Received: by 2002:a05:6402:165a:b0:560:ecd5:968b with SMTP id s26-20020a056402165a00b00560ecd5968bmr1140457edx.23.1707995564268; Thu, 15 Feb 2024 03:12:44 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707995564; cv=pass; d=google.com; s=arc-20160816; b=ZOjgtm4YXXeNw+/rsMyHkt/ZzkbJe99WVAOgsX1Ic5QLjQwlLqURXAwZKk6I/iRCzX 0GQufKGmg/V7QPCbyIDRiv5eh8gKAdHsqo4QrhxBA2+Jm0WvdMi3PeorJ5lRSQFCfBVe s1goC5CuiAmj+Ck2o/bJ1pvPv1rTYQaYunkhdFgYJIIH54nDpqQZGnf/vjKcNdlYmJQT O5es8NrExjvX/XmBL/NtKTIAQfffHr6UwseXnVcOXnkv4PM4UjVPsFFGTKLEj3AUH2t9 SuKFPoLGYSHa8SU/RmxbHMuZ9ZzXiAxQsOaTrLPKEX2s2TGmUuv1Pp/vmR0bhoygHRk9 Vz9w== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=date:message-id:user-agent:cc:to:references:in-reply-to:from :subject:content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:dkim-signature; bh=l1MToTR0ZyvZS9AEGOi2wP6BBvD/pClrpsORUPs6m6I=; fh=echNaZDQULNNSi2sXfVwRWMiSaNfBQmGHbG2Ey6K4J4=; b=v+akJbb7K/zY/758pMgeSE/HZrdqEkc0NbSgq0M28RORREV7a9peeLshWgun297Axm jHz9L0U1aDjcVexjF3MRUX/vrAQaNu6TBE7wZlkz56MnOLA3iE307n1DmG8BiqsQipBe 9FKQdEKGUqzZSL6k2FPhMf6PDt/3dmQVlwhM96PmwKHrS9uxDphsj0VVhXXIPgmc9iFm TrRkRlh0RgMcM0ODMWRdJ2iTojNcVsl43rWJHw5MIbshSYRiOSpiCfVBpir+CmEUt0T/ 2jLz1JvLvpRD9D9ieNlVgbOY/sX3HbnXR6LKaV01CWdQ8wizZjrZbReyWkMokLf+sjjL Bw1w==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=C7Y6O0Ah; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-wireless+bounces-3618-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-wireless+bounces-3618-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id f3-20020a05640214c300b00561a61e68e0si541444edx.482.2024.02.15.03.12.44 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 15 Feb 2024 03:12:44 -0800 (PST) Received-SPF: pass (google.com: domain of linux-wireless+bounces-3618-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=C7Y6O0Ah; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-wireless+bounces-3618-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-wireless+bounces-3618-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 61F531F2459E for ; Thu, 15 Feb 2024 11:11:54 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 6A48912AADB; Thu, 15 Feb 2024 11:10:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="C7Y6O0Ah" X-Original-To: linux-wireless@vger.kernel.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4682712A158 for ; Thu, 15 Feb 2024 11:10:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707995434; cv=none; b=nOna1tJRGn9N1maZstPm7+/j1+NVHiaJBt4vRdLAqtJfohT9sWuq26H+I92vvmTBhJkwHcZ5rp3c6BMNWBFy8lFzy9XAvjrBQJfm1e8fj0k6XLPgZ19k/RKJ/S34bHSsvQj9AH3uhqe+RgQ2WwqdQJGdrt4OF4wd5qauAaV0Mg4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707995434; c=relaxed/simple; bh=WpMTDRqyEN7ru0+HIT2xx9gX3gThsd4h1IPUldL/5fc=; h=Content-Type:MIME-Version:Subject:From:In-Reply-To:References:To: Cc:Message-ID:Date; b=I9GTnXC8seWHTtmJiYbYE9ByQxF5cKmGgeHj0vXbl3+aH6UpK1+aQwAKHlldU21y3aKcIqpfMOHfqpDdEiGkEkFkTrVOw5zQvuXIvsEq39VIRpYswEAkzySqcM+MXdfYvVo2sQ1qshvSNx/lCvrO5+Iniwu41dkMJy3aKoIpadc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=C7Y6O0Ah; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 139EDC433C7; Thu, 15 Feb 2024 11:10:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1707995433; bh=WpMTDRqyEN7ru0+HIT2xx9gX3gThsd4h1IPUldL/5fc=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=C7Y6O0AhdOMdy/ODIjS2FYJVaA03uo/EOJpcwFmOPJS+GQ/nbLag4a7MlKxrwfSoa bOyFmokURfw/peWVjhX/5Kmu8kPtgCHV/3KXihJUHro+1ASuO16g0JaZv/AoSMhlhg OaAkMOHJpz70gBwsMFIl+m1OUc1EFnOHfp/aWyGm2D75FQrFlQTNf0/K6sxqU1vLXu WQLln9MfcCBKaS5jmi5nxfSvPudPXZRtf8Sl+i3nDr76Mq3xyAGNQPIuf1+Fv7vKi4 TLSRvzlV7XcP9f/D244ZLuQ5FzqtcvZwVRK0U6v3KWcZI8c5c/1RnevNDIEXNI00F1 lRbnhMcNNDHXQ== Content-Type: text/plain; charset="utf-8" Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH] wifi: rtw89: fw: remove unnecessary rcu_read_unlock() for punctured From: Kalle Valo In-Reply-To: <20240213122556.9593-1-pkshih@realtek.com> References: <20240213122556.9593-1-pkshih@realtek.com> To: Ping-Ke Shih Cc: , User-Agent: pwcli/0.1.1-git (https://github.com/kvalo/pwcli/) Python/3.11.2 Message-ID: <170799543107.3764215.12527136024611017239.kvalo@kernel.org> Date: Thu, 15 Feb 2024 11:10:32 +0000 (UTC) Ping-Ke Shih wrote: > The rcu_read_unlock() is accidentally added, and sparse warn: > > drivers/net/wireless/realtek/rtw89/fw.c:2807:17: > warning: context imbalance in 'rtw89_fw_h2c_assoc_cmac_tbl_g7' - unexpected unlock > > Fixes: b82730bf57b5 ("wifi: cfg80211/mac80211: move puncturing into chandef") > Cc: Johannes Berg > Signed-off-by: Ping-Ke Shih Patch applied to wireless-next.git, thanks. 63d94f749623 wifi: rtw89: fw: remove unnecessary rcu_read_unlock() for punctured -- https://patchwork.kernel.org/project/linux-wireless/patch/20240213122556.9593-1-pkshih@realtek.com/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches