Received-SPF: pass (google.com: domain of linux-wireless+bounces-3692-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
From: Kalle Valo <kvalo@kernel.org>
To: Conor Dooley <conor@kernel.org>
Cc: Ajay.Kathat@microchip.com,  alexis.lothore@bootlin.com,
  davidm@egauge.net,  linux-wireless@vger.kernel.org,
  claudiu.beznea@tuxon.dev,  thomas.petazzoni@bootlin.com,
  linux-kernel@vger.kernel.org,  devicetree@vger.kernel.org
Subject: Re: [PATCH RFC] wifi: wilc1000: fix reset line assert/deassert
 polarity
References: <20240213-wilc_1000_reset_line-v1-1-e01da2b23fed@bootlin.com>
	<2ff1c701f3443e1c612a81f4077b0280850f57c6.camel@egauge.net>
	<081bce96-f485-414c-8051-e1c14271f8cc@bootlin.com>
	<aac398e4-d870-4ba2-8877-b98afecb8d1b@microchip.com>
	<877cj4o0sv.fsf@kernel.org>
	<20240216-reckless-freedom-4768ce41e939@spud>
	<20240216-spinster-decade-e136ac3e72d0@spud>
Date: Fri, 16 Feb 2024 20:07:58 +0200
In-Reply-To: <20240216-spinster-decade-e136ac3e72d0@spud> (Conor Dooley's
	message of "Fri, 16 Feb 2024 16:55:16 +0000")
Message-ID: <87h6i8cmf5.fsf@kernel.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux)
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain

Conor Dooley <conor@kernel.org> writes:

>> > So if I'm understanding the situation correctly Microchip's porting
>> > guide[1] doesn't match with kernel.org documentation[2]? I'm not the
>> > expert here but from my point of view the issue is clear: the code needs
>> > to follow kernel.org documentation[2], not external documentation.
>> 
>> My point of view would definitely be that drivers in the mainline kernel
>> absolutely should respect the ABI defined in the dt-binding. What a vendor
>> decides to do in their own tree I suppose is their problem, but I would
>> advocate that vendor kernels would also respect the ABI from mainline.
>> 
>> Looking a bit more closely at the porting guide, it contains other
>> properties that are not present in the dt-binding - undocumented
>> compatibles and a different enable gpio property for example.
>> I guess it (and the vendor version of the driver) never got updated when
>> wilc1000 supported landed in mainline?
>> 
>> > I'll add devicetree list so hopefully people there can comment also,
>> > full patch available in [3].
>> > 
>> > Alexis, if there are no more comments I'm in favor submitting the revert
>> > you mentioned.
>> 
>> From a dt-bindings point of view, the aforementioned revert seems
>> correct and would be
>> Acked-by: Conor Dooley <conor.dooley@microchip.com>
>
> Maybe an R-b is more suitable here, too used to acking trivial patches
> that are dt related..

On the contrary, I think Acked-by is the right thing here and makes it
easier for Alexis and me. Thanks!

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches