Received-SPF: pass (google.com: domain of linux-wireless+bounces-3728-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <7658242ceef838cc553cb3bbb63ede20d1bf9cb5.camel@perches.com>
Subject: broadcom: brcmfmac, alloc without null test
From: Joe Perches <joe@perches.com>
To: Arend van Spriel <arend.vanspriel@broadcom.com>
Cc: Kalle Valo <kvalo@kernel.org>, linux-wireless@vger.kernel.org, 
	brcm80211@lists.linux.dev, brcm80211-dev-list.pdl@broadcom.com, LKML
	 <linux-kernel@vger.kernel.org>
Date: Sat, 17 Feb 2024 11:40:06 -0800
Content-Type: text/plain; charset="ISO-8859-1"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.48.4 (3.48.4-1.fc38) 
Precedence: bulk
MIME-Version: 1.0

There's a missing NULL alloc test here:

It doesn't appear obvious what a proper fix is.

diff -u -p ./drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c /t=
mp/nothing/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c
--- ./drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c
+++ /tmp/nothing/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.=
c
@@ -4308,7 +4308,6 @@ brcmf_pmksa_v3_op(struct brcmf_if *ifp,
 	int ret;
=20
 	pmk_op =3D kzalloc(sizeof(*pmk_op), GFP_KERNEL);
-	pmk_op->version =3D cpu_to_le16(BRCMF_PMKSA_VER_3);
=20
 	if (!pmksa) {
 		/* Flush operation, operate on entire list */