Received-SPF: pass (google.com: domain of linux-wireless+bounces-3779-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Sender: Larry Finger <larry.finger@gmail.com>
Message-ID: <99fc641f-f73a-4fa6-b3c1-1c19ac697602@lwfinger.net>
Date: Mon, 19 Feb 2024 09:40:43 -0600
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: rtw88 driver support for rtl8723ds does not work on Radxa
 RockPi-S
Content-Language: en-US
To: Kalle Valo <kvalo@kernel.org>, Brent Roman <brent@mbari.org>
Cc: linux-wireless@vger.kernel.org, martin.blumenstingl@googlemail.com
References: <9f47e65e-35f1-b090-cad1-4d8333293b00@mbari.org>
 <9f7c6005-e9c5-4691-87c2-fee8641f02a4@lwfinger.net>
 <f8d31d74-fdfe-8706-6748-273b8c3674ca@mbari.org>
 <b9a4df4e-4b1f-436f-ae4b-90fc0c68ae81@lwfinger.net>
 <878r3hc6hy.fsf@kernel.org> <42772df2-32b3-2b37-045d-b528a752bef7@mbari.org>
 <874je4dfoy.fsf@kernel.org>
From: Larry Finger <Larry.Finger@lwfinger.net>
In-Reply-To: <874je4dfoy.fsf@kernel.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

On 2/19/24 02:24, Kalle Valo wrote:
> Brent Roman <brent@mbari.org> writes:
> 
>> Yes, that's all true.  However... Random MAC address assignment tends
>> to cause devices to be assigned a different IP address on each reboot.
>> This often doesn't play nicely with port forwarding.
> 
> Sure, I wasn't claiming that using random addresses is the perfect
> solution. But you could also set a fixed random address from user space
> (hopefully that works with rtw88).

That will require a new module parameter, which the community does not want.
> 
>> It's difficult to "prove" the RK3308 cpu serial numbers are unique,
>> but they should be and the few I've tested have been.
> 
> Please take into account that rtw88 driver can be used with all sort of
> different CPUs, not just RK3308. This is why I pointed this out.

We should be able to modify the code to handle a number of CPUs. They all should 
have a unique identifier. On my 2 Intel-based systems, there is no CPU serial 
number, but there is a serial number attached to the system, In addition, this 
code will only be invoked if the MAC address in the EUSE is invalid.

Larry