Received: by 2002:a05:7412:cfc7:b0:fc:a2b0:25d7 with SMTP id by7csp1224370rdb; Mon, 19 Feb 2024 08:05:45 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCVr/IElMQLIxzAyNlEQK/mcW1U+/mhD4SyS7vhnww8gnbe18FG3H0tv3uFHI1D1Q5lYP85oqPUbb3SbFnPJVZabXk1ILkQnhWvEDPoSTA== X-Google-Smtp-Source: AGHT+IHcqU7QsXLLJC/FF1jDyjqtiWLvwwOGCM5YfUjelMzyoubclF2+WMOE5lc4jBs7lmmj8gT6 X-Received: by 2002:a05:6512:251:b0:512:aa71:5def with SMTP id b17-20020a056512025100b00512aa715defmr2882911lfo.28.1708358745276; Mon, 19 Feb 2024 08:05:45 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708358745; cv=pass; d=google.com; s=arc-20160816; b=GTXhf+OvjAr9QJ85HXYq+JkBrVUUk6iirSGmTBoyq+bjm0GMA1BOaOst9PsNTUzuCJ 1r8mUaBUncQCQiT0hLcda8n41+U/ZQd21KP2glAbqbh0nK9OP8TlHqqizlHe672DJq38 RnGtxSIXviiQCNG5+5E37nAH+BFZh0oIO93B1ZS/JaGYnpLwX3QFvkYuz1n3VlPDn99P Qw4NYu/Uk7Yccr6mzCYfxsRxQoXBJxJEBxN1EnnWTqA4TKS8eF5y1/J0AWp0/cURPGcH ReHVxu9TxoDSk7Dt+FJPDKywefBM7yH1a5DCn21/LT52Y0apTr37Okg/IL5IA1eDdc6K 9IZA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=date:message-id:user-agent:cc:to:references:in-reply-to:from :subject:content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:dkim-signature; bh=QSatHODEjOs1xbcuMjcK8+pysXEQAWb+LFSukfOuM/Q=; fh=Thr7J8k3tjIyJRstG+6jZ5wdPOgdv9hlyot/w873RWc=; b=iSBNYmO7ahtzZMirbsN2Wcm7sLOdCPcBPn9y08VtvdaJmmskjJXdpfg8asVksMsTCF 1kdgu4HJmdFmwLhrXALaZkj18Zwl6t4wFf9all+Qnsqw17OQOq0ybwSR9qjT5wXzTuOB Na2ga4eyCscrxFiv0MD/Nn2/8fA76C8Uy4JVYXCnXZLYQuYM2Z/8pUozD+lW24+0VH5S fNd91aD44IuMQccuHyxHVrwQzkycVlubcTWC1FaXEEGmFrq1470ddGBBEYfUFI816KKD zNWeI1kUO60esgAR7PX3k+rgczr8YJO/FPaw3gSUniQs9BVueXoUhYmpDr/ISrAb7EwQ Rn7g==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=tGb8TlHS; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-wireless+bounces-3781-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-wireless+bounces-3781-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id am11-20020a170906568b00b00a3e5ef27690si1636302ejc.637.2024.02.19.08.05.45 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Feb 2024 08:05:45 -0800 (PST) Received-SPF: pass (google.com: domain of linux-wireless+bounces-3781-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=tGb8TlHS; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-wireless+bounces-3781-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-wireless+bounces-3781-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id C1E351F21527 for ; Mon, 19 Feb 2024 16:05:44 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id A1FEF3D0A3; Mon, 19 Feb 2024 16:05:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="tGb8TlHS" X-Original-To: linux-wireless@vger.kernel.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7B4C53CF77 for ; Mon, 19 Feb 2024 16:05:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708358727; cv=none; b=EbI1yvMB35nqikvvbbmvgQoINAFnUzqf7egVD8cAcFy5tn9IFstethxUbNQmQtHm/shPsCHH6dN1xbB+4D2xgs7s0Ov/ZgRdQzbg+asx+ZlpiGjuM7LHu0etHimuMK3PBBrqcvgnUueJNM60EPKJTUD23HC1xeZLh0uHddSDGDo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708358727; c=relaxed/simple; bh=6Agzb6Z44o7P580xh6nn/qd3jkzQ0h5pyxtnuYKGtew=; h=Content-Type:MIME-Version:Subject:From:In-Reply-To:References:To: Cc:Message-ID:Date; b=oo7w0g+jdadw+g/RHCQ5T0i6FK6OE0bxJyvT5igmGFFhDXZjZ/YEJ0RVsizidWjqdDxWn6Dw/HNY7Wlp2ACVkiNyhGgp7PezvoevmmdOrwTLS5jOxKv2VMcT4Luydrr6do4qAP6JVfMbbHyIlBHoCOnhdk9QaWVliGKvDQyPjck= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=tGb8TlHS; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3DAC2C43390; Mon, 19 Feb 2024 16:05:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1708358727; bh=6Agzb6Z44o7P580xh6nn/qd3jkzQ0h5pyxtnuYKGtew=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=tGb8TlHSlYxjmvzEHIgskmwWhPy/GpOb5bH3MuWuYNO4NX0RdxclnR+JsUTZmdX4p K/nJpCtsZ7RYwLCWdux9AY+kM4vWwy8iFEu7/LhMcPjJdwNgVJAe4Wnca7t6zUPT9v lNlnviqwO1eWHZ72GtsMzXqLIAjckisxPCjuwvsJ7tLnHz792E2Z3GRplhNDqNVFSe KRsoQz+Kxz0I01k5JFaqAZsm8EpeJRB55Q2Dnf4Agy1KyRkJGThavBlRPf8EcVbiI+ iervVDdIWb1a5WZ9ZrE/GEUQSrGYsVngPkzHNUKaMb6z/YTUy8KQJgyOO8M0H0ApLe nb4XYj0DfFGpw== Content-Type: text/plain; charset="utf-8" Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH] [v2] wifi: wilc1000: simplify and cleanup TX paths From: Kalle Valo In-Reply-To: <20230717084400.57882-1-dmantipov@yandex.ru> References: <20230717084400.57882-1-dmantipov@yandex.ru> To: Dmitry Antipov Cc: Ajay.Kathat@microchip.com, Amisha.Patel@microchip.com, linux-wireless@vger.kernel.org, Dmitry Antipov User-Agent: pwcli/0.1.1-git (https://github.com/kvalo/pwcli/) Python/3.11.2 Message-ID: <170835872423.848163.11512257935917209592.kvalo@kernel.org> Date: Mon, 19 Feb 2024 16:05:26 +0000 (UTC) Dmitry Antipov wrote: > Redesign 'struct txq_entry_t' to avoid callback functions and > replace 'wilc_wfi_mgmt_tx_complete()/mgmt_tx_complete()' with > 'wilc_tx_complete()' which operates on 'struct txq_entry_t' > directly. Drop callback-specific 'struct wilc_p2p_mgmt_data', > 'struct tx_complete_mon_data' and 'struct tx_complete_data' > with related 'kmalloc()/kfree()' calls, adjust related code. > > Signed-off-by: Dmitry Antipov This needs testing on real device before I would dare to take it. Patch set to Changes Requested. -- https://patchwork.kernel.org/project/linux-wireless/patch/20230717084400.57882-1-dmantipov@yandex.ru/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches