Received-SPF: pass (google.com: domain of linux-wireless+bounces-3792-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
From: andy.shevchenko@gmail.com
Date: Mon, 19 Feb 2024 20:25:05 +0200
To: Alexey Berezhok <a@bayrepo.ru>
Cc: Arend van Spriel <aspriel@gmail.com>, Kalle Valo <kvalo@kernel.org>,
	linux-wireless@vger.kernel.org, lvc-project@linuxtesting.org
Subject: Re: [PATCH] wifi: brcmfmac: do not cast hidden SSID attribute value
 to boolean
Message-ID: <ZdOdARuxnN5B0zdS@surfacebook.localdomain>
References: <20240208085121.2430-1-a@bayrepo.ru>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240208085121.2430-1-a@bayrepo.ru>

Thu, Feb 08, 2024 at 11:51:21AM +0300, Alexey Berezhok kirjoitti:

...

> -				 settings->hidden_ssid ?
> +				 (settings->hidden_ssid != NL80211_HIDDEN_SSID_NOT_IN_USE) ?
>  				 "enabled" : "disabled",

Can somebody switch this to use str_enabled_disabled() from string_choices.h?
Ideally, add str_disabled_enabled() in that header (as macro with negation on
its argument) and use here as

	str_disabled_enabled(settings->hidden_ssid == NL80211_HIDDEN_SSID_NOT_IN_USE)

-- 
With Best Regards,
Andy Shevchenko