Received-SPF: pass (google.com: domain of linux-wireless+bounces-3879-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Content-Type: text/plain; charset="utf-8"
Precedence: bulk
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: Re: [PATCH v2] wifi: rtlwifi: rtl8192cu: Fix TX aggregation
From: Kalle Valo <kvalo@kernel.org>
In-Reply-To: <4e936334-5f81-403f-a495-0628ebfb6903@gmail.com>
References: <4e936334-5f81-403f-a495-0628ebfb6903@gmail.com>
To: Bitterblue Smith <rtl8821cerfe2@gmail.com>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
 Ping-Ke Shih <pkshih@realtek.com>, Larry Finger <Larry.Finger@lwfinger.net>
User-Agent: pwcli/0.1.1-git (https://github.com/kvalo/pwcli/) Python/3.11.2
Message-ID: <170854170880.1918455.13905629998790956767.kvalo@kernel.org>
Date: Wed, 21 Feb 2024 18:55:10 +0000 (UTC)

Bitterblue Smith <rtl8821cerfe2@gmail.com> wrote:

> rtl8192cu is checking rtl_mac.tids when deciding if it should enable
> aggregation. This is wrong because rtl_mac.tids is not initialised
> anywhere. Check rtl_sta_info.tids instead, which is initialised.
> 
> Also, when enabling aggregation also enable RTS. The vendor driver does
> this, my router does this. It seems like the thing to do.
> 
> Also also, it seems right to set the AMPDU density only when enabling
> aggregation.
> 
> Also also also, delete the unused member rtl_mac.tids and the unused
> macros RTL_AGG_ON and RTL_AGG_OFF.
> 
> Naturally, with working AMPDU the download/upload speeds are better.
> Before: 59/32 Mbps.
> After:  68/46 Mbps.
> 
> Signed-off-by: Bitterblue Smith <rtl8821cerfe2@gmail.com>
> Acked-by: Ping-Ke Shih <pkshih@realtek.com>

Patch applied to wireless-next.git, thanks.

8ca4cdef9329 wifi: rtlwifi: rtl8192cu: Fix TX aggregation

-- 
https://patchwork.kernel.org/project/linux-wireless/patch/4e936334-5f81-403f-a495-0628ebfb6903@gmail.com/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches