Received: by 2002:a05:7412:cfc7:b0:fc:a2b0:25d7 with SMTP id by7csp2546830rdb; Wed, 21 Feb 2024 10:56:36 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCXVpaov6CE5cP1m6yDGe+AXm40s9Kj+2FpZlE5hgPNgR9yvU7e7kHWFuX9thKlzZ6Ycr6vC0UUpBYp0yQqEw74CK5yOdxMyBYttXzrV3A== X-Google-Smtp-Source: AGHT+IGabAmlRugf3AGZycjYnvYzUa9iIt9Wcg1IeLzaYuNM94tsDSsbTiVqpwei+wK2CZAcvRUC X-Received: by 2002:a25:8891:0:b0:dc2:5553:ca12 with SMTP id d17-20020a258891000000b00dc25553ca12mr168249ybl.14.1708541796043; Wed, 21 Feb 2024 10:56:36 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708541796; cv=pass; d=google.com; s=arc-20160816; b=sEkTKIK5WK/lZ+OoNyTq2f4Ho7QfwDZVxLtZHjT7DLb9Yxfxu+YisNyaqP5hDGDxst DRwtxuk6PUEO+qYxKL5A61SQapgD+xa+xJcHyiroWQp1XrV5vI3nGIgnUAa8Jim59Tls 10zjRFv4ZxatnVJp9RgG2dbuhpV6buUl6j8LYcXcu7x5UZK6TvtDp623r4TK83AtDnmZ iZz+steThPi+UuyDSbKpHW8KVOpF1zp2hvPKc4kTyTfolRFk/0kKUD9wNq5NR0MxhcS+ WqTSstt6eorcMYoFRNHYy1MsgWATprZ8kHLF8wWJXyZgMhUdPyCvTYITX+tvnLkEvYHp AYkg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=date:message-id:user-agent:cc:to:references:in-reply-to:from :subject:content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:dkim-signature; bh=bJniAfXlubqPvEfCr8c8wbZ36z6dak6qPdyvLRDKYaY=; fh=4N+DhwqGiq2ZT3H/YRS4hs6TtODVCPoqqOnmzeEUaLg=; b=T51Ie0/HRjNpnPFmOg1rYKsCHHY8bQrthuS+hC10NYQRY6UjX50Cf22p+RI9uXxfwN KgwPXxztbqYq3slby1TcKEs/cAMN0TwJC3xH22d+l8mr7OktzczP8Iyf+lzwUcI6aWDl Uy54BfB60iAnUQnzKQlyFaUJkz/IwMWe0gTUwjxBVYVeleyTei9jzpx86n7tjrtYpZqp tKKLJTRJ1ZpK3hbuJObwcZKrIxuolLQZUtqrRNdh6vx35oZxMF+bcP7sHatg+Rx8mPHH ILkLgcxUOF265gtfnrf3oqVAj5Yl4z4BdiTA6PQN24ni56rYoszCCr280OJscXS+/FQt B0bw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=F1qWlOmM; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-wireless+bounces-3881-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-wireless+bounces-3881-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id x2-20020a05620a448200b00787425c6221si13058113qkp.377.2024.02.21.10.56.35 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 21 Feb 2024 10:56:36 -0800 (PST) Received-SPF: pass (google.com: domain of linux-wireless+bounces-3881-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=F1qWlOmM; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-wireless+bounces-3881-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-wireless+bounces-3881-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id F03771C2522D for ; Wed, 21 Feb 2024 18:56:02 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 9B4AA85642; Wed, 21 Feb 2024 18:55:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="F1qWlOmM" X-Original-To: linux-wireless@vger.kernel.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 783A385628 for ; Wed, 21 Feb 2024 18:55:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708541759; cv=none; b=owWLvQ5nDXKZqQHsVQNn5ccQItSWRmm0nNWgfvEOYm4rPi9GNs9SEYIKTXfm2JgkMpMkIKCN6kEv2jly+3lVYP1rtyUjI2rZI1fQxoA4fSpm0JgA887mDxRAtUK4Up2Vy9TLFtZZ1BST1uiWRyifagvCWt8vlmsvbSd8l3+QWdk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708541759; c=relaxed/simple; bh=ULOSVrAoDBAPPFICGwRJfwCBY7H7dZeBb1SpHOgGcrE=; h=Content-Type:MIME-Version:Subject:From:In-Reply-To:References:To: Cc:Message-ID:Date; b=qkugj6NgRiaR6MN/vqRocddc7Jb4dm6JgAmW15xdI2QER+mWX6BcLcT96pOg1GN9WsbQ5WnCK/OClrVLraal40i1oFBwCIKqJt4p643WSAXP6Evod9ufbbYFJZ8RH5wrLIQxhxMbQx15Qjqa97ssd5QybAt3hw+a3PfWlQUjLoc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=F1qWlOmM; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6BA0CC433C7; Wed, 21 Feb 2024 18:55:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1708541759; bh=ULOSVrAoDBAPPFICGwRJfwCBY7H7dZeBb1SpHOgGcrE=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=F1qWlOmMX3i5pSKM8RaNrDAnoxnhc5QGAwcs1d0TkvQj6/3p5Vu93/0+vDGH+7PgF ocA5bjSHfW1hMsH3GTarTI7TGp+LJwcr0l5YyMIVfKqxlu0TB2fabxB55P0EDZfT3X QfddDytf5trMoQg0W2wHEoU5UXR4jgYqDTDWNPOFsBPUBZCJuOM2eGpRDkx+H+D6jo V1++3wOqTAVZaBNK8gqu9MmepPtKh2+Lv45ScdRSKbA8bvWie99WMESjR2LDt8hUqu ZxKdqWdQLuuY1D6brrQDrafoTencn2slcxpggw+AoQm+/1sTdUPKIhFAA+bGPlb+JK izHLXyPW9uscQ== Content-Type: text/plain; charset="utf-8" Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH] wifi: rtlwifi: set initial values for unexpected cases of USB endpoint priority From: Kalle Valo In-Reply-To: <20240216033949.34765-1-pkshih@realtek.com> References: <20240216033949.34765-1-pkshih@realtek.com> To: Ping-Ke Shih Cc: User-Agent: pwcli/0.1.1-git (https://github.com/kvalo/pwcli/) Python/3.11.2 Message-ID: <170854175641.1918455.1895081784487885318.kvalo@kernel.org> Date: Wed, 21 Feb 2024 18:55:58 +0000 (UTC) Ping-Ke Shih wrote: > Map USB endpoints to hardware and AC queues according to number of USB > endpoints. However, original only give a warning for unexpected cases but > initial values are not given. Then, smatch warns: > > drivers/net/wireless/realtek/rtlwifi/rtl8192cu/hw.c:642 > _rtl92cu_init_chipn_two_out_ep_priority() error: uninitialized symbol 'valuelow'. > drivers/net/wireless/realtek/rtlwifi/rtl8192cu/hw.c:644 > _rtl92cu_init_chipn_two_out_ep_priority() error: uninitialized symbol 'valuehi'. > drivers/net/wireless/realtek/rtlwifi/rtl8192cu/hw.c:649 > _rtl92cu_init_chipn_two_out_ep_priority() error: uninitialized symbol 'valuehi'. > drivers/net/wireless/realtek/rtlwifi/rtl8192cu/hw.c:650 > _rtl92cu_init_chipn_two_out_ep_priority() error: uninitialized symbol 'valuelow'. > > The regular selection is high and low queues, so move default (unexpected) > case along with that. > > Compile tested only. > > Signed-off-by: Ping-Ke Shih Patch applied to wireless-next.git, thanks. 9208e85c6272 wifi: rtlwifi: set initial values for unexpected cases of USB endpoint priority -- https://patchwork.kernel.org/project/linux-wireless/patch/20240216033949.34765-1-pkshih@realtek.com/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches