Received: by 2002:a05:7412:cfc7:b0:fc:a2b0:25d7 with SMTP id by7csp2556802rdb; Wed, 21 Feb 2024 11:15:04 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCVotON6EEnphaeDoslLKH9bVoYe0DvDezvEeIj+ss0JVPeUgObRfYXGxRtg7sr7JGakEt3Bix70q7m1/0PZPI3SLT102uKNF0gjEN/G5w== X-Google-Smtp-Source: AGHT+IGzAKHJD+z7nG2US9ibe6ScBcitcHfeDQNIagz2YbndwiWLQ0/JuFEGra7L+jj7remmCgQe X-Received: by 2002:a17:90a:a58b:b0:299:4ac8:5710 with SMTP id b11-20020a17090aa58b00b002994ac85710mr561923pjq.17.1708542904532; Wed, 21 Feb 2024 11:15:04 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708542904; cv=pass; d=google.com; s=arc-20160816; b=NlVAUKnf6q19BITqqvWJMaIs7tXdRVnMZGpGicg9L1hxQABWL3pn+NJQzHJD6c9iBE xWwslz4WDwIXQdPZoDeuLyxeTKGzThO62n4vp4hraDxxnLH2a3oyfQzzjJ2Ru+I+Ht1n hId59BiaBUy6+JsiVOacrZor2/RXs4SOAhOwc4lRz1HKOd4WjXk+47A0S2uNd48fs1lR Er6LMJ5cVSzKW6adO6pwN5Jdi0nFaxMRsJCA3T6zwaTao5yx8o/HWiKGeilhY/A+Cqqx 82WRmHMkvQYwYVYsQ8b+CTCAAe0RAAYUKV1DoHmnZCJg8oWYG7Vtok6Kj2fgQYG2DN4J KjgQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=date:message-id:user-agent:cc:to:references:in-reply-to:from :subject:content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:dkim-signature; bh=GAjPsMnHBpiDVWSQ2LGpuBjb5ytVjdo+9ldTDbmKxOA=; fh=gWqSt3I3fdvz/nChxu/iIuNJzUKfXlhU0TezSmpDKaY=; b=z42MAEx8ayvb+EQDAnz6y5G+WpWrwR8h5tLHIWDzzl8MrTTRMmdLsZHBBt34AJ+G0e bwm9sQv+w+9K8mOJoL9lRqXiH914yKdtlRvJKxjNxnDiKjEJ9LRQqK+L3DwJLp6r4B4f NI1pKhORcUVy7oZnocsXJV3oLMDKHLqCGiv99IsZqLoloJ524UHZm8f4h9hzrpyPR/3v zccMKiqa8IdTmtGDxIq7LW1UTUDG9Q9PaH3YRJYd1guu5J1yj6MbJ7l8qqjGilink6gi 355hzyYIhuORIzdVYdrrx4X3umq3Lb/EHZmumWH1WvSYQEH6eAQfWWNagkkKTWQXkGzT snuw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="G/aRyUJu"; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-wireless+bounces-3880-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-wireless+bounces-3880-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [2604:1380:40f1:3f00::1]) by mx.google.com with ESMTPS id 4-20020a17090a098400b00298e649da8csi8761060pjo.135.2024.02.21.11.15.03 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 21 Feb 2024 11:15:04 -0800 (PST) Received-SPF: pass (google.com: domain of linux-wireless+bounces-3880-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="G/aRyUJu"; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-wireless+bounces-3880-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-wireless+bounces-3880-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id AE5DBB27B50 for ; Wed, 21 Feb 2024 18:55:44 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 172A985937; Wed, 21 Feb 2024 18:55:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="G/aRyUJu" X-Original-To: linux-wireless@vger.kernel.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E7A998592D for ; Wed, 21 Feb 2024 18:55:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708541736; cv=none; b=gcWfOhs/YQkQf7mjQJWXg1TukA0Nfc1X9dvTlnFwR32/z6IySlncUK+1bn8RVNl9XAH9XHR7+FhI2sBq8UZi+ptevkYr6P3IGAPW8RDQPpkyS9S7g8K6r3bAgfQI80sgEblRqghrhXAG0BugKrzCu4YjtSaD/ypVc9ayq1eIeSg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708541736; c=relaxed/simple; bh=rLWDmUCAx6EILc6f8XjazvNhWfCbGx8cvM4UHjC/Jf4=; h=Content-Type:MIME-Version:Subject:From:In-Reply-To:References:To: Cc:Message-ID:Date; b=i/o5g21GjYe8fonOV3gKkYdKZChHqrfRtr7/ozqJnO73Om+QQ2DbzCKay4UzSUqDIANJYTgnDZl/myQ3BD1PHa8WDK9WR57RwM9qvxrevYb28M/pHdYj28Lz80a/eLFi66iF9N2bJzAeeLQrNuw0DC57a9KTdBfTwIkf9id9tuw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=G/aRyUJu; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id A0F3AC433C7; Wed, 21 Feb 2024 18:55:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1708541735; bh=rLWDmUCAx6EILc6f8XjazvNhWfCbGx8cvM4UHjC/Jf4=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=G/aRyUJuE39cMCEZWPoqqSkM5Y2QfOJuJhnIfO9BjbKyeFqa2BzGhg6nkw09jFp/o Wfo7xIcXiqkRzmpZi/TefV21tKdCdN35Anmn02n1QKgrrm7VoCmEpeTPtsSWBqCRo9 kLKKzu0aCKhkUhgVvUZKdKDZakeJDvbZ0PL42vVtZavhwvWt5xSuaUTGYFKKD2y6cY BaeC01baatzdJZS3x965olErrqzy14bAxKmlDe/yncjk6D1/n5xfbEuUnE8dDS0HrE TSeyB9RsTOgjOWbrGBMyY8Xt0SfpmDp93xVPq8WtfR2W1O2d+Tv9eD9lQ5LVV9kJWg ljJ0WW2/kTpYA== Content-Type: text/plain; charset="utf-8" Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH] wifi: rtl8xxxu: check vif before using in rtl8xxxu_tx() From: Kalle Valo In-Reply-To: <20240216033923.34683-1-pkshih@realtek.com> References: <20240216033923.34683-1-pkshih@realtek.com> To: Ping-Ke Shih Cc: , User-Agent: pwcli/0.1.1-git (https://github.com/kvalo/pwcli/) Python/3.11.2 Message-ID: <170854173243.1918455.9065659857855467612.kvalo@kernel.org> Date: Wed, 21 Feb 2024 18:55:34 +0000 (UTC) Ping-Ke Shih wrote: > The 'vif' is from tx_info of SKB, and other codes check 'vif' before using, > which raises smatch warnings: > > drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c:5656 rtl8xxxu_tx() > warn: variable dereferenced before check 'vif' (see line 5553) > > Compile tested only. > > Signed-off-by: Ping-Ke Shih Patch applied to wireless-next.git, thanks. 513c559ca9f0 wifi: rtl8xxxu: check vif before using in rtl8xxxu_tx() -- https://patchwork.kernel.org/project/linux-wireless/patch/20240216033923.34683-1-pkshih@realtek.com/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches