Received-SPF: pass (google.com: domain of linux-wireless+bounces-3888-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <b25a5783-a9ca-4356-ae17-bbda1340b522@quicinc.com>
Date: Wed, 21 Feb 2024 17:18:41 -0800
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: pull-request: wireless-next-2024-02-20
Content-Language: en-US
From: Jeff Johnson <quic_jjohnson@quicinc.com>
To: Jakub Kicinski <kuba@kernel.org>, Kalle Valo <kvalo@kernel.org>,
        Karthikeyan Periyasamy <quic_periyasa@quicinc.com>
CC: <netdev@vger.kernel.org>, <linux-wireless@vger.kernel.org>
References: <20240220165842.917CDC433F1@smtp.kernel.org>
 <20240221143531.56942c6e@kernel.org>
 <2dbb3ca4-78fd-4125-b13f-4ad440923291@quicinc.com>
In-Reply-To: <2dbb3ca4-78fd-4125-b13f-4ad440923291@quicinc.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit

On 2/21/2024 3:34 PM, Jeff Johnson wrote:
> On 2/21/2024 2:35 PM, Jakub Kicinski wrote:
>> On Tue, 20 Feb 2024 16:58:42 +0000 (UTC) Kalle Valo wrote:
>>> Hi,
>>>
>>> here's a pull request to net-next tree, more info below. Please let me know if
>>> there are any problems.
>>>
>>> Kalle
>>>
>>> The following changes since commit b7198383ef2debe748118996f627452281cf27d7:
>>>
>>>   wifi: iwlwifi: mvm: fix a crash when we run out of stations (2024-02-08 14:55:39 +0100)
>>>
>>> are available in the Git repository at:
>>>
>>>   git://git.kernel.org/pub/scm/linux/kernel/git/wireless/wireless-next.git tags/wireless-next-2024-02-20
>>>
>>> for you to fetch changes up to dd66185c23f71af36397bebfc99ede608dca07b6:
>>>
>>>   wifi: wilc1000: add missing read critical sections around vif list traversal (2024-02-19 18:21:36 +0200)
>>>
>>> ----------------------------------------------------------------
>>> wireless-next patches for v6.9
>>>
>>> The second "new features" pull request for v6.9.  Lots of iwlwifi and
>>> stack changes this time. And naturally smaller changes to other drivers.
>>>
>>> We also twice merged wireless into wireless-next to avoid conflicts
>>> between the trees.
>>>
>>> Major changes:
>>>
>>> stack
>>>
>>> * mac80211: negotiated TTLM request support
>>>
>>> * SPP A-MSDU support
>>>
>>> * mac80211: wider bandwidth OFDMA config support
>>>
>>> iwlwifi
>>>
>>> * kunit tests
>>>
>>> * bump FW API to 89 for AX/BZ/SC devices
>>>
>>> * enable SPP A-MSDUs
>>>
>>> * support for new devices
>>>
>>> ath12k
>>>
>>> * refactoring in preparation for Multi-Link Operation (MLO) support
>>>
>>> * 1024 Block Ack window size support
>>>
>>> * provide firmware wmi logs via a trace event
>>>
>>> ath11k
>>>
>>> * 36 bit DMA mask support
>>>
>>> * support 6 GHz station power modes: Low Power Indoor (LPI), Standard
>>>   Power) SP and Very Low Power (VLP)
>>>
>>> rtl8xxxu
>>>
>>> * TP-Link TL-WN823N V2 support
>>
>> I'm getting these on a normal (i.e. non-W=1) clang build today:
>>
>> ../drivers/net/wireless/ath/ath12k/mac.c:8000:9: warning: variable 'ret' is uninitialized when used here [-Wuninitialized]
>>  8000 |         return ret;
>>       |                ^~~
>> ../drivers/net/wireless/ath/ath12k/mac.c:7962:9: note: initialize the variable 'ret' to silence this warning
>>  7962 |         int ret, i, j;
>>       |                ^
>>       |                 = 0
>>
> 
> definitely a flaw in 6db6e70a17f6 ("wifi: ath12k: Introduce the
> container for mac80211 hw")
> 
> my setup is using gcc which isn't flagging this :(
> 
> Karthikeyan, can you submit a patch?
> 
> /jeff
> 

I see this was already fixed by:
04edb5dc68f4 ("wifi: ath12k: Fix uninitialized use of ret in
ath12k_mac_allocate()")