Received-SPF: pass (google.com: domain of linux-wireless+bounces-3893-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
From: Kalle Valo <kvalo@kernel.org>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Jeff Johnson <quic_jjohnson@quicinc.com>,  Karthikeyan Periyasamy
 <quic_periyasa@quicinc.com>,  <netdev@vger.kernel.org>,
  <linux-wireless@vger.kernel.org>
Subject: Re: pull-request: wireless-next-2024-02-20
References: <20240220165842.917CDC433F1@smtp.kernel.org>
	<20240221143531.56942c6e@kernel.org>
	<2dbb3ca4-78fd-4125-b13f-4ad440923291@quicinc.com>
	<b25a5783-a9ca-4356-ae17-bbda1340b522@quicinc.com>
	<20240221172521.4dcb382c@kernel.org>
Date: Thu, 22 Feb 2024 07:11:25 +0200
In-Reply-To: <20240221172521.4dcb382c@kernel.org> (Jakub Kicinski's message of
	"Wed, 21 Feb 2024 17:25:21 -0800")
Message-ID: <875xyhaxs2.fsf@kernel.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux)
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain

Jakub Kicinski <kuba@kernel.org> writes:

> On Wed, 21 Feb 2024 17:18:41 -0800 Jeff Johnson wrote:
>> > definitely a flaw in 6db6e70a17f6 ("wifi: ath12k: Introduce the
>> > container for mac80211 hw")
>> > 
>> > my setup is using gcc which isn't flagging this :(
>> > 
>> > Karthikeyan, can you submit a patch?
>>
>> I see this was already fixed by:
>> 04edb5dc68f4 ("wifi: ath12k: Fix uninitialized use of ret in
>> ath12k_mac_allocate()")
>
> In wireless-next? Could you do a quick follow up PR so that
> it gets into net-next before the warning propagates into more
> of the networking sub-trees?

The fix is in ath-next but I'll pull ath-next into wireless-next and
then send a wireless-next pull request. So you should have the pull
request in few hours.

Sorry about this, I somehow understood this was a W=1 warning and didn't
prioritise the fix. After re-reading the commit message I can't
understand why I made that assumption, my bad.

What worries me is that the kbuild bot didn't warn this at all (or I
missed that as well). Is it using older clang version or what?

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches