Received: by 2002:a05:7208:9594:b0:7e:5202:c8b4 with SMTP id gs20csp850532rbb; Sun, 25 Feb 2024 06:55:34 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCUOTr3XWD9FGr1ZwrJd6p6qMiBQBO7MoteNBk1J5BBACN00rkKhwhLDDLxBDOyTOW13dFjxCnTiNbJCYvW+AswSqOh1C7QB9SblgtRLhQ== X-Google-Smtp-Source: AGHT+IHoYw/GkmF/sDLWoAbQMEz0byvBv6QoaiBvnb1zYqfmNw+4z4ytHBco3q4evS4KAI5oDW+9 X-Received: by 2002:a05:620a:2717:b0:787:d276:ee3f with SMTP id b23-20020a05620a271700b00787d276ee3fmr641497qkp.37.1708872934655; Sun, 25 Feb 2024 06:55:34 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708872934; cv=pass; d=google.com; s=arc-20160816; b=A79nHfYMW+2EKRItHCBSa3NVjfc/UTW340QCKiu6DUC8hvkRaclEaBKYD4n8TY6fcs CIh9hhrNPjGy6JqZho/ZbhJtN+XQTRSPZtPE1NLG0qC/7Kes24TpQSuEsOEjjfECVZqo CtZsYF4eJd3m5zC6ngUlw5KHL7GQrOw0dWHVr2/NjyRXSluPwDsCbtSu1BaYBkpCALIX U9EPRJL5TaX4MBIlIwkGJqQQCiL2n4UDqFcIxuGap0OXarjQdROIf2LLUKJA52NzNnVC Oxn5udqFk96JlL9jxTfoBQ60YLPZl1Z+E+eK9ehD5Q51fWDK7t/rkrqWuBTE75e3c2e4 Mrxg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:date:message-id:dkim-signature; bh=Uc0wMqLN4cXLorwtjxl+1hxzQu0VmHmGBOY2K5ZtoN0=; fh=lz5AZLFA1xmGG0sY4BzvKVyT0YELHPhynlvBaRbFGUE=; b=GheOFyIYs3xmbgw3NiExHgC5wItK4xrn4f0NJfx8QkwAwvjwU4KITaN4BgBoQc88sp n9dSpHKlhI7ODsfmn1WYfZ8I0xiqLHpkann3pwO5VEqDpw+Y2kxkXDW/GjtFVHQq8Nv5 VEKgCQ0lMOZyhwQyBZjMQzHIn3r8EqWeZPZ0bF1+8h6gnS5AqdAmR316nKDywCo8uyFW 6ws0xsAEtlIAtnn2L6h4aBWYJ3VZOeIrxZgxTB09o/4n0h6WRNqhy4YWUc/cJ9ysWqTq ib9Nr4OW2cYHkfdrLBTGkHsYILLR1dXYK9mIWjpjF+oO1c/u5CIE6YthZpeqOB/Lktng mWSA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=cHKz66FI; arc=pass (i=1 spf=pass spfdomain=quicinc.com dkim=pass dkdomain=quicinc.com dmarc=pass fromdomain=quicinc.com); spf=pass (google.com: domain of linux-wireless+bounces-3982-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-wireless+bounces-3982-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id h12-20020a37c44c000000b00787ba29c6e4si3013622qkm.718.2024.02.25.06.55.34 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 25 Feb 2024 06:55:34 -0800 (PST) Received-SPF: pass (google.com: domain of linux-wireless+bounces-3982-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=cHKz66FI; arc=pass (i=1 spf=pass spfdomain=quicinc.com dkim=pass dkdomain=quicinc.com dmarc=pass fromdomain=quicinc.com); spf=pass (google.com: domain of linux-wireless+bounces-3982-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-wireless+bounces-3982-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 685D01C20947 for ; Sun, 25 Feb 2024 14:55:34 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 941CE12B87; Sun, 25 Feb 2024 14:55:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b="cHKz66FI" X-Original-To: linux-wireless@vger.kernel.org Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F3FD4748D for ; Sun, 25 Feb 2024 14:55:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708872931; cv=none; b=dFCYIXqnaaoYLF+sDFeZVDjaHlm5FcdtzBaqmivws5Y5CY/wHe4LIGtJ3SfNKS6d9fyVNUoaV/0KKKINXtKf+7zu7JH7AmMCxoiIh12p2xZB0VrXgGWhvWPevlIUnXXdHpFT8uQg6oz2/unRzH5azJ5IXismeMXjCeon4OzvF80= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708872931; c=relaxed/simple; bh=tjP0ICjqR0BpQ4MRsnX5MSItzJMdzPy407ciHwk5D8I=; h=Message-ID:Date:MIME-Version:Subject:To:CC:References:From: In-Reply-To:Content-Type; b=DQmMwlIQuQ+itGjoylSdor7H3/BPTlhfRT5DWJgoNZHDay2mlkzZOQQ6XYLI+iELYfA2s/YOFYjG/21fTHQVjcOGrlg196O5E38qDrXg+SXCiGOUKy9wR8V5e/2sse9KYtVpdBvYtY6wNwfig1fj96Ps6gAqtnHnYUejly6P9mY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com; spf=pass smtp.mailfrom=quicinc.com; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b=cHKz66FI; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=quicinc.com Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.24/8.17.1.24) with ESMTP id 41PEVbZ7029290; Sun, 25 Feb 2024 14:34:29 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h= message-id:date:mime-version:subject:to:cc:references:from :in-reply-to:content-type:content-transfer-encoding; s= qcppdkim1; bh=Uc0wMqLN4cXLorwtjxl+1hxzQu0VmHmGBOY2K5ZtoN0=; b=cH Kz66FIp7BAgYNGp1w59++Gg0jxz1pf1jAh12UzYvC6Ta6i0uM5rR6d1ARVUDm3bl Kf16kbI8qp8FuS+Qv2Q7fbgR+LahezI4Dt+Lfd/AFn9oJpO2kyAizLUZfdndKAaM SEnSqibQj0072GM0xF9Sc4xlFmxSgPW/QjLJFbZKzJCuxgJFI890FPob5BUK3Xhn ppgPrbyDn2c12mc0Uk+gyuZ41pa89pB5Ui8ZHt/tolKR6Qq+YbOHnyhgw3/fXBtP ebrmPXYgrQX9RreSH56DeDsHagCFYLs7W2iNeff3RdjQZex6o/SMHHEeTi+BR537 +P5I3kKIt3AAJODY+OYw== Received: from nalasppmta05.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3wf8p7j0bm-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sun, 25 Feb 2024 14:34:29 +0000 (GMT) Received: from nalasex01b.na.qualcomm.com (nalasex01b.na.qualcomm.com [10.47.209.197]) by NALASPPMTA05.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 41PEYSdT026435 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sun, 25 Feb 2024 14:34:28 GMT Received: from [10.216.1.166] (10.80.80.8) by nalasex01b.na.qualcomm.com (10.47.209.197) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.40; Sun, 25 Feb 2024 06:34:26 -0800 Message-ID: <38def880-b4f0-a4da-6189-b986d986e486@quicinc.com> Date: Sun, 25 Feb 2024 20:04:22 +0530 Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH 0/2] wifi: cfg80211/ath12k: Add support to rx retry stats Content-Language: en-US To: Johannes Berg , CC: References: <20240212121616.3683197-1-quic_haric@quicinc.com> From: Hari Chandrakanthan In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nalasex01b.na.qualcomm.com (10.47.209.197) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-ORIG-GUID: 80I_RjxbUadBD1LIF_7f1vNrBZQ94xbr X-Proofpoint-GUID: 80I_RjxbUadBD1LIF_7f1vNrBZQ94xbr X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-02-25_16,2024-02-23_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 spamscore=0 impostorscore=0 lowpriorityscore=0 priorityscore=1501 suspectscore=0 adultscore=0 malwarescore=0 bulkscore=0 mlxlogscore=737 clxscore=1011 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2402120000 definitions=main-2402250116 On 2/12/2024 6:25 PM, Johannes Berg wrote: > On Mon, 2024-02-12 at 17:46 +0530, Hari Chandrakanthan wrote: >> This patch series adds support to count station level rx retries. >> >> wifi: cfg80211: Add support to rx retry stats >> wifi: ath12k: Add support to rx retry stats >> >> Tested-on: QCN9274 hw1.0 PCI WLAN.WBE.1.2.1-00148-QCAHKSWPL_SILICONZ-1 >> >> Hari Chandrakanthan (2): >> wifi: cfg80211: Add support to rx retry stats >> wifi: ath12k: Add support to rx retry stats > There's trivial work here to expose them from mac80211, so please do > that. Also not entirely sure then why you need it in ath12k, but perhaps > if it's already done header conversion? > > johannes When RX_FLAG_8023 is set, the rx skb contains 802.3 header. Also the flag member(u32) in struct ieee80211_rx_status is also completely utilized. can we extend it to u64 and use a bit in the u64 to indicate that retry bit is set in 802.11 header when rx decap is offloaded?