Received-SPF: pass (google.com: domain of linux-wireless+bounces-3983-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
From: Ping-Ke Shih <pkshih@realtek.com>
To: Shiji Yang <yangshiji66@outlook.com>,
        "linux-wireless@vger.kernel.org"
	<linux-wireless@vger.kernel.org>
CC: Jes Sorensen <Jes.Sorensen@gmail.com>, Kalle Valo <kvalo@kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] wifi: rtl8xxxu: fix mixed declarations in rtl8xxxu_set_aifs()
Thread-Topic: [PATCH] wifi: rtl8xxxu: fix mixed declarations in
 rtl8xxxu_set_aifs()
Thread-Index: AQHaZl1h2HbwH7TQQEG2gknoSwbFfrEb1M2g
Date: Mon, 26 Feb 2024 01:18:05 +0000
Message-ID: <f281e9b6073143e7912f5d9ddb6ee217@realtek.com>
References: <TYAP286MB03157A408E0D69F2F6FBD88ABC552@TYAP286MB0315.JPNP286.PROD.OUTLOOK.COM>
In-Reply-To: <TYAP286MB03157A408E0D69F2F6FBD88ABC552@TYAP286MB0315.JPNP286.PROD.OUTLOOK.COM>
Accept-Language: en-US, zh-TW
Content-Language: zh-TW
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
MIME-Version: 1.0


> -----Original Message-----
> From: Shiji Yang <yangshiji66@outlook.com>
> Sent: Friday, February 23, 2024 9:35 PM
> To: linux-wireless@vger.kernel.org
> Cc: Jes Sorensen <Jes.Sorensen@gmail.com>; Kalle Valo <kvalo@kernel.org>;=
 linux-kernel@vger.kernel.org;
> Shiji Yang <yangshiji66@outlook.com>
> Subject: [PATCH] wifi: rtl8xxxu: fix mixed declarations in rtl8xxxu_set_a=
ifs()
>=20
> Moving struct ieee80211_sta *sta variable definition to the front
> of the code to fix the ISO C90 forbids mixed declarations and code
> warning.

I suppose there will be no this kind of warnings after
the commit b5ec6fd286df ("kbuild: Drop -Wdeclaration-after-statement") sinc=
e
v6.5. But as commit message mentioned --=20
" It will still be recommeneded to place declarations at the start of a
  scope where possible, but it will no longer be enforced."
Then, this patch looks good to me.=20

>=20
> Fixes: 43532c050f8e ("wifi: rtl8xxxu: support multiple interfaces in set_=
aifs()")
> Signed-off-by: Shiji Yang <yangshiji66@outlook.com>

Reviewed-by: Ping-Ke Shih <pkshih@realtek.com>