Received-SPF: pass (google.com: domain of linux-wireless+bounces-4000-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Mon, 26 Feb 2024 09:50:45 +0100
Message-ID: <87wmqrzk0q.wl-tiwai@suse.de>
From: Takashi Iwai <tiwai@suse.de>
To: Vlastimil Babka <vbabka@suse.cz>
Cc: Baochen Qiang <quic_bqiang@quicinc.com>,
	Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
	Jeff Johnson <quic_jjohnson@quicinc.com>,
	Takashi Iwai <tiwai@suse.de>,
	Jiri Slaby <jirislaby@kernel.org>,
	Kalle Valo <kvalo@kernel.org>,
	Linux Wireless <linux-wireless@vger.kernel.org>,
	ath11k@lists.infradead.org,
	LKML <linux-kernel@vger.kernel.org>,
	mhi@lists.linux.dev,
	linux-arm-msm@vger.kernel.org
Subject: Re: ath11k allocation failure on resume breaking wifi until power cycle
In-Reply-To: <a36b35a9-fb37-4afe-a718-a47dfe658cb5@suse.cz>
References: <96481a45-3547-4d23-ad34-3a8f1d90c1cd@suse.cz>
	<0994ae16-8174-4a04-b454-1974b16bc106@quicinc.com>
	<20240222054739.GG3374@thinkpad>
	<38c36d16-9cc1-4f03-b758-4a3ba90f8aa4@suse.cz>
	<abc0c24f-2137-41eb-bb99-80aea8dacdb2@quicinc.com>
	<a36b35a9-fb37-4afe-a718-a47dfe658cb5@suse.cz>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0
Precedence: bulk
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset=US-ASCII

On Mon, 26 Feb 2024 09:45:17 +0100,
Vlastimil Babka wrote:
> 
> On 2/26/24 03:09, Baochen Qiang wrote:
> > 
> > 
> > On 2/23/2024 11:28 PM, Vlastimil Babka wrote:
> >> On 2/22/24 06:47, Manivannan Sadhasivam wrote:
> >>> On Wed, Feb 21, 2024 at 08:34:23AM -0800, Jeff Johnson wrote:
> >>>> On 2/21/2024 6:39 AM, Vlastimil Babka wrote:
> >>>>> Hi,
> >>>>>
> >>>>> starting with 6.8 rc series, I'm experiencing problems on resume from s2idle
> >>>>> on my laptop, which is Lenovo T14s Gen3:
> >>>>>
> >>>>> LENOVO 21CRS0K63K/21CRS0K63K, BIOS R22ET65W (1.35 )
> >>>>> ath11k_pci 0000:01:00.0: wcn6855 hw2.1
> >>>>> ath11k_pci 0000:01:00.0: chip_id 0x12 chip_family 0xb board_id 0xff soc_id 0x400c1211
> >>>>> ath11k_pci 0000:01:00.0: fw_version 0x1106196e fw_build_timestamp 2024-01-12 11:30 fw_build_id WLAN.HSP.1.1-03125-QCAHSPSWPL_V1_V2_SILICONZ_LITE-3.6510.37
> >>>>>
> >>>>> The problem is an allocation failure happening on resume from s2idle. After
> >>>>> that the wifi stops working and even a reboot won't fix it, only a
> >>>>> poweroff/poweron cycle of the laptop.
> >>>>>
> >>>
> >>> Looks like WLAN is powered down during s2idle, which doesn't make sense. I hope
> >>> Jeff will figure out what's going on.
> >> 
> >> You mean the firmware is supposed to power it down/up transparently without
> >> kernel involvement? Because it should be powered down to save the power, no?
> > Let me clarify: from backtrace info, seems you are using a kernel with 
> > the hibernation-support patches [1] applied, which are not accepted yet 
> > to mainline kernel or even 
> > git://git.kernel.org/pub/scm/linux/kernel/git/mani/mhi.git.
> 
> Oh, you're right. Sorry for confusing you all. The rc kernel builds we have
> for openSUSE have nearly no non-upstream patches so it didn't really occur
> to me to double check if there might be in the area.
> 
> Seems Takashi (Cc'd) added them indeed to make hibernation work:
> https://bugzilla.suse.com/show_bug.cgi?id=1207948#c51

Yeah, and I'm afraid that we still have the ath11k hibernation patches
in our 6.8-rc default kernel (i.e. patches are in both master and
stable branches).  But you can test vanilla flavor that has certainly
no downstream patches at all.


thanks,

Takashi