Received-SPF: pass (google.com: domain of linux-wireless+bounces-4054-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
From: Kalle Valo <kvalo@kernel.org>
To: Ping-Ke Shih <pkshih@realtek.com>
Cc: Larry Finger <Larry.Finger@gmail.com>,  Johannes Berg
 <johannes@sipsolutions.net>,  "linux-wireless@vger.kernel.org"
 <linux-wireless@vger.kernel.org>,  "Nick Morrow" <morrownr@gmail.com>,
  Larry Finger <Larry.Finger@lwfinger.net>,  "stable@vger.kernel.org"
 <stable@vger.kernel.org>
Subject: Re: [PATCHi V2] wifi: rtw88: Add missing VID/PIDs doe 8811CU and
 8821CU
References: <4ume7mjw63u7.XlMUvUuacW2ErhOCdqlLkw2@1EHFQ.trk.elasticemail.com>
	<aab5bb779e1f470daeb0a4258e4bb764@realtek.com>
Date: Tue, 27 Feb 2024 08:38:48 +0200
In-Reply-To: <aab5bb779e1f470daeb0a4258e4bb764@realtek.com> (Ping-Ke Shih's
	message of "Tue, 27 Feb 2024 02:56:43 +0000")
Message-ID: <87h6hu9zt3.fsf@kernel.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux)
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain

Ping-Ke Shih <pkshih@realtek.com> writes:

> Hi Larry,
>
>> -----Original Message-----
>> From: Larry Finger <Larry.Finger@gmail.com>
>> Sent: Tuesday, February 27, 2024 10:35 AM
>> To: Kalle Valo <kvalo@kernel.org>
>> Cc: Johannes Berg <johannes@sipsolutions.net>; linux-wireless@vger.kernel.org; Nick Morrow
>> <morrownr@gmail.com>; Larry Finger <Larry.Finger@lwfinger.net>; Ping-Ke Shih <pkshih@realtek.com>;
>> stable@vger.kernel.org
>> Subject: [PATCHi V2] wifi: rtw88: Add missing VID/PIDs doe 8811CU and 8821CU
>
> Not sure if "doe" is typo?

I think it means "for" but Larry's finger was one key off to the left :) I can fix that.

>> From: Nick Morrow <morrownr@gmail.com>
>> 
>> Purpose: Add VID/PIDs that are known to be missing for this driver.
>> - removed  /* 8811CU */ and /* 8821CU */ as they are redundant
>> since the file is specific to those chips.
>> - removed /* TOTOLINK A650UA v3 */ as the manufacturer. It has a REALTEK
>> VID so it may not be specific to this adapter.
>> 
>> Source is
>> https://1EHFQ.trk.elasticemail.com/tracking/click?d=I82H0YR_W_h175Lb3Nkb0D8i6IqvuhESe0WLnY6P7IVwR1UKvB
>> 0SPxd1Olp3PNJEJTqsu4kyqBXayE0BVd_k7uLFvlTe65Syx2uqLUB-UQSfsKKLkuyE-frMZXSCL7q824UG3Oer614GGEeEz-DNEWHh
>> 43p_e8oz7OouS6gRBEng0
>> Verified and tested.
>> 
>> Signed-off-by: Nick Morrow <morrownr@gmail.com>
>> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
>> Acked-by: Ping-Ke Shih <pkshih@realtek.com>
>> 
>
> Did you keep a blank line intentionally? 

I can fix this as well. I'll also move 'cc: stable' to the beginning of
tags.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches