Received-SPF: pass (google.com: domain of linux-wireless+bounces-4059-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <5c5ad99d3c2f3b9915b440057eab6618639cd31f.camel@sipsolutions.net>
Subject: Re: [PATCH 2/6] wifi: ath11k: add P2P IE in beacon template
From: Johannes Berg <johannes@sipsolutions.net>
To: Kang Yang <quic_kangyang@quicinc.com>, Jeff Johnson
	 <quic_jjohnson@quicinc.com>, ath11k@lists.infradead.org
Cc: linux-wireless@vger.kernel.org
Date: Tue, 27 Feb 2024 08:32:48 +0100
In-Reply-To: <b20fc717-654d-4e64-920f-699fe3ec5598@quicinc.com>
References: <20240226060203.2040444-1-quic_kangyang@quicinc.com>
	 <20240226060203.2040444-3-quic_kangyang@quicinc.com>
	 <42652a06-33f3-445a-bd8a-da4633fa52f8@quicinc.com>
	 <b20fc717-654d-4e64-920f-699fe3ec5598@quicinc.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.50.4 (3.50.4-1.fc39) 
Precedence: bulk
MIME-Version: 1.0

On Tue, 2024-02-27 at 14:58 +0800, Kang Yang wrote:
>=20
> > > +	if (arvif->vif->type !=3D NL80211_IFTYPE_AP || !arvif->vif->p2p)
> >=20
> > this logic isn't applicable for NL80211_IFTYPE_P2P_GO ?
>=20
> The original intention here is to determine if it is P2P GO, if yes,=20
> continue, otherwise return.
>=20
>=20
> Maybe this judgment is a bit misleading, let me replace with
> if (arvif->vdev_subtype !=3D WMI_VDEV_SUBTYPE_P2P_GO) ?

There's also

	ieee80211_vif_type_p2p(arvif->vif) !=3D NL80211_IFTYPE_P2P_GO

if you wanted to write it that way.

@Jeff: NL80211_IFTYPE_P2P_GO is not used by mac80211 internally, it
translates that to vif->type=3D=3DNL80211_IFTYPE_AP && vif->p2p=3D=3Dtrue.

johannes