Received-SPF: pass (google.com: domain of linux-wireless+bounces-4063-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <719c19d4-1c1a-40e8-8375-06b5f04f885d@quicinc.com>
Date: Tue, 27 Feb 2024 16:40:19 +0800
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: ath11k allocation failure on resume breaking wifi until power
 cycle
Content-Language: en-US
To: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
CC: Vlastimil Babka <vbabka@suse.cz>,
        Jeff Johnson
	<quic_jjohnson@quicinc.com>,
        Takashi Iwai <tiwai@suse.de>, Jiri Slaby
	<jirislaby@kernel.org>,
        Kalle Valo <kvalo@kernel.org>,
        Linux Wireless
	<linux-wireless@vger.kernel.org>,
        <ath11k@lists.infradead.org>, LKML
	<linux-kernel@vger.kernel.org>,
        <mhi@lists.linux.dev>, <linux-arm-msm@vger.kernel.org>
References: <96481a45-3547-4d23-ad34-3a8f1d90c1cd@suse.cz>
 <0994ae16-8174-4a04-b454-1974b16bc106@quicinc.com>
 <20240222054739.GG3374@thinkpad>
 <38c36d16-9cc1-4f03-b758-4a3ba90f8aa4@suse.cz>
 <abc0c24f-2137-41eb-bb99-80aea8dacdb2@quicinc.com>
 <a36b35a9-fb37-4afe-a718-a47dfe658cb5@suse.cz>
 <34123ee0-26c9-4240-8d58-aba02f7c66b9@quicinc.com>
 <20240226114307.GA8422@thinkpad>
 <c4b7ec62-7d2d-438b-904d-d935e09e517c@quicinc.com>
 <20240227071915.GE2587@thinkpad>
From: Baochen Qiang <quic_bqiang@quicinc.com>
In-Reply-To: <20240227071915.GE2587@thinkpad>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit


On 2/27/2024 3:19 PM, Manivannan Sadhasivam wrote:
> On Tue, Feb 27, 2024 at 10:43:22AM +0800, Baochen Qiang wrote:
>>
>>
>> On 2/26/2024 7:43 PM, Manivannan Sadhasivam wrote:
>>> On Mon, Feb 26, 2024 at 05:11:17PM +0800, Baochen Qiang wrote:
>>>>
>>>>
>>>> On 2/26/2024 4:45 PM, Vlastimil Babka wrote:
>>>>> On 2/26/24 03:09, Baochen Qiang wrote:
>>>>>>
>>>>>>
>>>>>> On 2/23/2024 11:28 PM, Vlastimil Babka wrote:
>>>>>>> On 2/22/24 06:47, Manivannan Sadhasivam wrote:
>>>>>>>> On Wed, Feb 21, 2024 at 08:34:23AM -0800, Jeff Johnson wrote:
>>>>>>>>> On 2/21/2024 6:39 AM, Vlastimil Babka wrote:
>>>>>>>>>> Hi,
>>>>>>>>>>
>>>>>>>>>> starting with 6.8 rc series, I'm experiencing problems on resume from s2idle
>>>>>>>>>> on my laptop, which is Lenovo T14s Gen3:
>>>>>>>>>>
>>>>>>>>>> LENOVO 21CRS0K63K/21CRS0K63K, BIOS R22ET65W (1.35 )
>>>>>>>>>> ath11k_pci 0000:01:00.0: wcn6855 hw2.1
>>>>>>>>>> ath11k_pci 0000:01:00.0: chip_id 0x12 chip_family 0xb board_id 0xff soc_id 0x400c1211
>>>>>>>>>> ath11k_pci 0000:01:00.0: fw_version 0x1106196e fw_build_timestamp 2024-01-12 11:30 fw_build_id WLAN.HSP.1.1-03125-QCAHSPSWPL_V1_V2_SILICONZ_LITE-3.6510.37
>>>>>>>>>>
>>>>>>>>>> The problem is an allocation failure happening on resume from s2idle. After
>>>>>>>>>> that the wifi stops working and even a reboot won't fix it, only a
>>>>>>>>>> poweroff/poweron cycle of the laptop.
>>>>>>>>>>
>>>>>>>>
>>>>>>>> Looks like WLAN is powered down during s2idle, which doesn't make sense. I hope
>>>>>>>> Jeff will figure out what's going on.
>>>>>>>
>>>>>>> You mean the firmware is supposed to power it down/up transparently without
>>>>>>> kernel involvement? Because it should be powered down to save the power, no?
>>>>>> Let me clarify: from backtrace info, seems you are using a kernel with
>>>>>> the hibernation-support patches [1] applied, which are not accepted yet
>>>>>> to mainline kernel or even
>>>>>> git://git.kernel.org/pub/scm/linux/kernel/git/mani/mhi.git.
>>>>>
>>>>> Oh, you're right. Sorry for confusing you all. The rc kernel builds we have
>>>>> for openSUSE have nearly no non-upstream patches so it didn't really occur
>>>>> to me to double check if there might be in the area.
>>>>>
>>>>> Seems Takashi (Cc'd) added them indeed to make hibernation work:
>>>>> https://bugzilla.suse.com/show_bug.cgi?id=1207948#c51
>>>>>
>>>>> But then, why do they affect also s2idle, is it intentional? And why I only
>>>> Yes, it's intentional. When suspend/resume, ath11k does the same for either
>>>> a s2idle suspend or a deep one.
>>>>
>>>
>>> That's a terrible idea for usecases like Android IMO. s2idle happens very often
>>> on Android platforms (screen lock) and do you want to powerdown the WLAN device
>>> all the time?
>> I am not familiar with Android case. Is WoWLAN enabled in that case? I am
>> asking this because if WoWLAN is enabled ath11k goes another path and only
>> calls mhi_pm_suspend()/resume() instead of mhi_power_down()/up().
>>
> 
> I don't work on Android platform, no idea about WoWLAN. But I just raised a
> possible issue. Please check with the Qcom internal Android teams about this. If
> it is not going to be an issue (different code path as you said above), then
> feel free to ignore my comment.
Thanks Mani.

> 
> - Mani
> 
>>>
>>> Even though it offers power saving, I'm worried about the latency and possible
>>> teardown of the chipset. Later is only valid if the chipset undergoes complete
>>> power cycle though.
>>>
>>> - Mani
>>>
>>>>> started seeing the problems in 6.8, the patches are there since August.
>>>>>
>>>>>> So this is why you see WLAN firmware is powered down during suspend.
>>>>>>
>>>>>> [1]
>>>>>> https://patchwork.kernel.org/project/linux-wireless/cover/20231127162022.518834-1-kvalo@kernel.org/
>>>>>>
>>>>>>>
>>>>>>> But I just found out that when I build my own kernel using the distro config
>>>>>>> as base but reduced by make localmodconfig, the "mhi mhi0: Requested to
>>>>>>> power ON" and related messages don't occur anymore, so there's something
>>>>>>> weird going on.
>>>>>> Here your own kernel doesn't include the hibernation-support patches, right?
>>>>>
>>>>> Right.
>>>>>
>>>>>
>>>>>
>>>
>