Received-SPF: pass (google.com: domain of linux-wireless+bounces-4104-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <f7e9edcb7c1d08144dddcd493aff869a80888cd8.camel@sipsolutions.net>
Subject: Re: [PATCH 2/6] wifi: ath11k: add P2P IE in beacon template
From: Johannes Berg <johannes@sipsolutions.net>
To: Jeff Johnson <quic_jjohnson@quicinc.com>, Kang Yang
	 <quic_kangyang@quicinc.com>, ath11k@lists.infradead.org
Cc: linux-wireless@vger.kernel.org
Date: Tue, 27 Feb 2024 16:11:43 +0100
In-Reply-To: <3582b1ea-e103-4b7f-b34e-6457964bdb93@quicinc.com>
References: <20240226060203.2040444-1-quic_kangyang@quicinc.com>
	 <20240226060203.2040444-3-quic_kangyang@quicinc.com>
	 <42652a06-33f3-445a-bd8a-da4633fa52f8@quicinc.com>
	 <b20fc717-654d-4e64-920f-699fe3ec5598@quicinc.com>
	 <5c5ad99d3c2f3b9915b440057eab6618639cd31f.camel@sipsolutions.net>
	 <3582b1ea-e103-4b7f-b34e-6457964bdb93@quicinc.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.50.4 (3.50.4-1.fc39) 
Precedence: bulk
MIME-Version: 1.0

On Tue, 2024-02-27 at 07:05 -0800, Jeff Johnson wrote:
> On 2/26/2024 11:32 PM, Johannes Berg wrote:
> > @Jeff: NL80211_IFTYPE_P2P_GO is not used by mac80211 internally, it
> > translates that to vif->type=3D=3DNL80211_IFTYPE_AP && vif->p2p=3D=3Dtr=
ue.
>=20
> Yesterday I was looking at another patch and while doing so noticed this
> as well. Too many years of working with our downstream Android driver
> where we use the P2P iftypes directly...

I do sometimes wonder if this was the right decision ... but I think
it'll be quite difficult to change it now.

johannes