Received: by 2002:a05:7208:9594:b0:7e:5202:c8b4 with SMTP id gs20csp1982976rbb; Tue, 27 Feb 2024 07:14:59 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCUJ+rKPS+RXdn1jcGavROHsujSzuMvOTg9zLFg+CLGnHu9wpekkdMdSiszgP6+7p917iM1aRQXRVdVtFZXTo5qOoBDllQunba1fkTRdYA== X-Google-Smtp-Source: AGHT+IFCCykE2RNI9M7/EExGkHq9JQlfe9y2PwRK2wjxjxYdzJJktpwdLEq2eHev3nAuWck6FyA0 X-Received: by 2002:a17:903:1ca:b0:1dc:afd1:a85a with SMTP id e10-20020a17090301ca00b001dcafd1a85amr5125286plh.2.1709046899297; Tue, 27 Feb 2024 07:14:59 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1709046899; cv=pass; d=google.com; s=arc-20160816; b=J8T1yid9SczsdzlGvqYsBj9KKDhNuwcbbPBRihuQ/WDP7cr0J8U5UPNC/w0hmblZg3 S6GR7Fo8vrWdN3zYkgKi01SjcIF1SpUwBDWHl/rdNKCRz6GsnahdAIGk+JJRGiPEv/ys NAfN4gXewRNaQLBatTmaIaAeSC7p6JuY1lVEHjh8Bcu4Mmcp8igc398M4tUT8PvtZtwt qZ0alPCkf7hzi10Pa2YXTrVaAv/bv5yIt61KgJhhytlw7zAtn+STTEpLeIJ+0RhLChmq ZD8u03up11sWiezJXyKIcli9zxdDMKBPVr7yUwKsAs0Xq4Ek5JdmB51mAnUUq1lEPzAU OXOQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=date:message-id:user-agent:cc:to:references:in-reply-to:from :subject:content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:dkim-signature; bh=ZqpErkHUv96tHTRuunwYqqV3CM3rt7uV0aB/IGrkGH0=; fh=be7VgAvYvd5HUKtNh6uAwQMd9UnN2Vahc/zBYS/pxiY=; b=M6KPNooVucI+aB9l7oEx7UbCQfFDMwHZ6/pGTuVTAo9WfCPOhT8ROSiMxSSaJt6qfF ZqJkAPpgjxAiHycrzq+GG08zi4XKRLl1jJRnRUvwv9AIXBr0joH0/HaTYfWqAz2VJBHP EL2V2RNFcz8md/cxju6u45ISQ5iT+WL5O7iDC2S7ZhmXnlP1MAxwuthOnQFjXTC+17TE tq1/oNkpLD8U5GEk6u9bcgRiEfuRL6XhpfnZMuG3mFlzuuOMmTElfj3HJrtvZDwb7JWf FXrp76BfE1ZVFOOJ+oAI8/W1R2eXmukmd9syL8bQOuoI8C2k3cLs4i6Sq7DsWSe7QKe9 p4ag==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=VfdIbFiA; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-wireless+bounces-4100-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-wireless+bounces-4100-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id w16-20020a1709026f1000b001dbc1a37d5asi1464274plk.143.2024.02.27.07.14.59 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 Feb 2024 07:14:59 -0800 (PST) Received-SPF: pass (google.com: domain of linux-wireless+bounces-4100-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=VfdIbFiA; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-wireless+bounces-4100-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-wireless+bounces-4100-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 8A60829231F for ; Tue, 27 Feb 2024 15:00:47 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id CB09C146E78; Tue, 27 Feb 2024 14:56:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="VfdIbFiA" X-Original-To: linux-wireless@vger.kernel.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A733F1420DA for ; Tue, 27 Feb 2024 14:56:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709045799; cv=none; b=U4SYGQOQlCOldkYcrX3VUCjTbnnYuYHygpRfevqbZdzbD0UZUa6oKoTTl3/2UzXrk+xV4C5eY/A2NNxsyov8ZLH8YBFAeGOFNU2Opx8vx61PYTwRXr38DDppYkz/F6XIIktiF5QIAkzxQgndGgTVOyBxvPqqyVTZu5Qac0GjUtA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709045799; c=relaxed/simple; bh=Y3WrbVf+zXjlHmiuaEIPfq4mrsRuxpYZC6+H/cNO4Ag=; h=Content-Type:MIME-Version:Subject:From:In-Reply-To:References:To: Cc:Message-ID:Date; b=JEcMdY4DS+OuvWkBecqkrlGDtT/rx8FQBJWyHMn6n9coH0DSTOhV1u8K+h7nt6d+IhCd2ITuhTpLQ/gf3u+/ld9VEUgywQhMmB63pLqO6o/hArIEjyk6rPUZSihTc5WL28rl1QN8PylBptqXJiIj9E6J1kUnJZ3y5d9wnIC7KPI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=VfdIbFiA; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 101CAC433C7; Tue, 27 Feb 2024 14:56:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1709045799; bh=Y3WrbVf+zXjlHmiuaEIPfq4mrsRuxpYZC6+H/cNO4Ag=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=VfdIbFiAbBWTzpYIc+h24iC3LbYDehrrsdAaWewgAx9g2E4Sd2nyARRmDsLEXZW2X Q7FjBx0nwqNE0UchYfoO2KOhgcIUfo6lpguJmiUyIhxWH4bI8PX3HAXsq42jwzz74I Erz0pDPzlvQjBPc7XPvswKXzN2xPKxRYBXaPrSZ2vo/Hp4NNs62l9CWCZZbpgbeeSu qVHAcu2QK3Gsrh3U4PJFKW9c3m819xtHNT7ILtq0tR9TIGu4PbCWK6tuu3IX/5yMhE 4JNtIW2At6oaKhJT9s+vIckCtnA4oz2KL3x7Aj5KTvvMEVu3zGtgSyrGgAWObsK9Jg ebjVvy9R4apng== Content-Type: text/plain; charset="utf-8" Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [v2] wifi: brcmfmac: do not pass hidden SSID attribute as value directly From: Kalle Valo In-Reply-To: <20240222122923.46691-1-a@bayrepo.ru> References: <20240222122923.46691-1-a@bayrepo.ru> To: Alexey Berezhok Cc: Arend van Spriel , linux-wireless@vger.kernel.org, lvc-project@linuxtesting.org, Alexey Berezhok User-Agent: pwcli/0.1.1-git (https://github.com/kvalo/pwcli/) Python/3.11.2 Message-ID: <170904579603.3524945.4084111690465874956.kvalo@kernel.org> Date: Tue, 27 Feb 2024 14:56:37 +0000 (UTC) Alexey Berezhok wrote: > In brcmf_cfg80211_start_ap() do not assume that NL80211_HIDDEN_SSID_NOT_IN_USE > is zero but prefer an explicit check instead. Use local variable 'closednet' > to pass in function call and use for error message. > > Compile tested only. Addition for the commit f20073f50dfd1 ("wifi: brcmfmac: do > not cast hidden SSID attribute value to boolean"). > > Signed-off-by: Alexey Berezhok > Acked-by: Arend van Spriel Patch applied to wireless-next.git, thanks. 379e5e83f9f9 wifi: brcmfmac: do not pass hidden SSID attribute as value directly -- https://patchwork.kernel.org/project/linux-wireless/patch/20240222122923.46691-1-a@bayrepo.ru/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches