Received-SPF: pass (google.com: domain of linux-wireless+bounces-4107-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <aacc9bf5-90e3-4e7a-af44-33d11fe89c18@gmail.com>
Date: Tue, 27 Feb 2024 18:27:51 +0200
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 1/4] wifi: rtw88: 8821cu: Fix firmware upload fail
To: Sascha Hauer <sha@pengutronix.de>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
 Ping-Ke Shih <pkshih@realtek.com>, Sean Mollet <sean@malmoset.com>
References: <731ea688-04ef-4f02-9d01-3e9026981057@gmail.com>
 <Zd3b81m3_Hh47lww@pengutronix.de>
Content-Language: en-US
From: Bitterblue Smith <rtl8821cerfe2@gmail.com>
In-Reply-To: <Zd3b81m3_Hh47lww@pengutronix.de>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

Adding Sean Mollet because I forgot earlier.

On 27/02/2024 14:56, Sascha Hauer wrote:
> On Tue, Feb 27, 2024 at 02:18:20PM +0200, Bitterblue Smith wrote:
>> +	if (addr < 0xFE00) {
>> +		if (addr <= 0xff)
>> +			current_reg_sec = REG_ON_SEC;
>> +		else if (0x1000 <= addr && addr <= 0x10ff)
>> +			current_reg_sec = REG_ON_SEC;
>> +		else
>> +			current_reg_sec = REG_OFF_SEC;
>> +	} else {
>> +		current_reg_sec = REG_LOCAL_SEC;
>> +	}
>> +
>> +	if (current_reg_sec != REG_ON_SEC)
>> +		return;
> 
> Is there something we want to do with current_reg_sec == REG_LOCAL_SEC
> or current_reg_sec == REG_OFF_SEC later? If not the above could be
> rewritten as:
> 
> 	if (addr > 0xff && addr < 0x1000)
> 		return;
> 	if (addr > 0x10ff)
> 		return;
> 
> 	...

Dunno, I just copied the code from the other drivers:

https://github.com/morrownr/8821cu-20210916/blob/5b39398e2de146edeb76716420f3288f508bea61/os_dep/linux/usb_ops_linux.c#L171
https://github.com/morrownr/88x2bu-20210702/blob/bb6e514230791010a34daf0d6ccf55ef97309dbf/os_dep/linux/usb_ops_linux.c#L171
https://github.com/thales-dis-dr/rtl8822CU/blob/4182c79e0c5362dcea46088dab9fed27795b5579/os_dep/linux/usb_ops_linux.c#L171