Received-SPF: pass (google.com: domain of linux-wireless+bounces-4114-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <421ad59de37ac6bb52c95dde2e3d4bb28590ecca.camel@perches.com>
Subject: Re: [PATCH] wifi: brcm80211: handle pmk_op allocation failure
From: Joe Perches <joe@perches.com>
To: Arend van Spriel <arend.vanspriel@broadcom.com>, Duoming Zhou
	 <duoming@zju.edu.cn>, linux-kernel@vger.kernel.org
Cc: brcm80211-dev-list.pdl@broadcom.com, brcm80211@lists.linux.dev, 
 linux-wireless@vger.kernel.org, justinstitt@google.com, john@keeping.me.uk,
  quic_alokad@quicinc.com, marcan@marcan.st, johannes.berg@intel.com, 
 linus.walleij@linaro.org, kvalo@kernel.org
Date: Tue, 27 Feb 2024 11:58:30 -0800
In-Reply-To: <d5ce0495-2f18-4176-90e5-7bba76132ea1@broadcom.com>
References: <20240227080613.34001-1-duoming@zju.edu.cn>
	 <87166784-79ab-4eb4-ad1e-af4bc31757b7@broadcom.com>
	 <b0a352781f58a829deadffbe2ef2085c97c6ab32.camel@perches.com>
	 <d5ce0495-2f18-4176-90e5-7bba76132ea1@broadcom.com>
Content-Type: text/plain; charset="ISO-8859-1"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.48.4 (3.48.4-1.fc38) 
Precedence: bulk
MIME-Version: 1.0

On Tue, 2024-02-27 at 20:40 +0100, Arend van Spriel wrote:
> On 2/27/2024 12:42 PM, Joe Perches wrote:
> > On Tue, 2024-02-27 at 12:21 +0100, Arend van Spriel wrote:
> > > On 2/27/2024 9:06 AM, Duoming Zhou wrote:
> > > > The kzalloc() in brcmf_pmksa_v3_op() will return null if the
> > > > physical memory has run out. As a result, if we dereference
> > > > the null value, the null pointer dereference bug will happen.
> > > >=20
> > > > Return -ENOMEM from brcmf_pmksa_v3_op() if kzalloc() fails
> > > > for pmk_op.
> > >=20
> > > NAK (see below)
> > >=20
> > > Also this issue was reported earlier by Joe Perches. Not sure if he
> > > wants to be mentioned as such.
> >=20
> > I think it's unimportant to be mentioned.
> >=20
> > I think it's more important that the code be researched
> > that the simple return of -ENOMEM the appropriate fix
> > and is handled by all possible callers of the function.
>=20
> Right. That is what I did after which I replied on Feb 18 to your email.
>=20
> https://lore.kernel.org/all/3e1f11b3-a689-4c8e-bfda-b43649db7106@broadcom=
.com/
>=20

Right, I did that as well, but I didn't look up
the entire calling tree.

It likely works.  It's also likely better than
the write through of the null pointer.