Received-SPF: pass (google.com: domain of linux-wireless+bounces-4153-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Wed, 28 Feb 2024 09:55:49 +0100
From: Sascha Hauer <sha@pengutronix.de>
To: Bitterblue Smith <rtl8821cerfe2@gmail.com>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
	Ping-Ke Shih <pkshih@realtek.com>, Sean Mollet <sean@malmoset.com>
Subject: Re: [PATCH 1/4] wifi: rtw88: 8821cu: Fix firmware upload fail
Message-ID: <Zd71FWoTDn5plI5R@pengutronix.de>
References: <731ea688-04ef-4f02-9d01-3e9026981057@gmail.com>
 <Zd3b81m3_Hh47lww@pengutronix.de>
 <aacc9bf5-90e3-4e7a-af44-33d11fe89c18@gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <aacc9bf5-90e3-4e7a-af44-33d11fe89c18@gmail.com>

On Tue, Feb 27, 2024 at 06:27:51PM +0200, Bitterblue Smith wrote:
> Adding Sean Mollet because I forgot earlier.
> 
> On 27/02/2024 14:56, Sascha Hauer wrote:
> > On Tue, Feb 27, 2024 at 02:18:20PM +0200, Bitterblue Smith wrote:
> >> +	if (addr < 0xFE00) {
> >> +		if (addr <= 0xff)
> >> +			current_reg_sec = REG_ON_SEC;
> >> +		else if (0x1000 <= addr && addr <= 0x10ff)
> >> +			current_reg_sec = REG_ON_SEC;
> >> +		else
> >> +			current_reg_sec = REG_OFF_SEC;
> >> +	} else {
> >> +		current_reg_sec = REG_LOCAL_SEC;
> >> +	}
> >> +
> >> +	if (current_reg_sec != REG_ON_SEC)
> >> +		return;
> > 
> > Is there something we want to do with current_reg_sec == REG_LOCAL_SEC
> > or current_reg_sec == REG_OFF_SEC later? If not the above could be
> > rewritten as:
> > 
> > 	if (addr > 0xff && addr < 0x1000)
> > 		return;
> > 	if (addr > 0x10ff)
> > 		return;
> > 
> > 	...
> 
> Dunno, I just copied the code from the other drivers:
> 
> https://github.com/morrownr/8821cu-20210916/blob/5b39398e2de146edeb76716420f3288f508bea61/os_dep/linux/usb_ops_linux.c#L171

Ok, nothing is done with current_reg_sec here as well, so I suggest
rewriting the check like I suggested.

Sascha

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |